[wp-trac] [WordPress Trac] #10889: filesystem's put_content() methods have inconsistent arguments -- causes .maintenance file to not be created

[WordPress Trac]

#10889: filesystem's put_content() methods have inconsistent arguments -- causes
.maintenance file to not be created
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  dd32                  
     Type:  defect (bug)       |      Status:  new                   
 Priority:  normal             |   Milestone:  3.0                   
Component:  Filesystem         |     Version:  2.8.4                 
 Severity:  normal             |    Keywords:  has-patch dev-feedback
-------------------------------+--------------------------------------------
Changes (by dd32):

  * keywords:  needs-patch => has-patch dev-feedback


Comment:

 Ah.. Just noticed $type is used for a fopen type name in direct, and
 Ascii/Binary in FTP, and not used at all for ssh, and not needed in any of
 the cases.

 Personally, I'm all for just removing the $type param all together. Its
 not used by core, and cant be used by plugins due to it doing who-knows-
 what depending on the setup.

 3rd patch on this ticket does just that, removes $type all together. which
 i'd prefer over the 2nd patch.

 So:
  * for 2.9, If you're happy removing a unuseable buggy param, 3rd patch.
  * If you'd rather just make them all act "the same" to core, the 2nd
 patch.
  * Or just wait until 3.0 and use the 3rd patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10889#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software