[wp-trac] [WordPress Trac] #10653: Update comment_author when display_name changes

WordPress Trac wp-trac at lists.automattic.com
Wed Dec 9 00:44:35 UTC 2009


#10653: Update comment_author when display_name changes
-----------------------+----------------------------------------------------
  Reporter:  mptre     |        Type:  enhancement
    Status:  reopened  |    Priority:  normal     
 Milestone:  3.0       |   Component:  Comments   
   Version:            |    Severity:  normal     
Resolution:            |    Keywords:  needs-patch
-----------------------+----------------------------------------------------
Changes (by Denis-de-Bernardy):

  * keywords:  has-patch close => needs-patch
  * status:  closed => reopened
  * resolution:  wontfix =>
  * milestone:  => 3.0


Comment:

 Replying to [comment:9 apljdi]:

 I had only scanned this ticket, having stayed on the discussions on #5787

 > >  - Previously approved comments are changed without admin
 notification/approval.
 >
 > In what way? mpretty's patch doesn't update anything it checks for an
 existing user and uses the display_name if a user is found. Nothing is
 changed.

 Picture the commenter's name gets changed to... mmm (checking my spam),
 SEO services, Viagra, Pharmacy pills, Yoga tips, whatever...

 > > = Isn't compatible with WP Mu.
 >
 > Valid point. I don't WPMU enough to know what it would take to make it
 compatible.

 Basically, you've as many wpmu comments tables as you've blogs.

 The patch in this ticket is better than the ones from other tickets, in
 that -- contrary to the other ones -- it's dynamic. And your idea of
 "initially posted by..." makes sense to work around two of lloydbudd's
 above-mentioned points.

 I think it also works around the WPMU issue. Re-opening. Needs a new patch
 and core dev feedback, though.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10653#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list