[wp-trac] Re: [WordPress Trac] #4907: add_menu_page() create faulty links

WordPress Trac wp-trac at lists.automattic.com
Sat Feb 9 01:55:15 GMT 2008


#4907: add_menu_page() create faulty links
-------------------------------------+--------------------------------------
 Reporter:  markjaquith              |        Owner:  markjaquith
     Type:  defect                   |       Status:  assigned   
 Priority:  high                     |    Milestone:  2.5        
Component:  General                  |      Version:  2.3        
 Severity:  major                    |   Resolution:             
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Changes (by DD32):

  * keywords:  => has-patch needs-testing

Comment:

 There seems to be a lot of code in the admin menu generation, I'd be
 supprised if it cant be slimmed down a tad-bit, But its over my head what
 most of it seems to do.

 Regardless, I've spent awhile trying to work out this bug, I was initially
 supprised to find it considering the plugins i've been writing that use
 top level menu's have worked perfectly. It seems thats generally because i
 set '$file' to either the foldername or the files name..

 Added a check to the Main plugin section list to check for a callback for
 the given page. Had to hard-code 'admin.php' into the hook check, I
 couldnt see any other way about it.

 I've tested the patch with a few combinations i could think of, and
 everything seems to work as expected, However definately needs testing
 with other combinations.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4907#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list