[wp-trac] [WordPress Trac] #7532: Need comment_modified_date_gmt for approvals and edits

WordPress Trac wp-trac at lists.automattic.com
Sun Aug 17 04:45:49 GMT 2008


#7532: Need comment_modified_date_gmt for approvals and edits
---------------------+------------------------------------------------------
 Reporter:  lapcat   |       Owner:  anonymous
     Type:  defect   |      Status:  new      
 Priority:  normal   |   Milestone:  2.7      
Component:  General  |     Version:  2.6      
 Severity:  normal   |    Keywords:           
---------------------+------------------------------------------------------
 Summary:[[BR]]
 Currently there is only one date field for comments, comment_date_gmt.
 This is insufficient, because it represents only the creation date, not
 the approval date. The function get_lastcommentmodified can only check
 comment_date_gmt, which means that it can return an earlier date than the
 approval date. This can lead to RSS feeds wrongly returned HTTP 304 Not
 Modified responses. There needs to be comment_modified_date_gmt in
 addition to comment_date_gmt.

 Steps to Reproduce:[[BR]]
 (1) First comment is submitted.[[BR]]
 (2) First comment is mistakenly marked as spam by Akismet.[[BR]]
 (3) Second comment is submitted and posted.[[BR]]
 (4) Check comments feed in RSS reader. Second comment appears in feed,
 first comment does not.[[BR]]
 (5) Mark first comment as not spam.[[BR]]
 (6) Check comments feed in RSS reader again.

 Expected results:[[BR]]
 Comments feed returns HTTP 200, because there is a new comment in the
 feed.

 Actual results:[[BR]]
 Comments feed returns HTTP 304.

 Notes:[[BR]]
 The same bug could occur in other circumstances. For example, if a comment
 was held for moderation.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7532>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list