[wp-trac] Re: [WordPress Trac] #7498: Revised RTL CSS for 2.6

[WordPress Trac]

#7498: Revised RTL CSS for 2.6
----------------------------------------+-----------------------------------
 Reporter:  mani_monaj                  |        Owner:  anonymous
     Type:  enhancement                 |       Status:  new      
 Priority:  high                        |    Milestone:  2.6.1    
Component:  i18n                        |      Version:           
 Severity:  normal                      |   Resolution:           
 Keywords:  rtl, i18n tested has-patch  |  
----------------------------------------+-----------------------------------
Changes (by RanYanivHartstein):

  * keywords:  rtl, i18n => rtl, i18n tested has-patch

Comment:

 This is a great patch, thanks a lot on behalf of any RTLer that hasn't
 already thanked you.

 I tested it on FF3, IE7 and IE6 and noticed a few minor issues, I'm
 including a patch to address them:

 * Fonts re-set back to a more generic "sans-serif", so for every script
 and every platform the best/most common font is chosen. This was discussed
 in #6616.

 * Fixed peek-a-boo bug with sidemenu in IE6

 * Added white space before submenu, to align it with the main menu and
 other admin widgets

 * Centered media-upload window in IE

 * Fixed submenu in media-upload window in IE (it would get offset way out
 of view to the left)

 * Fixed install pages in IE6 (half the page would get hidden out of view
 to the right)

 Apart from these changes, my patch is identical to yours.

 There is one issue I didn't presume to address in my patch, but I do think
 it's worthy discussing - the credit issue. In your patch, all the RTL
 files are tagged by your team, with specific credit to one Navid Kashani.

 While your work was of course noteworthy and deserving of credit, placing
 that credit in every file has the side effect of denying credit from any
 other developers and testers who worked on the RTL style sheets, my self
 included. Since there is no reasonable way to properly credit everyone who
 contributed to these styles, I think it would be best to avoid this
 practice all together, and commit these files without those lines - like
 all the other files in the WordPress source.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7498#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software