[wp-trac] [WordPress Trac] #5285: Problematic markup in searchform widget for styling

[WordPress Trac]

#5285: Problematic markup in searchform widget for styling
----------------------+-----------------------------------------------------
 Reporter:  Wolfr     |       Owner:  anonymous
     Type:  task      |      Status:  new      
 Priority:  normal    |   Milestone:  2.5      
Component:  Template  |     Version:           
 Severity:  normal    |    Keywords:           
----------------------+-----------------------------------------------------
 This is the markup for the searchform widget:
 {{{
                         <div>
                                 <input type="text" name="s" id="s"
 size="15" /><br />
                                 <input type="submit" value="<?php echo
 attribute_escape(__('Search')); ?>" />
                         </div>
 }}}
 Problems:[[BR]]

 * The line break (br) makes it impossible to style the widgets to have
 search input[[BR]]
  next to submit, now submit is always underneath the text input[[BR]]

 * The submit button doesn't have a class nor id, so you can't style
 it.[[BR]]

 * The naming of the input type text's id is quite problematic[[BR]]


 Proposed solution:

 {{{
                                 <div>
                                         <input type="text"
 name="searchinput" class="input-text" size="15" />
                                         <input type="submit" class="input-
 submit" value="<?php echo attribute_escape(__('Search')); ?>" />
                                 </div>

 }}}

 * logical class names[[BR]]

 * no br element

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5285>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software