[wp-trac] Re: [WordPress Trac] #4251: Small error in get_posts not?

[WordPress Trac]

#4251: Small error in get_posts not?
---------------------------+------------------------------------------------
 Reporter:  momo360modena  |        Owner:  anonymous
     Type:  defect         |       Status:  reopened 
 Priority:  high           |    Milestone:           
Component:  General        |      Version:  2.2      
 Severity:  minor          |   Resolution:           
 Keywords:                 |  
---------------------------+------------------------------------------------
Changes (by momo360modena):

  * status:  closed => reopened
  * resolution:  invalid =>

Comment:

 Not a SQL problem... just  double $query ...

 {{{
         $query ="SELECT DISTINCT * FROM $wpdb->posts " ;
         $query .= ( empty( $category ) ? "" : ", $wpdb->post2cat " );
         $query .= ( empty( $meta_key ) ? "" : ", $wpdb->postmeta " );
         $query .= " WHERE (post_type = 'post' AND post_status = 'publish')
 $exclusions $inclusions ";
         $query .= ( empty( $category ) ? "" : "AND ($wpdb->posts.ID =
 $wpdb->post2cat.post_id AND $wpdb->post2cat.category_id = " . $category.
 ") " );
         $query .= ( empty( $meta_key ) | empty($meta_value)  ? "" : " AND
 ($wpdb->posts.ID = $wpdb->postmeta.post_id AND $wpdb->postmeta.meta_key =
 '$meta_key' AND $wpdb->postmeta.meta_value = '$meta_value' )" );
         $query .= " GROUP BY $wpdb->posts.ID ORDER BY " . $orderby . " " .
 $order . " LIMIT " . $offset . ',' . $numberposts;

         $query  = "SELECT DISTINCT * FROM $wpdb->posts ";
         $query .= empty( $category ) ? '' : ", $wpdb->post2cat ";
         $query .= empty( $meta_key ) ? '' : ", $wpdb->postmeta ";
         $query .= " WHERE 1=1 ";
         $query .= empty( $post_type ) ? '' : "AND post_type = '$post_type'
 ";
         $query .= empty( $post_status ) ? '' : "AND post_status =
 '$post_status' ";
         $query .= "$exclusions $inclusions " ;
 }}}

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4251#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software