[wp-testers] gallery

[Philip M. Hofer (Frumph)]

Yeah I actually found it here:
if ( !$query->is_preview && !$query->is_admin && !$query->is_singular ) {

the !query->is_singular was causing the pre_get_posts to avoid the actual 
array_merge of the custom post types with the standard 'post' and 'page' ;/

Whats odd though is that it worked pre 3.1 beta 2, so i'm guessing something 
in the core changed flagging somewhere ;/ fixed it maybe


What the filter does is add all the custom post types that are found & 
registered and adds it to the loop queries of archive/search/rss etc so that 
they are found for the loops


----- Original Message ----- 
From: <michael at mfields.org>
To: <wp-testers at lists.automattic.com>
Sent: Thursday, December 23, 2010 11:26 PM
Subject: Re: [wp-testers] gallery


> Cool,
> Glad it's all figured out now. I could find the solution on my own. lots
> of stuff going on in that theme :)
> -Mike
>
>> Fixed it by removing the pre_get_posts at the top of the display post ;/
>> i'm going to have to research how to properly do the post types 
>> inclusions
>> with 3.1, something minor probably changed which makes the method I was
>> doing it defunct
>>
>>
>>
>>
>>   remove_filter( 'pre_get_posts' , 'easel_include_custom_post_types' );
>>
>>
>>
>>
>> ----- Original Message -----
>> From: <michael at mfields.org>
>> To: <wp-testers at lists.automattic.com>
>> Sent: Thursday, December 23, 2010 11:06 PM
>> Subject: Re: [wp-testers] gallery
>>
>>
>>>I think that the issue lies in your theme. I just installed it on my test
>>> server and have reproduced the error you are experiencing. Please test
>>> something for me: put the gallery shortcode before the jump so that it
>>> appears in archive views. Does it now display the gallery? It does on my
>>> version. I'm gonna look into easel_display_post() and see if I can find
>>> an
>>> easy fix.
>>>
>>> Best,
>>> -Mike
>>>
>>>> 1. I disabled them all to test.
>>>>
>>>> 2.  Easel, my theme.  wordpress.org/extend/themes/easel
>>>>
>>>> 3. http://frumph.net/stuff/gallery-issue.png
>>>>
>>>> There's a screenshot
>>>>
>>>> http://frumph.net/blog/articles/using-wordpress-gallery/
>>>>
>>>> there's the page
>>>>
>>>>
>>>> I just turned the plugins back on however since its a live site,
>>>> regardless
>>>> either way.  I disabled easel's pre_get_posts modifications filter as
>>>> well,
>>>> still same.
>>>>
>>>>
>>>> Notice in the screenshot it shows a gallery of images available for
>>>> that
>>>> page.
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>> From: <michael at mfields.org>
>>>> To: <wp-testers at lists.automattic.com>
>>>> Sent: Thursday, December 23, 2010 10:38 PM
>>>> Subject: Re: [wp-testers] gallery
>>>>
>>>>
>>>>> And you're absolutely sure that there are images attached to the
>>>>> current
>>>>> post? Sorry for asking again, but I am experiencing no issues with the
>>>>> gallery shortcode in the latest beta.
>>>>>
>>>>> 1. Do you have any plugins installed?
>>>>> 2. Which theme are you using?
>>>>> 3. When you edit the post and click the "Add an Image" button under
>>>>> "Upload/Insert" does the modal media window have a gallery tab? If so,
>>>>> how
>>>>> many attachments are shown there?
>>>>>
>>>>>
>>>>>
>>>>>> yeah $id is proper
>>>>>>
>>>>>>  $_attachments = get_posts( array('post_type' => 'attachment') );
>>>>>>  var_dump($_attachments);
>>>>>>
>>>>>> This is returning empty.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ----- Original Message -----
>>>>>> From: <michael at mfields.org>
>>>>>> To: <wp-testers at lists.automattic.com>
>>>>>> Sent: Thursday, December 23, 2010 10:20 PM
>>>>>> Subject: Re: [wp-testers] gallery
>>>>>>
>>>>>>
>>>>>>> Have you tried var_dump( $id );? I think that it is more likely an
>>>>>>> issue
>>>>>>> with not having a proper $id set. Both include and exclude are only
>>>>>>> used
>>>>>>> if they have a non-empty value. There is a fallback to
>>>>>>> get_children()
>>>>>>> a
>>>>>>> few lines down which doesn't use either.
>>>>>>>
>>>>>>>> i'm thinking it's this part
>>>>>>>>
>>>>>>>>  extract(shortcode_atts(array(
>>>>>>>>   'order'      => 'ASC',
>>>>>>>>   'orderby'    => 'menu_order ID',
>>>>>>>>   'id'         => $post->ID,
>>>>>>>>   'itemtag'    => 'dl',
>>>>>>>>   'icontag'    => 'dt',
>>>>>>>>   'captiontag' => 'dd',
>>>>>>>>   'columns'    => 3,
>>>>>>>>   'size'       => 'thumbnail',
>>>>>>>>   'include'    => '',
>>>>>>>>   'exclude'    => ''
>>>>>>>>  ), $attr));
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>  if ( !empty($include) ) {
>>>>>>>>
>>>>>>>>
>>>>>>>> ^^ its defined as empty to begin with so its not even looking for
>>>>>>>> the
>>>>>>>> attachments so auto-quit
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ----- Original Message -----
>>>>>>>> From: <michael at mfields.org>
>>>>>>>> To: <wp-testers at lists.automattic.com>
>>>>>>>> Sent: Thursday, December 23, 2010 9:57 PM
>>>>>>>> Subject: Re: [wp-testers] gallery
>>>>>>>>
>>>>>>>>
>>>>>>>>> It's working for me. Perhaps it is a ripple effect due to the
>>>>>>>>> errors
>>>>>>>>> you
>>>>>>>>> experienced updating to beta. I've been using this plugin for the
>>>>>>>>> longest
>>>>>>>>> time and it has yet to fail (knock on wood).
>>>>>>>>>
>>>>>>>>> http://wordpress.org/extend/plugins/wordpress-beta-tester/
>>>>>>>>>
>>>>>>>>> If you still have issues, the gallery_shortcode() function is
>>>>>>>>> defined
>>>>>>>>> around line 758 of /wp-includes/media.php You can probably start
>>>>>>>>> dumping
>>>>>>>>> vars there.
>>>>>>>>>
>>>>>>>>> Best wishes,
>>>>>>>>> -Mike
>>>>>>>>>
>>>>>>>>>> Gallery Shortcode doesn't seem to be working on my sites anymore.
>>>>>>>>>>
>>>>>>>>>> [gallery orderby="rand"]
>>>>>>>>>>
>>>>>>>>>> Disabled all plugins and it's still not showing up
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Anything you know of in the core code I can put in to test where
>>>>>>>>>> the
>>>>>>>>>> content is disappearing or not showing up?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> wp-testers mailing list
>>>>>>>>>> wp-testers at lists.automattic.com
>>>>>>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> wp-testers mailing list
>>>>>>>>> wp-testers at lists.automattic.com
>>>>>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> wp-testers mailing list
>>>>>>>> wp-testers at lists.automattic.com
>>>>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> wp-testers mailing list
>>>>>>> wp-testers at lists.automattic.com
>>>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> wp-testers mailing list
>>>>>> wp-testers at lists.automattic.com
>>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> wp-testers mailing list
>>>>> wp-testers at lists.automattic.com
>>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> wp-testers mailing list
>>>> wp-testers at lists.automattic.com
>>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>>
>>>
>>>
>>> _______________________________________________
>>> wp-testers mailing list
>>> wp-testers at lists.automattic.com
>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>
>>
>>
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers at lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>
>
> _______________________________________________
> wp-testers mailing list
> wp-testers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>