From bingorabbit at gmail.com  Fri Apr  3 01:50:30 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Fri Apr  3 01:50:53 2009
Subject: [wp-testers] Editing Plugin files in 2.8
Message-ID: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>

Dear all,

In 2.8, a new feature added to the Plugin editor in which you can edit any
file, not the plugin's file only. A problem can be found, especially with
plugins that has pictures included like akismet that you can edit these
files, which is not logical, why should I edit a picture file in an editor?
:)

So, I think we can remove this by adding some rules for files that can be
editted, or files that don't need to be editted like image files this might
solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
in line 164 where it says:

<?php foreach($plugin_files as $plugin_file) : ?>
> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
> $plugin; ?>"><?php echo $plugin_file ?></a></li>
> <?php endforeach; ?>
>

We can make it:

<?php foreach($plugin_files as $plugin_file) :
> // Get the extension of the file.
>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
> // Extensions to be eliminated
>     if($ext != 'gif' && $ext != 'jpg') : ?>
>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>     <?php endif; ?>
> <?php endforeach; ?>
>

This actually solves it for gif file and jpg one.

Thanks in Advance!

-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From Jesse.Silverstein at xerox.com  Fri Apr  3 02:46:37 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Fri Apr  3 02:47:18 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
Message-ID: <F25F2C8DE17FB546A90DB3CF7746142706192EB0@USA0300MS04.na.xerox.net>

If this change goes in, it makes sense to include a slew of extensions that cannot be edited in a text editor, but might be included in a plugin:
$exlude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav" /* others */);

Then change 
if($ext != 'gif' && $ext != 'jpg') : ?>
to
if ( false !== array_search($ext, $exclude)) continue; ?>
and take out the endif line.

-Jesse Silverstein

-----Original Message-----
From: wp-testers-bounces@lists.automattic.com [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Ibrahim A. Mohamed
Sent: Thursday, April 02, 2009 9:51 PM
To: wp-testers@lists.automattic.com
Subject: [wp-testers] Editing Plugin files in 2.8

Dear all,

In 2.8, a new feature added to the Plugin editor in which you can edit any
file, not the plugin's file only. A problem can be found, especially with
plugins that has pictures included like akismet that you can edit these
files, which is not logical, why should I edit a picture file in an editor?
:)

So, I think we can remove this by adding some rules for files that can be
editted, or files that don't need to be editted like image files this might
solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
in line 164 where it says:

<?php foreach($plugin_files as $plugin_file) : ?>
> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
> $plugin; ?>"><?php echo $plugin_file ?></a></li>
> <?php endforeach; ?>
>

We can make it:

<?php foreach($plugin_files as $plugin_file) :
> // Get the extension of the file.
>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
> // Extensions to be eliminated
>     if($ext != 'gif' && $ext != 'jpg') : ?>
>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>     <?php endif; ?>
> <?php endforeach; ?>
>

This actually solves it for gif file and jpg one.

Thanks in Advance!

-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.11.35/2034 - Release Date: 04/02/09 06:09:00
From peter.westwood at ftwr.co.uk  Fri Apr  3 06:01:40 2009
From: peter.westwood at ftwr.co.uk (Peter Westwood)
Date: Fri Apr  3 06:01:58 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <F25F2C8DE17FB546A90DB3CF7746142706192EB0@USA0300MS04.na.xerox.net>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<F25F2C8DE17FB546A90DB3CF7746142706192EB0@USA0300MS04.na.xerox.net>
Message-ID: <B44B86DE-DBDE-45CE-BF5C-461999087A78@ftwr.co.uk>


On 3 Apr 2009, at 03:46, Silverstein, Jesse wrote:

> If this change goes in, it makes sense to include a slew of  
> extensions that cannot be edited in a text editor, but might be  
> included in a plugin:
> $exlude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3",  
> "wav" /* others */);

It may make more sense to whitelist rather than blacklist here.

It is going to be easier to define a set of safe file extensions than  
try and list all the unsafe ones.

Could someone raise a trac ticket (and write a patch if so inclined ;-))

westi
-- 
Peter Westwood
http://blog.ftwr.co.uk | http://westi.wordpress.com
C53C F8FC 8796 8508 88D6 C950 54F4 5DCD A834 01C5

From mike at mikevanwinkle.com  Fri Apr  3 11:35:59 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Fri Apr  3 11:49:36 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <F25F2C8DE17FB546A90DB3CF7746142706192EB0@USA0300MS04.na.xerox.net>
Message-ID: <C5FB5ECF.7652%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From mike at mikevanwinkle.com  Fri Apr  3 11:35:59 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Fri Apr  3 11:49:40 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
Message-ID: <C5FB5ECF.7653%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From mike at mikevanwinkle.com  Fri Apr  3 11:54:44 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Fri Apr  3 12:05:02 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB5ECF.7653%mike@mikevanwinkle.com>
Message-ID: <C5FB6334.766D%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From mike at mikevanwinkle.com  Fri Apr  3 11:54:44 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Fri Apr  3 12:05:04 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB5ECF.7652%mike@mikevanwinkle.com>
Message-ID: <C5FB6334.766E%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From mike at mikevanwinkle.com  Fri Apr  3 11:36:01 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Fri Apr  3 12:12:51 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <B44B86DE-DBDE-45CE-BF5C-461999087A78@ftwr.co.uk>
Message-ID: <C5FB5ED1.7659%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From bingorabbit at gmail.com  Fri Apr  3 12:24:23 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Fri Apr  3 12:24:40 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
Message-ID: <e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>

I love Peter's idea on Silverstein solution, we can do it this way:
$include = array("php", "txt", "css", "html");
instead of
$exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav" /*
others */);

and change: if( false !== array_search($ext, $exclude)) continue; ?>

to if( false === array_search($ext, $include)) continue; ?>

Thanks in Advance!

On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> Dear all,
>
> In 2.8, a new feature added to the Plugin editor in which you can edit any
> file, not the plugin's file only. A problem can be found, especially with
> plugins that has pictures included like akismet that you can edit these
> files, which is not logical, why should I edit a picture file in an editor?
> :)
>
> So, I think we can remove this by adding some rules for files that can be
> editted, or files that don't need to be editted like image files this might
> solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
> in line 164 where it says:
>
> <?php foreach($plugin_files as $plugin_file) : ?>
>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>> <?php endforeach; ?>
>>
>
> We can make it:
>
> <?php foreach($plugin_files as $plugin_file) :
>> // Get the extension of the file.
>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>> // Extensions to be eliminated
>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>     <?php endif; ?>
>> <?php endforeach; ?>
>>
>
> This actually solves it for gif file and jpg one.
>
> Thanks in Advance!
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From Jesse.Silverstein at xerox.com  Fri Apr  3 17:31:26 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Sat Apr  4 00:24:00 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <B44B86DE-DBDE-45CE-BF5C-461999087A78@ftwr.co.uk>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com><F25F2C8DE17FB546A90DB3CF7746142706192EB0@USA0300MS04.na.xerox.net>
	<B44B86DE-DBDE-45CE-BF5C-461999087A78@ftwr.co.uk>
Message-ID: <F25F2C8DE17FB546A90DB3CF77461427061E85C6@USA0300MS04.na.xerox.net>

> Could someone raise a trac ticket (and write a patch if so inclined
;-))
http://core.trac.wordpress.org/ticket/9452

I don't know if I did any of that right. T'was my first interaction with
Trac. Hopefully I didn't screw it up too badly. :)

-Jesse Silverstein

-----Original Message-----
From: wp-testers-bounces@lists.automattic.com
[mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Peter
Westwood
Sent: Friday, April 03, 2009 2:02 AM
To: wp-testers@lists.automattic.com
Subject: Re: [wp-testers] Editing Plugin files in 2.8


On 3 Apr 2009, at 03:46, Silverstein, Jesse wrote:

> If this change goes in, it makes sense to include a slew of  
> extensions that cannot be edited in a text editor, but might be  
> included in a plugin:
> $exlude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3",  
> "wav" /* others */);

It may make more sense to whitelist rather than blacklist here.

It is going to be easier to define a set of safe file extensions than  
try and list all the unsafe ones.

Could someone raise a trac ticket (and write a patch if so inclined ;-))

westi
-- 
Peter Westwood
http://blog.ftwr.co.uk | http://westi.wordpress.com
C53C F8FC 8796 8508 88D6 C950 54F4 5DCD A834 01C5

_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.11.40/2039 - Release Date:
04/03/09 06:19:00
From mike at mikevanwinkle.com  Fri Apr  3 12:14:50 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Sat Apr  4 02:38:37 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB6334.766E%mike@mikevanwinkle.com>
Message-ID: <C5FB67EA.76FD%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From bingorabbit at gmail.com  Sat Apr  4 01:24:55 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 02:55:32 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030700g5742f317q3fb4694894970@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
	<e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>
	<e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com>
	<e05a63ba0904030642nfa4522r44e644d48c17536b@mail.gmail.com>
	<e05a63ba0904030700g5742f317q3fb4694894970@mail.gmail.com>
Message-ID: <e05a63ba0904031824i6293effcs4cc56f3b60f16e93@mail.gmail.com>

In file wp-admin/plugin-editor.php, on line 178 I added:

    <?php
>         // Get the extension of the file.
>         $ext = substr($file, strpos($file, '.') + 1);
>         // List of included files
>         $include = array("php", "html", "css", "txt");
>         if( false === array_search($ext, $include) ) :
>             echo ("You can't edit this file.");
>             break;
>            endif;
>     ?>
>

Patch can be found here:
http://core.trac.wordpress.org/ticket/9452#comment:11, line 181 is just for
testing purposes.

Thanks in Advance!
On Fri, Apr 3, 2009 at 4:00 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> I tested it on 2.7.1 and it's ok, we can use the same implementation in
> this..
>
>
> On Fri, Apr 3, 2009 at 3:42 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> Sorry, that didn't work..looking for better solutions :)
>>
>>
>> On Fri, Apr 3, 2009 at 3:39 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com
>> > wrote:
>>
>>> We can do so by adding:
>>>
>>> <?php if( false !== array_search($ext, $include) )
>>>>         wp_die("File is not editable."); ?>
>>>>
>>>
>>> on line 175 on the same file, my solutions shouldn't be the best for
>>> sure, as I think it should be in the same function that validates the plugin
>>> file if exists in wp-admin/includes/plugin.php .
>>>
>>> Thanks in Advance!
>>>
>>> On Fri, Apr 3, 2009 at 3:20 PM, Ibrahim A. Mohamed <
>>> bingorabbit@gmail.com> wrote:
>>>
>>>> We should also consider the $file parameter sent from the URL, so when I
>>>> for example type in the address bar:
>>>> http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet
>>>> .*gif*
>>>> It works, we need to add a rule that if it was sent in URL, Edit can't
>>>> happen or something.
>>>>
>>>>
>>>> On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <
>>>> bingorabbit@gmail.com> wrote:
>>>>
>>>>> I love Peter's idea on Silverstein solution, we can do it this way:
>>>>> $include = array("php", "txt", "css", "html");
>>>>> instead of
>>>>> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav"
>>>>> /* others */);
>>>>>
>>>>> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>>>>>
>>>>> to if( false === array_search($ext, $include)) continue; ?>
>>>>>
>>>>> Thanks in Advance!
>>>>>
>>>>>
>>>>> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <
>>>>> bingorabbit@gmail.com> wrote:
>>>>>
>>>>>> Dear all,
>>>>>>
>>>>>> In 2.8, a new feature added to the Plugin editor in which you can edit
>>>>>> any file, not the plugin's file only. A problem can be found, especially
>>>>>> with plugins that has pictures included like akismet that you can edit these
>>>>>> files, which is not logical, why should I edit a picture file in an editor?
>>>>>> :)
>>>>>>
>>>>>> So, I think we can remove this by adding some rules for files that can
>>>>>> be editted, or files that don't need to be editted like image files this
>>>>>> might solve the problem. For example, for Akismet, in
>>>>>> wp-admin/plugin-editor.php in line 164 where it says:
>>>>>>
>>>>>> <?php foreach($plugin_files as $plugin_file) : ?>
>>>>>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>>>>>>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>>>>>>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>>> <?php endforeach; ?>
>>>>>>>
>>>>>>
>>>>>> We can make it:
>>>>>>
>>>>>> <?php foreach($plugin_files as $plugin_file) :
>>>>>>> // Get the extension of the file.
>>>>>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>>>>>> // Extensions to be eliminated
>>>>>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>>>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' :
>>>>>>> ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file;
>>>>>>> ?>&plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>>>     <?php endif; ?>
>>>>>>> <?php endforeach; ?>
>>>>>>>
>>>>>>
>>>>>> This actually solves it for gif file and jpg one.
>>>>>>
>>>>>> Thanks in Advance!
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Ibrahim Abdel Fattah Mohamed
>>>>>> Web Developer
>>>>>> Twitter: @bingorabbit
>>>>>> e-mail: bingorabbit@gmail.com
>>>>>> Personal bLOG: http://bingorabbit.com/
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Ibrahim Abdel Fattah Mohamed
>>>>> Web Developer
>>>>> Twitter: @bingorabbit
>>>>> e-mail: bingorabbit@gmail.com
>>>>> Personal bLOG: http://bingorabbit.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Ibrahim Abdel Fattah Mohamed
>>>> Web Developer
>>>> Twitter: @bingorabbit
>>>> e-mail: bingorabbit@gmail.com
>>>> Personal bLOG: http://bingorabbit.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Ibrahim Abdel Fattah Mohamed
>>> Web Developer
>>> Twitter: @bingorabbit
>>> e-mail: bingorabbit@gmail.com
>>> Personal bLOG: http://bingorabbit.com/
>>>
>>
>>
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From Jesse.Silverstein at xerox.com  Sat Apr  4 03:00:41 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Sat Apr  4 03:02:09 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904031824i6293effcs4cc56f3b60f16e93@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com><e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com><e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com><e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com><e05a63ba0904030642nfa4522r44e644d48c17536b@mail.gmail.com><e05a63ba0904030700g5742f317q3fb4694894970@mail.gmail.com>
	<e05a63ba0904031824i6293effcs4cc56f3b60f16e93@mail.gmail.com>
Message-ID: <F25F2C8DE17FB546A90DB3CF77461427061E8A55@USA0300MS04.na.xerox.net>

Not sure if there is a delay on my receiving this email or not, but I've added a patch to your patch :)

See http://core.trac.wordpress.org/attachment/ticket/9452/9452.1.patch

-Jesse Silverstein

-----Original Message-----
From: wp-testers-bounces@lists.automattic.com [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Ibrahim A. Mohamed
Sent: Friday, April 03, 2009 9:25 PM
To: wp-testers@lists.automattic.com
Subject: [wp-testers] Re: Editing Plugin files in 2.8

In file wp-admin/plugin-editor.php, on line 178 I added:

    <?php
>         // Get the extension of the file.
>         $ext = substr($file, strpos($file, '.') + 1);
>         // List of included files
>         $include = array("php", "html", "css", "txt");
>         if( false === array_search($ext, $include) ) :
>             echo ("You can't edit this file.");
>             break;
>            endif;
>     ?>
>

Patch can be found here:
http://core.trac.wordpress.org/ticket/9452#comment:11, line 181 is just for
testing purposes.

Thanks in Advance!
On Fri, Apr 3, 2009 at 4:00 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> I tested it on 2.7.1 and it's ok, we can use the same implementation in
> this..
>
>
> On Fri, Apr 3, 2009 at 3:42 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> Sorry, that didn't work..looking for better solutions :)
>>
>>
>> On Fri, Apr 3, 2009 at 3:39 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com
>> > wrote:
>>
>>> We can do so by adding:
>>>
>>> <?php if( false !== array_search($ext, $include) )
>>>>         wp_die("File is not editable."); ?>
>>>>
>>>
>>> on line 175 on the same file, my solutions shouldn't be the best for
>>> sure, as I think it should be in the same function that validates the plugin
>>> file if exists in wp-admin/includes/plugin.php .
>>>
>>> Thanks in Advance!
>>>
>>> On Fri, Apr 3, 2009 at 3:20 PM, Ibrahim A. Mohamed <
>>> bingorabbit@gmail.com> wrote:
>>>
>>>> We should also consider the $file parameter sent from the URL, so when I
>>>> for example type in the address bar:
>>>> http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet
>>>> .*gif*
>>>> It works, we need to add a rule that if it was sent in URL, Edit can't
>>>> happen or something.
>>>>
>>>>
>>>> On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <
>>>> bingorabbit@gmail.com> wrote:
>>>>
>>>>> I love Peter's idea on Silverstein solution, we can do it this way:
>>>>> $include = array("php", "txt", "css", "html");
>>>>> instead of
>>>>> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav"
>>>>> /* others */);
>>>>>
>>>>> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>>>>>
>>>>> to if( false === array_search($ext, $include)) continue; ?>
>>>>>
>>>>> Thanks in Advance!
>>>>>
>>>>>
>>>>> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <
>>>>> bingorabbit@gmail.com> wrote:
>>>>>
>>>>>> Dear all,
>>>>>>
>>>>>> In 2.8, a new feature added to the Plugin editor in which you can edit
>>>>>> any file, not the plugin's file only. A problem can be found, especially
>>>>>> with plugins that has pictures included like akismet that you can edit these
>>>>>> files, which is not logical, why should I edit a picture file in an editor?
>>>>>> :)
>>>>>>
>>>>>> So, I think we can remove this by adding some rules for files that can
>>>>>> be editted, or files that don't need to be editted like image files this
>>>>>> might solve the problem. For example, for Akismet, in
>>>>>> wp-admin/plugin-editor.php in line 164 where it says:
>>>>>>
>>>>>> <?php foreach($plugin_files as $plugin_file) : ?>
>>>>>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>>>>>>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>>>>>>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>>> <?php endforeach; ?>
>>>>>>>
>>>>>>
>>>>>> We can make it:
>>>>>>
>>>>>> <?php foreach($plugin_files as $plugin_file) :
>>>>>>> // Get the extension of the file.
>>>>>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>>>>>> // Extensions to be eliminated
>>>>>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>>>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' :
>>>>>>> ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file;
>>>>>>> ?>&plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>>>     <?php endif; ?>
>>>>>>> <?php endforeach; ?>
>>>>>>>
>>>>>>
>>>>>> This actually solves it for gif file and jpg one.
>>>>>>
>>>>>> Thanks in Advance!
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Ibrahim Abdel Fattah Mohamed
>>>>>> Web Developer
>>>>>> Twitter: @bingorabbit
>>>>>> e-mail: bingorabbit@gmail.com
>>>>>> Personal bLOG: http://bingorabbit.com/
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Ibrahim Abdel Fattah Mohamed
>>>>> Web Developer
>>>>> Twitter: @bingorabbit
>>>>> e-mail: bingorabbit@gmail.com
>>>>> Personal bLOG: http://bingorabbit.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Ibrahim Abdel Fattah Mohamed
>>>> Web Developer
>>>> Twitter: @bingorabbit
>>>> e-mail: bingorabbit@gmail.com
>>>> Personal bLOG: http://bingorabbit.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Ibrahim Abdel Fattah Mohamed
>>> Web Developer
>>> Twitter: @bingorabbit
>>> e-mail: bingorabbit@gmail.com
>>> Personal bLOG: http://bingorabbit.com/
>>>
>>
>>
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.11.40/2039 - Release Date: 04/03/09 17:54:00
From mike at mikevanwinkle.com  Fri Apr  3 12:14:50 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Sat Apr  4 03:16:29 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB5ED1.7659%mike@mikevanwinkle.com>
Message-ID: <C5FB67EA.76FC%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From bingorabbit at gmail.com  Fri Apr  3 14:00:27 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 03:38:24 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030642nfa4522r44e644d48c17536b@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
	<e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>
	<e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com>
	<e05a63ba0904030642nfa4522r44e644d48c17536b@mail.gmail.com>
Message-ID: <e05a63ba0904030700g5742f317q3fb4694894970@mail.gmail.com>

I tested it on 2.7.1 and it's ok, we can use the same implementation in
this..

On Fri, Apr 3, 2009 at 3:42 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> Sorry, that didn't work..looking for better solutions :)
>
>
> On Fri, Apr 3, 2009 at 3:39 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> We can do so by adding:
>>
>> <?php if( false !== array_search($ext, $include) )
>>>         wp_die("File is not editable."); ?>
>>>
>>
>> on line 175 on the same file, my solutions shouldn't be the best for sure,
>> as I think it should be in the same function that validates the plugin file
>> if exists in wp-admin/includes/plugin.php .
>>
>> Thanks in Advance!
>>
>> On Fri, Apr 3, 2009 at 3:20 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com
>> > wrote:
>>
>>> We should also consider the $file parameter sent from the URL, so when I
>>> for example type in the address bar:
>>> http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet
>>> .*gif*
>>> It works, we need to add a rule that if it was sent in URL, Edit can't
>>> happen or something.
>>>
>>>
>>> On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <
>>> bingorabbit@gmail.com> wrote:
>>>
>>>> I love Peter's idea on Silverstein solution, we can do it this way:
>>>> $include = array("php", "txt", "css", "html");
>>>> instead of
>>>> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav"
>>>> /* others */);
>>>>
>>>> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>>>>
>>>> to if( false === array_search($ext, $include)) continue; ?>
>>>>
>>>> Thanks in Advance!
>>>>
>>>>
>>>> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <
>>>> bingorabbit@gmail.com> wrote:
>>>>
>>>>> Dear all,
>>>>>
>>>>> In 2.8, a new feature added to the Plugin editor in which you can edit
>>>>> any file, not the plugin's file only. A problem can be found, especially
>>>>> with plugins that has pictures included like akismet that you can edit these
>>>>> files, which is not logical, why should I edit a picture file in an editor?
>>>>> :)
>>>>>
>>>>> So, I think we can remove this by adding some rules for files that can
>>>>> be editted, or files that don't need to be editted like image files this
>>>>> might solve the problem. For example, for Akismet, in
>>>>> wp-admin/plugin-editor.php in line 164 where it says:
>>>>>
>>>>> <?php foreach($plugin_files as $plugin_file) : ?>
>>>>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>>>>>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>>>>>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>> <?php endforeach; ?>
>>>>>>
>>>>>
>>>>> We can make it:
>>>>>
>>>>> <?php foreach($plugin_files as $plugin_file) :
>>>>>> // Get the extension of the file.
>>>>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>>>>> // Extensions to be eliminated
>>>>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' :
>>>>>> ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file;
>>>>>> ?>&plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>>     <?php endif; ?>
>>>>>> <?php endforeach; ?>
>>>>>>
>>>>>
>>>>> This actually solves it for gif file and jpg one.
>>>>>
>>>>> Thanks in Advance!
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Ibrahim Abdel Fattah Mohamed
>>>>> Web Developer
>>>>> Twitter: @bingorabbit
>>>>> e-mail: bingorabbit@gmail.com
>>>>> Personal bLOG: http://bingorabbit.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Ibrahim Abdel Fattah Mohamed
>>>> Web Developer
>>>> Twitter: @bingorabbit
>>>> e-mail: bingorabbit@gmail.com
>>>> Personal bLOG: http://bingorabbit.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Ibrahim Abdel Fattah Mohamed
>>> Web Developer
>>> Twitter: @bingorabbit
>>> e-mail: bingorabbit@gmail.com
>>> Personal bLOG: http://bingorabbit.com/
>>>
>>
>>
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From bingorabbit at gmail.com  Fri Apr  3 13:20:02 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 03:49:39 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
Message-ID: <e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>

We should also consider the $file parameter sent from the URL, so when I for
example type in the address bar:
http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet.*
gif*
It works, we need to add a rule that if it was sent in URL, Edit can't
happen or something.

On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> I love Peter's idea on Silverstein solution, we can do it this way:
> $include = array("php", "txt", "css", "html");
> instead of
> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav" /*
> others */);
>
> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>
> to if( false === array_search($ext, $include)) continue; ?>
>
> Thanks in Advance!
>
>
> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> Dear all,
>>
>> In 2.8, a new feature added to the Plugin editor in which you can edit any
>> file, not the plugin's file only. A problem can be found, especially with
>> plugins that has pictures included like akismet that you can edit these
>> files, which is not logical, why should I edit a picture file in an editor?
>> :)
>>
>> So, I think we can remove this by adding some rules for files that can be
>> editted, or files that don't need to be editted like image files this might
>> solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
>> in line 164 where it says:
>>
>> <?php foreach($plugin_files as $plugin_file) : ?>
>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>> <?php endforeach; ?>
>>>
>>
>> We can make it:
>>
>> <?php foreach($plugin_files as $plugin_file) :
>>> // Get the extension of the file.
>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>> // Extensions to be eliminated
>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>     <?php endif; ?>
>>> <?php endforeach; ?>
>>>
>>
>> This actually solves it for gif file and jpg one.
>>
>> Thanks in Advance!
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From bingorabbit at gmail.com  Fri Apr  3 13:39:27 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 05:05:49 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
	<e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>
Message-ID: <e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com>

We can do so by adding:

<?php if( false !== array_search($ext, $include) )
>         wp_die("File is not editable."); ?>
>

on line 175 on the same file, my solutions shouldn't be the best for sure,
as I think it should be in the same function that validates the plugin file
if exists in wp-admin/includes/plugin.php .

Thanks in Advance!
On Fri, Apr 3, 2009 at 3:20 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> We should also consider the $file parameter sent from the URL, so when I
> for example type in the address bar:
> http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet.*
> gif*
> It works, we need to add a rule that if it was sent in URL, Edit can't
> happen or something.
>
>
> On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> I love Peter's idea on Silverstein solution, we can do it this way:
>> $include = array("php", "txt", "css", "html");
>> instead of
>> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav" /*
>> others */);
>>
>> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>>
>> to if( false === array_search($ext, $include)) continue; ?>
>>
>> Thanks in Advance!
>>
>>
>> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <bingorabbit@gmail.com
>> > wrote:
>>
>>> Dear all,
>>>
>>> In 2.8, a new feature added to the Plugin editor in which you can edit
>>> any file, not the plugin's file only. A problem can be found, especially
>>> with plugins that has pictures included like akismet that you can edit these
>>> files, which is not logical, why should I edit a picture file in an editor?
>>> :)
>>>
>>> So, I think we can remove this by adding some rules for files that can be
>>> editted, or files that don't need to be editted like image files this might
>>> solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
>>> in line 164 where it says:
>>>
>>> <?php foreach($plugin_files as $plugin_file) : ?>
>>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>>>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>>>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>> <?php endforeach; ?>
>>>>
>>>
>>> We can make it:
>>>
>>> <?php foreach($plugin_files as $plugin_file) :
>>>> // Get the extension of the file.
>>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>>> // Extensions to be eliminated
>>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>>>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>>>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>     <?php endif; ?>
>>>> <?php endforeach; ?>
>>>>
>>>
>>> This actually solves it for gif file and jpg one.
>>>
>>> Thanks in Advance!
>>>
>>> --
>>> Regards,
>>> Ibrahim Abdel Fattah Mohamed
>>> Web Developer
>>> Twitter: @bingorabbit
>>> e-mail: bingorabbit@gmail.com
>>> Personal bLOG: http://bingorabbit.com/
>>>
>>
>>
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From Jesse.Silverstein at xerox.com  Fri Apr  3 13:45:09 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Sat Apr  4 05:36:08 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
Message-ID: <F25F2C8DE17FB546A90DB3CF77461427061930D3@USA0300MS04.na.xerox.net>

I've seen a number of plugins that have either .inc or .include files in their sources, so we may want to ... include the various  ".include"s in our $include...


-----Original Message-----
From: wp-testers-bounces@lists.automattic.com [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Ibrahim A. Mohamed
Sent: Friday, April 03, 2009 8:24 AM
To: wp-testers@lists.automattic.com
Subject: [wp-testers] Re: Editing Plugin files in 2.8

I love Peter's idea on Silverstein solution, we can do it this way:
$include = array("php", "txt", "css", "html");
instead of
$exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav" /*
others */);

and change: if( false !== array_search($ext, $exclude)) continue; ?>

to if( false === array_search($ext, $include)) continue; ?>

Thanks in Advance!

On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> Dear all,
>
> In 2.8, a new feature added to the Plugin editor in which you can edit any
> file, not the plugin's file only. A problem can be found, especially with
> plugins that has pictures included like akismet that you can edit these
> files, which is not logical, why should I edit a picture file in an editor?
> :)
>
> So, I think we can remove this by adding some rules for files that can be
> editted, or files that don't need to be editted like image files this might
> solve the problem. For example, for Akismet, in wp-admin/plugin-editor.php
> in line 164 where it says:
>
> <?php foreach($plugin_files as $plugin_file) : ?>
>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>> <?php endforeach; ?>
>>
>
> We can make it:
>
> <?php foreach($plugin_files as $plugin_file) :
>> // Get the extension of the file.
>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>> // Extensions to be eliminated
>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' : '';
>> ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php
>> echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>     <?php endif; ?>
>> <?php endforeach; ?>
>>
>
> This actually solves it for gif file and jpg one.
>
> Thanks in Advance!
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.11.40/2039 - Release Date: 04/03/09 06:19:00
From bingorabbit at gmail.com  Fri Apr  3 13:42:06 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 05:59:18 2009
Subject: [wp-testers] Re: Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com>
References: <e05a63ba0904021850k48bfd551i44816847e8ca9632@mail.gmail.com>
	<e05a63ba0904030524kfa205e3i42b14d4ad058eb97@mail.gmail.com>
	<e05a63ba0904030620s1b8c4497nc2683b0c9c71d593@mail.gmail.com>
	<e05a63ba0904030639w19589b3eq97dfab7bf6f144f3@mail.gmail.com>
Message-ID: <e05a63ba0904030642nfa4522r44e644d48c17536b@mail.gmail.com>

Sorry, that didn't work..looking for better solutions :)

On Fri, Apr 3, 2009 at 3:39 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> We can do so by adding:
>
> <?php if( false !== array_search($ext, $include) )
>>         wp_die("File is not editable."); ?>
>>
>
> on line 175 on the same file, my solutions shouldn't be the best for sure,
> as I think it should be in the same function that validates the plugin file
> if exists in wp-admin/includes/plugin.php .
>
> Thanks in Advance!
>
> On Fri, Apr 3, 2009 at 3:20 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:
>
>> We should also consider the $file parameter sent from the URL, so when I
>> for example type in the address bar:
>> http://path.to/wordpress/wp-admin/plugin-editor.php?file=akismet/akismet.
>> *gif*
>> It works, we need to add a rule that if it was sent in URL, Edit can't
>> happen or something.
>>
>>
>> On Fri, Apr 3, 2009 at 2:24 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com
>> > wrote:
>>
>>> I love Peter's idea on Silverstein solution, we can do it this way:
>>> $include = array("php", "txt", "css", "html");
>>> instead of
>>> $exclude = array("gif", "jpg", "png", "bmp", "swf", "flv", "mp3", "wav"
>>> /* others */);
>>>
>>> and change: if( false !== array_search($ext, $exclude)) continue; ?>
>>>
>>> to if( false === array_search($ext, $include)) continue; ?>
>>>
>>> Thanks in Advance!
>>>
>>>
>>> On Fri, Apr 3, 2009 at 3:50 AM, Ibrahim A. Mohamed <
>>> bingorabbit@gmail.com> wrote:
>>>
>>>> Dear all,
>>>>
>>>> In 2.8, a new feature added to the Plugin editor in which you can edit
>>>> any file, not the plugin's file only. A problem can be found, especially
>>>> with plugins that has pictures included like akismet that you can edit these
>>>> files, which is not logical, why should I edit a picture file in an editor?
>>>> :)
>>>>
>>>> So, I think we can remove this by adding some rules for files that can
>>>> be editted, or files that don't need to be editted like image files this
>>>> might solve the problem. For example, for Akismet, in
>>>> wp-admin/plugin-editor.php in line 164 where it says:
>>>>
>>>> <?php foreach($plugin_files as $plugin_file) : ?>
>>>>> <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a
>>>>> href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo
>>>>> $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>> <?php endforeach; ?>
>>>>>
>>>>
>>>> We can make it:
>>>>
>>>> <?php foreach($plugin_files as $plugin_file) :
>>>>> // Get the extension of the file.
>>>>>     $ext = substr($plugin_file, strpos($plugin_file, '.') + 1);
>>>>> // Extensions to be eliminated
>>>>>     if($ext != 'gif' && $ext != 'jpg') : ?>
>>>>>         <li<?php echo $file == $plugin_file ? ' class="highlight"' :
>>>>> ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file;
>>>>> ?>&plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
>>>>>     <?php endif; ?>
>>>>> <?php endforeach; ?>
>>>>>
>>>>
>>>> This actually solves it for gif file and jpg one.
>>>>
>>>> Thanks in Advance!
>>>>
>>>> --
>>>> Regards,
>>>> Ibrahim Abdel Fattah Mohamed
>>>> Web Developer
>>>> Twitter: @bingorabbit
>>>> e-mail: bingorabbit@gmail.com
>>>> Personal bLOG: http://bingorabbit.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Ibrahim Abdel Fattah Mohamed
>>> Web Developer
>>> Twitter: @bingorabbit
>>> e-mail: bingorabbit@gmail.com
>>> Personal bLOG: http://bingorabbit.com/
>>>
>>
>>
>>
>> --
>> Regards,
>> Ibrahim Abdel Fattah Mohamed
>> Web Developer
>> Twitter: @bingorabbit
>> e-mail: bingorabbit@gmail.com
>> Personal bLOG: http://bingorabbit.com/
>>
>
>
>
> --
> Regards,
> Ibrahim Abdel Fattah Mohamed
> Web Developer
> Twitter: @bingorabbit
> e-mail: bingorabbit@gmail.com
> Personal bLOG: http://bingorabbit.com/
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From mike at mikevanwinkle.com  Fri Apr  3 12:14:50 2009
From: mike at mikevanwinkle.com (Van Winkle Enterprises)
Date: Sat Apr  4 07:29:58 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB6334.766D%mike@mikevanwinkle.com>
Message-ID: <C5FB67EA.76FE%mike@mikevanwinkle.com>

I am traveling today and will be away from my desk. If you have an emergency
please call 914-591-7230. I will respond to your email as quickly as
possible.

Sincerely, 

Mike


From tklingenberg at lastflood.net  Sat Apr  4 10:06:38 2009
From: tklingenberg at lastflood.net (Tom Klingenberg)
Date: Sat Apr  4 10:06:34 2009
Subject: [wp-testers] Bug in WP 2.7.1
In-Reply-To: <787a77ff0903021128r349ffc67sbb8f1bb86c079a64@mail.gmail.com>
References: <787a77ff0903021128r349ffc67sbb8f1bb86c079a64@mail.gmail.com>
Message-ID: <op.uruw1cihsed26o@monolith.gonzales>

Please report Bugs here:

http://core.trac.wordpress.org/

By creating a new ticket.

If you have created the new ticket, please report the ticket number here.  
I guess I understand what your problem is and I can provide a patch in  
trac later on.

On Mon, 02 Mar 2009 20:28:40 +0100, ??????? ??????? <dumaxa@gmail.com>  
wrote:

> Greetings to creators!
>
> I've found a problem in wordpress 2.7.1.
> If you try to change the theme of decoration of the site without removing
> widgets in advance, than the widgets look as if they are already added  
> into
> the theme, and that's why it's impossible to add them into the new theme.
>
> I hope the problem would be removed in the next process of creating
> wordpress.
>
> Yours faithfully, Dmitriy Sholud'ko.
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
From tklingenberg at lastflood.net  Sat Apr  4 10:08:36 2009
From: tklingenberg at lastflood.net (Tom Klingenberg)
Date: Sat Apr  4 10:08:14 2009
Subject: [wp-testers] Error when upgrading from 2.7.1 to nightly
In-Reply-To: <161617690903031123g62cbcdb6id7120c00ca9373a8@mail.gmail.com>
References: <161617690903031123g62cbcdb6id7120c00ca9373a8@mail.gmail.com>
Message-ID: <op.uruw4my4sed26o@monolith.gonzales>

A dependency was missing. I do not have that problem in nightly since that  
date. There ain't no declaration nor use of type WordPress_Module any  
longer. You shouldn't encounter this problem with the current nightly.

On Tue, 03 Mar 2009 20:23:50 +0100, Otto <otto@ottodestruct.com> wrote:

> Got this error. Can't explain it. I check, and the files were correct
> on the server, and the _weak_escape function was indeed in the
> wp-db.php file.
>
> Fatal error: Call to undefined method WordPress_Module::_weak_escape()
> in /home/.../html/blog/wp-includes/wp-db.php on line 473
>
> Ideas?
>
> -Otto
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers


Mit freundlichen Gr??en

Tom Klingenberg

-- 
Tom Klingenberg
Gesch?ftsf?hrer

lastflood GmbH
Leibnizstr. 24
55118 Mainz
Deutschland

Fon: +49 6131 672250
Fax: +49 6131 604232
Web: www.lastflood.com

Register: HRB 40173 am Amtsgericht Mainz; Gesch?ftsf?hrung: Tom Klingenberg
From tklingenberg at lastflood.net  Sat Apr  4 10:18:57 2009
From: tklingenberg at lastflood.net (Tom Klingenberg)
Date: Sat Apr  4 10:18:38 2009
Subject: [wp-testers] User administration - email
In-Reply-To: <5686e4180903120700m257d1490ubb6bffeda9eb2275@mail.gmail.com>
References: <5686e4180903120700m257d1490ubb6bffeda9eb2275@mail.gmail.com>
Message-ID: <op.uruxlvsosed26o@monolith.gonzales>

please report bugs in wordpress trac:

http://core.trac.wordpress.org/

-- tom

On Thu, 12 Mar 2009 15:00:49 +0100, Drummond Field <drummond@field.ac>  
wrote:

> Hi,
> First time bug report. I have been using the SVN version of WP for a  
> while
> now, and this is the first time I have found what I think to be a bug.
> Currently using version : 10773.
>
> I have found that I can no longer modify a users email address in the  
> users
> admin section. If I try and change the address, on save the field comes  
> back
> as blank, I have tried repeated times to save an email address in the now
> blank field - but everytime I get the successful, but no email is saved.
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
From scribu at gmail.com  Sat Apr  4 11:58:49 2009
From: scribu at gmail.com (scribu)
Date: Sat Apr  4 11:59:06 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <C5FB67EA.76FE%mike@mikevanwinkle.com>
References: <C5FB6334.766D%mike@mikevanwinkle.com>
	<C5FB67EA.76FE%mike@mikevanwinkle.com>
Message-ID: <349fe48b0904040458l6b124592v8a19bdf193d911f0@mail.gmail.com>

I think a filter should also be added, so that plugins can add or remove
file extensions as they please.

On Fri, Apr 3, 2009 at 3:14 PM, Van Winkle Enterprises <
mike@mikevanwinkle.com> wrote:

> I am traveling today and will be away from my desk. If you have an
> emergency
> please call 914-591-7230. I will respond to your email as quickly as
> possible.
>
> Sincerely,
>
> Mike
>
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>



-- 
http://scribu.net
From wp-hackers at striderweb.com  Sat Apr  4 14:21:15 2009
From: wp-hackers at striderweb.com (Stephen Rider)
Date: Sat Apr  4 14:21:45 2009
Subject: [wp-testers] Bug in WP 2.7.1
In-Reply-To: <op.uruw1cihsed26o@monolith.gonzales>
References: <787a77ff0903021128r349ffc67sbb8f1bb86c079a64@mail.gmail.com>
	<op.uruw1cihsed26o@monolith.gonzales>
Message-ID: <BDA21DD7-CC35-416D-817B-A7F2960309F9@striderweb.com>

I'm pretty sure that one has been reported before.  It's been brought  
upa  whole bunch of times.

On Apr 4, 2009, at 5:06 AM, Tom Klingenberg wrote:

> Please report Bugs here:
>
> http://core.trac.wordpress.org/
>
> By creating a new ticket.
>
> If you have created the new ticket, please report the ticket number  
> here. I guess I understand what your problem is and I can provide a  
> patch in trac later on.
>
> On Mon, 02 Mar 2009 20:28:40 +0100, ??????? ???????  
> <dumaxa@gmail.com> wrote:
>
>> Greetings to creators!
>>
>> I've found a problem in wordpress 2.7.1.
>> If you try to change the theme of decoration of the site without  
>> removing
>> widgets in advance, than the widgets look as if they are already  
>> added into
>> the theme, and that's why it's impossible to add them into the new  
>> theme.

From tklingenberg at lastflood.net  Sat Apr  4 14:30:02 2009
From: tklingenberg at lastflood.net (Tom Klingenberg)
Date: Sat Apr  4 14:29:53 2009
Subject: [wp-testers] Bug in WP 2.7.1
In-Reply-To: <BDA21DD7-CC35-416D-817B-A7F2960309F9@striderweb.com>
References: <787a77ff0903021128r349ffc67sbb8f1bb86c079a64@mail.gmail.com>
	<op.uruw1cihsed26o@monolith.gonzales>
	<BDA21DD7-CC35-416D-817B-A7F2960309F9@striderweb.com>
Message-ID: <op.uru88czssed26o@monolith.gonzales>

Feel free to post the ticket number here if you can find it. thanks.

On Sat, 04 Apr 2009 16:21:15 +0200, Stephen Rider  
<wp-hackers@striderweb.com> wrote:

> I'm pretty sure that one has been reported before.  It's been brought  
> upa  whole bunch of times.
>
> On Apr 4, 2009, at 5:06 AM, Tom Klingenberg wrote:
>
>> Please report Bugs here:
>>
>> http://core.trac.wordpress.org/
>>
>> By creating a new ticket.
>>
>> If you have created the new ticket, please report the ticket number  
>> here. I guess I understand what your problem is and I can provide a  
>> patch in trac later on.
>>
>> On Mon, 02 Mar 2009 20:28:40 +0100, ??????? ??????? <dumaxa@gmail.com>  
>> wrote:
>>
>>> Greetings to creators!
>>>
>>> I've found a problem in wordpress 2.7.1.
>>> If you try to change the theme of decoration of the site without  
>>> removing
>>> widgets in advance, than the widgets look as if they are already added  
>>> into
>>> the theme, and that's why it's impossible to add them into the new  
>>> theme.
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
From bingorabbit at gmail.com  Sat Apr  4 14:31:08 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Sat Apr  4 14:31:27 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <349fe48b0904040458l6b124592v8a19bdf193d911f0@mail.gmail.com>
References: <C5FB6334.766D%mike@mikevanwinkle.com>
	<C5FB67EA.76FE%mike@mikevanwinkle.com>
	<349fe48b0904040458l6b124592v8a19bdf193d911f0@mail.gmail.com>
Message-ID: <e05a63ba0904040731tb115c2egad548a5612ce050d@mail.gmail.com>

I think that was already done by Jesse in the last submitted patch :)

http://core.trac.wordpress.org/attachment/ticket/9452/9452.1.patch

Thanks in Advance!
On Sat, Apr 4, 2009 at 1:58 PM, scribu <scribu@gmail.com> wrote:

> I think a filter should also be added, so that plugins can add or remove
> file extensions as they please.
>
> On Fri, Apr 3, 2009 at 3:14 PM, Van Winkle Enterprises <
> mike@mikevanwinkle.com> wrote:
>
> > I am traveling today and will be away from my desk. If you have an
> > emergency
> > please call 914-591-7230. I will respond to your email as quickly as
> > possible.
> >
> > Sincerely,
> >
> > Mike
> >
> >
> > _______________________________________________
> > wp-testers mailing list
> > wp-testers@lists.automattic.com
> > http://lists.automattic.com/mailman/listinfo/wp-testers
> >
>
>
>
> --
> http://scribu.net
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From scribu at gmail.com  Sat Apr  4 15:14:16 2009
From: scribu at gmail.com (scribu)
Date: Sat Apr  4 15:14:31 2009
Subject: [wp-testers] Editing Plugin files in 2.8
In-Reply-To: <e05a63ba0904040731tb115c2egad548a5612ce050d@mail.gmail.com>
References: <C5FB6334.766D%mike@mikevanwinkle.com>
	<C5FB67EA.76FE%mike@mikevanwinkle.com>
	<349fe48b0904040458l6b124592v8a19bdf193d911f0@mail.gmail.com>
	<e05a63ba0904040731tb115c2egad548a5612ce050d@mail.gmail.com>
Message-ID: <349fe48b0904040814h675b8930g71c00f8f48c92437@mail.gmail.com>

Neat. :)

On Sat, Apr 4, 2009 at 5:31 PM, Ibrahim A. Mohamed <bingorabbit@gmail.com>wrote:

> I think that was already done by Jesse in the last submitted patch :)
>
> http://core.trac.wordpress.org/attachment/ticket/9452/9452.1.patch
>
> Thanks in Advance!
> On Sat, Apr 4, 2009 at 1:58 PM, scribu <scribu@gmail.com> wrote:
>
> > I think a filter should also be added, so that plugins can add or remove
> > file extensions as they please.
>

-- 
http://scribu.net
From gregg at 3wdesign.com  Sat Apr  4 16:51:22 2009
From: gregg at 3wdesign.com (Gregg Luhring)
Date: Sat Apr  4 17:14:53 2009
Subject: [wp-testers] User administration - email
In-Reply-To: <op.uruxlvsosed26o@monolith.gonzales>
References: <5686e4180903120700m257d1490ubb6bffeda9eb2275@mail.gmail.com>
	<op.uruxlvsosed26o@monolith.gonzales>
Message-ID: <9BCDE003-0FFF-4506-AF65-4E749BBEFEA2@3wdesign.com>

Isn't this the beta test list for WP 2.8? Isn't this where bugs in  
2.8 should be reported?
--
Gregg Luhring

On Apr 4, 2009, at 5:18 AM, Tom Klingenberg wrote:

please report bugs in wordpress trac:

http://core.trac.wordpress.org/

-- tom

On Thu, 12 Mar 2009 15:00:49 +0100, Drummond Field  
<drummond@field.ac> wrote:

> Hi,
> First time bug report. I have been using the SVN version of WP for  
> a while
> now, and this is the first time I have found what I think to be a bug.
> Currently using version : 10773.
>
> I have found that I can no longer modify a users email address in  
> the users
> admin section. If I try and change the address, on save the field  
> comes back
> as blank, I have tried repeated times to save an email address in  
> the now
> blank field - but everytime I get the successful, but no email is  
> saved.
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

From matt at sivel.net  Sat Apr  4 18:13:38 2009
From: matt at sivel.net (Matt Martz)
Date: Sat Apr  4 18:14:04 2009
Subject: [wp-testers] User administration - email
Message-ID: <8rp4txty4w0kqutux4oiifch.1238868818190@email.android.com>

That would be the wp-testers list

Gregg Luhring <gregg@3wdesign.com> wrote:

>Isn't this the beta test list for WP 2.8? Isn't this where bugs in  
>2.8 should be reported?
>--
>Gregg Luhring
>
>On Apr 4, 2009, at 5:18 AM, Tom Klingenberg wrote:
>
>please report bugs in wordpress trac:
>
>http://core.trac.wordpress.org/
>
>-- tom
>
>On Thu, 12 Mar 2009 15:00:49 +0100, Drummond Field  
><drummond@field.ac> wrote:
>
>> Hi,
>> First time bug report. I have been using the SVN version of WP for  
>> a while
>> now, and this is the first time I have found what I think to be a bug.
>> Currently using version : 10773.
>>
>> I have found that I can no longer modify a users email address in  
>> the users
>> admin section. If I try and change the address, on save the field  
>> comes back
>> as blank, I have tried repeated times to save an email address in  
>> the now
>> blank field - but everytime I get the successful, but no email is  
>> saved.
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>_______________________________________________
>wp-testers mailing list
>wp-testers@lists.automattic.com
>http://lists.automattic.com/mailman/listinfo/wp-testers
>
>_______________________________________________
>wp-testers mailing list
>wp-testers@lists.automattic.com
>http://lists.automattic.com/mailman/listinfo/wp-testers

-- 
--
Matt Martz
matt@sivel.net
From matt at sivel.net  Sat Apr  4 18:42:31 2009
From: matt at sivel.net (Matt Martz)
Date: Sat Apr  4 18:43:01 2009
Subject: [wp-testers] User administration - email
Message-ID: <jmeh035le365brm0vmqv9htw.1238870551346@email.android.com>

Oops...should have looked more closely at the list this was sent to.  

Gregg Luhring <gregg@3wdesign.com> wrote:

>Isn't this the beta test list for WP 2.8? Isn't this where bugs in  
>2.8 should be reported?
>--
>Gregg Luhring
>
>On Apr 4, 2009, at 5:18 AM, Tom Klingenberg wrote:
>
>please report bugs in wordpress trac:
>
>http://core.trac.wordpress.org/
>
>-- tom
>
>On Thu, 12 Mar 2009 15:00:49 +0100, Drummond Field  
><drummond@field.ac> wrote:
>
>> Hi,
>> First time bug report. I have been using the SVN version of WP for  
>> a while
>> now, and this is the first time I have found what I think to be a bug.
>> Currently using version : 10773.
>>
>> I have found that I can no longer modify a users email address in  
>> the users
>> admin section. If I try and change the address, on save the field  
>> comes back
>> as blank, I have tried repeated times to save an email address in  
>> the now
>> blank field - but everytime I get the successful, but no email is  
>> saved.
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>_______________________________________________
>wp-testers mailing list
>wp-testers@lists.automattic.com
>http://lists.automattic.com/mailman/listinfo/wp-testers
>
>_______________________________________________
>wp-testers mailing list
>wp-testers@lists.automattic.com
>http://lists.automattic.com/mailman/listinfo/wp-testers

-- 
--
Matt Martz
matt@sivel.net
From pablorobinson at gmail.com  Tue Apr 14 12:29:43 2009
From: pablorobinson at gmail.com (Paul Robinson)
Date: Tue Apr 14 12:30:22 2009
Subject: [wp-testers] **Maybe OT** Hacking Problem In 2.7.1
Message-ID: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com>

Hi,

I hope the title is descriptive enough & I think it's a little off topic so
I've added that.

Basically for the last 2 maybe 3 weeks I've had stability problems with my
website, I assumed it was down to server problems & asked my host to check
it out. Apparently there was no problems. Then the site just stopped working
& only showing 500 errors. I download the apache error logs & find this:

[Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
Access denied with code 503 (phase 2). Pattern match
"=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
at REQUEST_URI. [file
"/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
"23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt to
remote include command shell"] [severity "CRITICAL"] [hostname "
return-true.com"] [uri "/hw3.php"] [unique_id "SeMyEkPNBIMAAFN2guwAAAAE"]
[Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
Access denied with code 503 (phase 2). Pattern match
"=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
at REQUEST_URI. [file
"/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
"23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt to
remote include command shell"] [severity "CRITICAL"] [hostname "
return-true.com"] [uri "/2009/03//hw3.php"] [unique_id
"SeMyEkPNBIMAAEe1L5IAAAAF"]
[Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
Access denied with code 503 (phase 2). Pattern match
"=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
at REQUEST_URI. [file
"/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
"23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt to
remote include command shell"] [severity "CRITICAL"] [hostname "
return-true.com"] [uri
"/2009/03/zstore-helper-wordpress-plugin-for-zazzle-store-builder//hw3.php"]
[unique_id "SeMyEkPNBIMAAFLAg@sAAAAC"]
[Mon Apr 13 05:51:33 2009] [error] [client 200.93.147.154] ModSecurity:
Access denied with code 503 (phase 2). Pattern match
"=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
at REQUEST_URI. [file
"/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
"23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt to
remote include command shell"] [severity "CRITICAL"] [hostname "
return-true.com"] [uri "/includes/header.php"] [unique_id
"SeM1VUPNBIMAAGVMYQAAAAAJ"]
[Mon Apr 13 05:51:33 2009] [error] [client 200.93.147.154] ModSecurity:
Access denied with code 503 (phase 2). Pattern match
"=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
at REQUEST_URI. [file
"/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
"23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt to
remote include command shell"] [severity "CRITICAL"] [hostname "
return-true.com"] [uri "/2009/04/php-tip-5-header//includes/header.php"]
[unique_id "SeM1VUPNBIMAAHm84wEAAAAF"]

then after that all processes created by my site a cut by the shared servers
memory limiting script. The last two times this happened it took a reinstall
of WordPress' files to fix it, but this last time I had to restore a back up
of the database, which are taken regularly thank god. I have been told by my
host that the attacks are always blocked but they seem to break WordPress
somehow & that's what I'm hoping someone can help with. I realize it's a
long shot, but I've got nothing to lose seeing as it's happening fairly
often.

I have beefed up security on WP a lot, I've changed the default db prefix,
I've chmod'ed all folders to the recommended settings & i've placed
.htaccess files in my admin & includes folders. Any other suggestions of
what is happening or how to stop it would be great. Thanks

Paul.
From bingorabbit at gmail.com  Tue Apr 14 13:29:00 2009
From: bingorabbit at gmail.com (Ibrahim A. Mohamed)
Date: Tue Apr 14 13:29:16 2009
Subject: [wp-testers] **Maybe OT** Hacking Problem In 2.7.1
In-Reply-To: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com>
References: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com>
Message-ID: <e05a63ba0904140629k528cbb87k3013ae0e682dc100@mail.gmail.com>

Hello,

Can you please send us the content of .htaccess in the root directory of
your wordpress installation.

Also have you changed any of your files' permissions?

Is there any suspected activity in your website's traffic?

Thanks in Advance!

On Tue, Apr 14, 2009 at 2:29 PM, Paul Robinson <pablorobinson@gmail.com>wrote:

> Hi,
>
> I hope the title is descriptive enough & I think it's a little off topic so
> I've added that.
>
> Basically for the last 2 maybe 3 weeks I've had stability problems with my
> website, I assumed it was down to server problems & asked my host to check
> it out. Apparently there was no problems. Then the site just stopped
> working
> & only showing 500 errors. I download the apache error logs & find this:
>
> [Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
> Access denied with code 503 (phase 2). Pattern match
>
> "=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
> at REQUEST_URI. [file
> "/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
> "23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt
> to
> remote include command shell"] [severity "CRITICAL"] [hostname "
> return-true.com"] [uri "/hw3.php"] [unique_id "SeMyEkPNBIMAAFN2guwAAAAE"]
> [Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
> Access denied with code 503 (phase 2). Pattern match
>
> "=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
> at REQUEST_URI. [file
> "/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
> "23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt
> to
> remote include command shell"] [severity "CRITICAL"] [hostname "
> return-true.com"] [uri "/2009/03//hw3.php"] [unique_id
> "SeMyEkPNBIMAAEe1L5IAAAAF"]
> [Mon Apr 13 05:37:38 2009] [error] [client 217.199.222.19] ModSecurity:
> Access denied with code 503 (phase 2). Pattern match
>
> "=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
> at REQUEST_URI. [file
> "/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
> "23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt
> to
> remote include command shell"] [severity "CRITICAL"] [hostname "
> return-true.com"] [uri
>
> "/2009/03/zstore-helper-wordpress-plugin-for-zazzle-store-builder//hw3.php"]
> [unique_id "SeMyEkPNBIMAAFLAg@sAAAAC"]
> [Mon Apr 13 05:51:33 2009] [error] [client 200.93.147.154] ModSecurity:
> Access denied with code 503 (phase 2). Pattern match
>
> "=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
> at REQUEST_URI. [file
> "/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
> "23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt
> to
> remote include command shell"] [severity "CRITICAL"] [hostname "
> return-true.com"] [uri "/includes/header.php"] [unique_id
> "SeM1VUPNBIMAAGVMYQAAAAAJ"]
> [Mon Apr 13 05:51:33 2009] [error] [client 200.93.147.154] ModSecurity:
> Access denied with code 503 (phase 2). Pattern match
>
> "=(http|www|ftp)\\:/(.+)\\.(c|dat|kek|gif|jpe?g|jpeg|png|sh|txt|bmp|dat|txt|js|html?|tmp|asp)\\x20?\\?"
> at REQUEST_URI. [file
> "/dh/apache2/template/etc/mod_sec2/gotroot/50_asl_rootkits.conf"] [line
> "23"] [id "390144"] [rev "2"] [msg "Command shell attack: Generic Attempt
> to
> remote include command shell"] [severity "CRITICAL"] [hostname "
> return-true.com"] [uri "/2009/04/php-tip-5-header//includes/header.php"]
> [unique_id "SeM1VUPNBIMAAHm84wEAAAAF"]
>
> then after that all processes created by my site a cut by the shared
> servers
> memory limiting script. The last two times this happened it took a
> reinstall
> of WordPress' files to fix it, but this last time I had to restore a back
> up
> of the database, which are taken regularly thank god. I have been told by
> my
> host that the attacks are always blocked but they seem to break WordPress
> somehow & that's what I'm hoping someone can help with. I realize it's a
> long shot, but I've got nothing to lose seeing as it's happening fairly
> often.
>
> I have beefed up security on WP a lot, I've changed the default db prefix,
> I've chmod'ed all folders to the recommended settings & i've placed
> .htaccess files in my admin & includes folders. Any other suggestions of
> what is happening or how to stop it would be great. Thanks
>
> Paul.
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>



-- 
Regards,
Ibrahim Abdel Fattah Mohamed
Web Developer
Twitter: @bingorabbit
e-mail: bingorabbit@gmail.com
Personal bLOG: http://bingorabbit.com/
From dougal at gunters.org  Tue Apr 14 13:35:29 2009
From: dougal at gunters.org (Dougal Campbell)
Date: Tue Apr 14 13:35:45 2009
Subject: [wp-testers] **Maybe OT** Hacking Problem In 2.7.1
In-Reply-To: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com>
References: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com>
Message-ID: <49E49121.2030707@gunters.org>

Paul Robinson wrote:
> Hi,
>
> I hope the title is descriptive enough & I think it's a little off topic so
> I've added that.
>
> Basically for the last 2 maybe 3 weeks I've had stability problems with my
> website, I assumed it was down to server problems & asked my host to check
> it out. Apparently there was no problems. Then the site just stopped working
> & only showing 500 errors. I download the apache error logs & find this:
>
> [...mod_security log msgs...]
>   

That just looks to me like mod_security is doing its job correctly. It's 
showing you that a suspicious request was made, and mod_security blocked 
it according to its rules. This is a Good Thing.

> then after that all processes created by my site a cut by the **shared servers**
> memory limiting script. [...]
>   

(emphasis mine)

It sounds like you're doing all the right things to secure your site. 
But, if you are running on a shared server, then you can't know for sure 
that other users are securing *their* sites. Once an attacker gets 
unauthorized access, even if it's via some *other* virtual host on the 
same server as you, they can potentially start messing with *your* 
stuff. If you find evidence that your WP install has been compromised in 
some way, there's a good possibility that this is what has happened on 
your server.

That why I prefer to use a VPS (virtual private server) or other type of 
dedicated host. Its' a little more expensive (but not unreasonably so), 
but worth the peace of mind that you really have the whole server to 
yourself.

-- 
Dougal Campbell <dougal@gunters.org>
http://dougal.gunters.org/
http://twitter.com/dougal
http://twitual.com/
*Hire me!*
From pablorobinson at gmail.com  Tue Apr 14 14:29:08 2009
From: pablorobinson at gmail.com (Paul Robinson)
Date: Tue Apr 14 14:29:39 2009
Subject: [wp-testers] **Maybe OT** Hacking Problem In 2.7.1
In-Reply-To: <49E49121.2030707@gunters.org>
References: <1931c86d0904140529wb7edba8m831c6ecf99bdf1ac@mail.gmail.com> 
	<49E49121.2030707@gunters.org>
Message-ID: <1931c86d0904140729i4dbf8623gb267293fa9bae05c@mail.gmail.com>

Hi,

All file permissions are set as WordPress recommends, none have been
changed. My .htaccess has nothing suspect in it just the normal WP code,
supercache code & a maintainence code I have in there that I comment out &
uncomment as I need it.

I had guessed that the Mod_sec logs were a good thing, it just seems odd
that it happens a few minutes after the log times. I had guessed about the
shared server thing, but I contacted the host and they say no other problems
have been reported with any WP installations on my server, I realize that
the hack could still be the same it just seems odd that it has only started
happening in the past few days & that the mod_sec logs are always the same.

I'd guess that it's the same person, but the IP changes although they could
be using a anon proxy rotator or and I just getting to James Bondy here.
lol.

Any other suggestions would be greatly appreciated.

Paul.

2009/4/14 Dougal Campbell <dougal@gunters.org>

> Paul Robinson wrote:
>
>> Hi,
>>
>> I hope the title is descriptive enough & I think it's a little off topic
>> so
>> I've added that.
>>
>> Basically for the last 2 maybe 3 weeks I've had stability problems with my
>> website, I assumed it was down to server problems & asked my host to check
>> it out. Apparently there was no problems. Then the site just stopped
>> working
>> & only showing 500 errors. I download the apache error logs & find this:
>>
>> [...mod_security log msgs...]
>>
>>
>
> That just looks to me like mod_security is doing its job correctly. It's
> showing you that a suspicious request was made, and mod_security blocked it
> according to its rules. This is a Good Thing.
>
>  then after that all processes created by my site a cut by the **shared
>> servers**
>> memory limiting script. [...]
>>
>>
>
> (emphasis mine)
>
> It sounds like you're doing all the right things to secure your site. But,
> if you are running on a shared server, then you can't know for sure that
> other users are securing *their* sites. Once an attacker gets unauthorized
> access, even if it's via some *other* virtual host on the same server as
> you, they can potentially start messing with *your* stuff. If you find
> evidence that your WP install has been compromised in some way, there's a
> good possibility that this is what has happened on your server.
>
> That why I prefer to use a VPS (virtual private server) or other type of
> dedicated host. Its' a little more expensive (but not unreasonably so), but
> worth the peace of mind that you really have the whole server to yourself.
>
> --
> Dougal Campbell <dougal@gunters.org>
> http://dougal.gunters.org/
> http://twitter.com/dougal
> http://twitual.com/
> *Hire me!*
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From gp at iampearce.com  Tue Apr 14 16:10:07 2009
From: gp at iampearce.com (George Pearce)
Date: Tue Apr 14 16:10:43 2009
Subject: [wp-testers] SimplePie Issues On The Dashboard
Message-ID: <49e4b573.0506d00a.511b.027d@mx.google.com>

I installed the latest trunk versoin of Wordpress today, figured I'd give it
a shot, and on loading the dashboard, was met with this:


Fatal error: Cannot redeclare class SimplePie in
/nfs/c03/h01/mnt/4xxxx/domains/iampearce.com/html/wp-includes/class-simplepi
e.php on line 386

 

 

Should I expect this? I dunno. I'm using MediaTemple's (gs) service, on
Cluster 3; with PHP5.

 

For the record, that was in the "Incoming Links" section, and none of the
page loads after that. The javascript doesn't appear to load so I cant turn
that module off, either.

 

 

George Pearce

gp@iampearce.com

http://www.iampearce.com

 

 

From matt at sivel.net  Tue Apr 14 16:19:24 2009
From: matt at sivel.net (Matt Martz)
Date: Tue Apr 14 16:19:55 2009
Subject: [wp-testers] SimplePie Issues On The Dashboard
In-Reply-To: <49e4b573.0506d00a.511b.027d@mx.google.com>
References: <49e4b573.0506d00a.511b.027d@mx.google.com>
Message-ID: <518fa9630904140919jbf46613ga181ce278cba9cde@mail.gmail.com>

On Tue, Apr 14, 2009 at 12:10 PM, George Pearce <gp@iampearce.com> wrote:
> I installed the latest trunk versoin of Wordpress today, figured I'd give it
> a shot, and on loading the dashboard, was met with this:
>
> Fatal error: Cannot redeclare class SimplePie in
> /nfs/c03/h01/mnt/4xxxx/domains/iampearce.com/html/wp-includes/class-simplepi
> e.php on line 386
>
> Should I expect this? I dunno. I'm using MediaTemple's (gs) service, on
> Cluster 3; with PHP5.
>
> For the record, that was in the "Incoming Links" section, and none of the
> page loads after that. The javascript doesn't appear to load so I cant turn
> that module off, either.

I see from your site that it appears that you are using the lifestream
plugin.  The lifestream plugin contains and uses SimplePie.  WP 2.8
now includes SimplePie.  Because that plugin and WordPress are both
trying to load SimplePie you will get that error.

-- 
Matt Martz
matt@sivel.net
http://sivel.net/
From joseph at josephscott.org  Tue Apr 14 16:34:01 2009
From: joseph at josephscott.org (Joseph Scott)
Date: Tue Apr 14 16:34:21 2009
Subject: [wp-testers] SimplePie Issues On The Dashboard
In-Reply-To: <518fa9630904140919jbf46613ga181ce278cba9cde@mail.gmail.com>
References: <49e4b573.0506d00a.511b.027d@mx.google.com>
	<518fa9630904140919jbf46613ga181ce278cba9cde@mail.gmail.com>
Message-ID: <DB48E4B0-0973-4802-9F04-3353F4C3F00F@josephscott.org>


On Apr 14, 2009, at 10:19 AM, Matt Martz wrote:

> I see from your site that it appears that you are using the lifestream
> plugin.  The lifestream plugin contains and uses SimplePie.  WP 2.8
> now includes SimplePie.  Because that plugin and WordPress are both
> trying to load SimplePie you will get that error.



I ran into this exact same problem as well.  I ended up adjusting the  
lifestream.php file and replaced:

----------
if (!class_exists('SimplePie'))
{
     require_once(dirname(__FILE__) . '/lib/simplepie.inc.php');
}
----------

with:

----------
require_once ABSPATH . WPINC . '/class-simplepie.php';
----------

This just makes the lifestream plugin use the simplepie that ships  
with WP 2.8+

--
Joseph Scott
joseph@josephscott.org
http://josephscott.org/




From ryan at boren.nu  Tue Apr 14 17:04:11 2009
From: ryan at boren.nu (Ryan Boren)
Date: Tue Apr 14 17:31:45 2009
Subject: [wp-testers] SimplePie Issues On The Dashboard
In-Reply-To: <DB48E4B0-0973-4802-9F04-3353F4C3F00F@josephscott.org>
References: <49e4b573.0506d00a.511b.027d@mx.google.com>
	<518fa9630904140919jbf46613ga181ce278cba9cde@mail.gmail.com>
	<DB48E4B0-0973-4802-9F04-3353F4C3F00F@josephscott.org>
Message-ID: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>

On Tue, Apr 14, 2009 at 9:34 AM, Joseph Scott <joseph@josephscott.org> wrote:
>
> On Apr 14, 2009, at 10:19 AM, Matt Martz wrote:
>
>> I see from your site that it appears that you are using the lifestream
>> plugin. ?The lifestream plugin contains and uses SimplePie. ?WP 2.8
>> now includes SimplePie. ?Because that plugin and WordPress are both
>> trying to load SimplePie you will get that error.
>
>
>
> I ran into this exact same problem as well. ?I ended up adjusting the
> lifestream.php file and replaced:
>
> ----------
> if (!class_exists('SimplePie'))
> {
> ? ?require_once(dirname(__FILE__) . '/lib/simplepie.inc.php');
> }
> ----------
>
> with:
>
> ----------
> require_once ABSPATH . WPINC . '/class-simplepie.php';
> ----------
>
> This just makes the lifestream plugin use the simplepie that ships with WP
> 2.8+

I added a class_exists check to class-feed.php.  Ideally, plugins
should be upgraded to use fetch_feed() so that the WP cache and HTTP
transport is used by SimplePie.
From dan at instinct.co.nz  Thu Apr 16 05:36:27 2009
From: dan at instinct.co.nz (Dan Milward)
Date: Thu Apr 16 05:36:45 2009
Subject: [wp-testers] hook for editing posts / pages
In-Reply-To: <EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>
	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>
	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
Message-ID: <49E6C3DB.1080903@instinct.co.nz>

Hey Guys,

Everybody loves inline editing for:
1) page content
2) post content
3) page / post title
4) blog title

Right?!?

So now that P2 has inline editing what I'm wondering is whether or not 
us Plugin developers can do this ourselves using hooks or filters - or 
would we best rip apart P2 and develop this ourselves?

Best,

Dan
From tpblogeditor at gmail.com  Thu Apr 16 05:54:08 2009
From: tpblogeditor at gmail.com (Paleo Pat)
Date: Thu Apr 16 05:54:24 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
Message-ID: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>

I like it! I like it! Niiiiiiice...

:)

-Paleo Pat
http://www.politicalbyline.com
From haha at hahahaimontheinternet.com  Thu Apr 16 06:22:58 2009
From: haha at hahahaimontheinternet.com (Martin)
Date: Thu Apr 16 06:23:18 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
Message-ID: <2F7A5C201057467EB54E3274F54D47AF@wpww>

I agree~~~~!!!!!

----- Original Message ----- 
From: "Paleo Pat" <tpblogeditor@gmail.com>
To: <wp-testers@lists.automattic.com>
Sent: Thursday, April 16, 2009 3:54 PM
Subject: [wp-testers] Widgets in 2.8 Bleeding...


>I like it! I like it! Niiiiiiice...
> 
> :)
> 
> -Paleo Pat
> http://www.politicalbyline.com
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>

From josiahrobertson at gmail.com  Thu Apr 16 06:30:39 2009
From: josiahrobertson at gmail.com (Josiah Robertson)
Date: Thu Apr 16 06:30:53 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <2F7A5C201057467EB54E3274F54D47AF@wpww>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
Message-ID: <9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>

oh yeah! I can help!

On Thu, Apr 16, 2009 at 2:22 AM, Martin <haha@hahahaimontheinternet.com>wrote:

> I agree~~~~!!!!!
>
> ----- Original Message ----- From: "Paleo Pat" <tpblogeditor@gmail.com>
> To: <wp-testers@lists.automattic.com>
> Sent: Thursday, April 16, 2009 3:54 PM
> Subject: [wp-testers] Widgets in 2.8 Bleeding...
>
>
>
>  I like it! I like it! Niiiiiiice...
>>
>> :)
>>
>> -Paleo Pat
>> http://www.politicalbyline.com
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>



-- 
Josiah Robertson
(804) 512-9877
josiahrobertson@gmail.com
From dan at instinct.co.nz  Thu Apr 16 06:41:42 2009
From: dan at instinct.co.nz (Dan Milward)
Date: Thu Apr 16 06:43:42 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
Message-ID: <49E6D326.8000507@instinct.co.nz>

I agree it looks very nice.

Does anybody know if a more advanced widget management is coming for 2.8 
launch? We'd like to contribute code to that - we reckon it is important 
to specify which pages/posts widgets display on... kinda like slayers 
but with better UI :P

Best,

Dan

p.s. now what about those hooks for inline editing pages and posts ;)

Josiah Robertson wrote:
> oh yeah! I can help!
>
> On Thu, Apr 16, 2009 at 2:22 AM, Martin <haha@hahahaimontheinternet.com>wrote:
>
>   
>> I agree~~~~!!!!!
>>
>> ----- Original Message ----- From: "Paleo Pat" <tpblogeditor@gmail.com>
>> To: <wp-testers@lists.automattic.com>
>> Sent: Thursday, April 16, 2009 3:54 PM
>> Subject: [wp-testers] Widgets in 2.8 Bleeding...
>>
>>
>>
>>  I like it! I like it! Niiiiiiice...
>>     
>>> :)
>>>
>>> -Paleo Pat
>>> http://www.politicalbyline.com
>>> _______________________________________________
>>> wp-testers mailing list
>>> wp-testers@lists.automattic.com
>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>
>>>
>>>       
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>>     
>
>
>
>   
From scribu at gmail.com  Thu Apr 16 06:55:27 2009
From: scribu at gmail.com (scribu)
Date: Thu Apr 16 06:55:42 2009
Subject: [wp-testers] hook for editing posts / pages
In-Reply-To: <49E6C3DB.1080903@instinct.co.nz>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>
	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>
	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
	<49E6C3DB.1080903@instinct.co.nz>
Message-ID: <349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>

How about my plugin, Front-end Editor?
http://scribu.net/wordpress/front-end-editor

BTW, what is this P2 that you speak of?

On 4/16/09, Dan Milward <dan@instinct.co.nz> wrote:
> Hey Guys,
>
> Everybody loves inline editing for:
> 1) page content
> 2) post content
> 3) page / post title
> 4) blog title
>
> Right?!?
>
> So now that P2 has inline editing what I'm wondering is whether or not
> us Plugin developers can do this ourselves using hooks or filters - or
> would we best rip apart P2 and develop this ourselves?
>
> Best,
>
> Dan
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>


-- 
http://scribu.net
From kikizas at gmail.com  Thu Apr 16 07:13:39 2009
From: kikizas at gmail.com (Demetris)
Date: Thu Apr 16 07:14:12 2009
Subject: [wp-testers] hook for editing posts / pages
In-Reply-To: <349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>
	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>
	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
	<49E6C3DB.1080903@instinct.co.nz>
	<349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
Message-ID: <9f34a3610904160013w911ec7fr253e02d85ecc216b@mail.gmail.com>

On Thu, Apr 16, 2009 at 9:55 AM, scribu <scribu@gmail.com> wrote:
> How about my plugin, Front-end Editor?
> http://scribu.net/wordpress/front-end-editor
>
> BTW, what is this P2 that you speak of?
>
The new Prologue theme, which is now available in wp.org too:

http://en.blog.wordpress.com/2009/03/11/p2-the-new-prologue/

http://wordpress.org/extend/themes/p2

Cheers,

Demetris
http://op111.net/
From admin at laptoptips.ca  Thu Apr 16 07:34:33 2009
From: admin at laptoptips.ca (Andrew Ozz)
Date: Thu Apr 16 07:34:33 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <49E6D326.8000507@instinct.co.nz>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>	<2F7A5C201057467EB54E3274F54D47AF@wpww>	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz>
Message-ID: <49E6DF89.7090006@laptoptips.ca>

Does everything on the widgets page work as expected? Anything that feels 
awkward/hard to use? Any widgets that fail to save or bring js errors?

It's all AJAX-ified and all sidebars (including the Available Widgets 
area) can be folded to make it easier to use on smaller screens. The 
Inactive Widgets area is for storing widgets that are configured but not 
in any sidebar at the moment. Also when changing themes if the new theme 
has less sidebars than the old one, all widgets from the extra sidebar(s) 
are moved to Inactive.

Dan Milward wrote:
> I agree it looks very nice.

The look isn't fully completed yet. Hopefully it will look even nicer :)

> Does anybody know if a more advanced widget management is coming for
> 2.8 launch? We'd like to contribute code to that - we reckon it is
> important to specify which pages/posts widgets display on... kinda
> like slayers but with better UI :P

Don't think there will be any significant feature changes any more. We 
are getting close to first beta for 2.8, not enough time left. Also the 
code/API has to stay backwards compatible.

Will probably revisit widgets for 2.9 when (hopefully) all widgets will 
be using the new multi-widget class so we can streamline the API 
functions and add features without breaking compatibility.

On the other hand if you need more hooks, choose a good place that won't 
limit future changes and open a ticket. In the worst case it will be left 
for 2.9.

From dan at instinct.co.nz  Thu Apr 16 08:46:49 2009
From: dan at instinct.co.nz (Dan Milward)
Date: Thu Apr 16 08:47:17 2009
Subject: [wp-testers] hook for editing posts / pages
In-Reply-To: <349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>
	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>
	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
	<49E6C3DB.1080903@instinct.co.nz>
	<349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
Message-ID: <B8AD42CD-00B5-4C0E-8E08-0C9349899410@instinct.co.nz>

Nice Plugin bro!!!

Sent from my iPhone

On 16/04/2009, at 6:55 PM, scribu <scribu@gmail.com> wrote:

> How about my plugin, Front-end Editor?
> http://scribu.net/wordpress/front-end-editor
>
> BTW, what is this P2 that you speak of?
>
> On 4/16/09, Dan Milward <dan@instinct.co.nz> wrote:
>> Hey Guys,
>>
>> Everybody loves inline editing for:
>> 1) page content
>> 2) post content
>> 3) page / post title
>> 4) blog title
>>
>> Right?!?
>>
>> So now that P2 has inline editing what I'm wondering is whether or  
>> not
>> us Plugin developers can do this ourselves using hooks or filters -  
>> or
>> would we best rip apart P2 and develop this ourselves?
>>
>> Best,
>>
>> Dan
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>
>
> -- 
> http://scribu.net
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
From tpblogeditor at gmail.com  Thu Apr 16 09:14:05 2009
From: tpblogeditor at gmail.com (Paleo Pat)
Date: Thu Apr 16 09:14:19 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <49E6DF89.7090006@laptoptips.ca>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz> <49E6DF89.7090006@laptoptips.ca>
Message-ID: <c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>

All works here... so far, there's an error, believe me, you'll know about
it. ;-P

(warning the following might have wordy derd or two, or as it is commonly
known as, a swear word or two in it...)

In an sorta related, and sorta not item. I have hosting with site5.com.
They're doing server upgrades, and anyways, I did the update to the latest
build and I notice the new widget layout. Anyways, I wanted to add a little
square banner to my Blog, and so, I went and snagged the code, and was going
to add it to a preexisting widget. So, I pasted said code and hit save and I
see the swirl, going around and around and around... and I'm thinking
"Uh-oh...." and I hit refresh, and sure enough, dead flippin' server, no
response, I let out a very long drawn out "ooooohhh Fuuuuuuck....." and went
over to tech support and started the process of finding out what exactly
happened, and what I broke.

Well, believe it or not, It wasn't me. They were doing server upgrades an
guess who's got done first... Mine. When the support tech guy told me that,
I nearly died laughing, I would have loved to been the fly on the wall
during that tech support meeting! "Yeah, let's do the server that the
asshole political blogger is on FIRST, he's very picky and the minute the
server goes down, he is on us like a mad man!" LOL! Anyhow, the server was
back up in like 5 minutes. I was able to add my code without any trouble at
all.

It might not be as funny to you guys, but for me, it was the best laugh I'd
had in a while. You know you're important when they upgrade your server
first! LOL!

-Paleo Pat
http://www.politicalbyline.com




On Thu, Apr 16, 2009 at 3:34 AM, Andrew Ozz <admin@laptoptips.ca> wrote:

> Does everything on the widgets page work as expected? Anything that feels
> awkward/hard to use? Any widgets that fail to save or bring js errors?
>
> It's all AJAX-ified and all sidebars (including the Available Widgets area)
> can be folded to make it easier to use on smaller screens. The Inactive
> Widgets area is for storing widgets that are configured but not in any
> sidebar at the moment. Also when changing themes if the new theme has less
> sidebars than the old one, all widgets from the extra sidebar(s) are moved
> to Inactive.
>
> Dan Milward wrote:
>
>> I agree it looks very nice.
>>
>
> The look isn't fully completed yet. Hopefully it will look even nicer :)
>
>  Does anybody know if a more advanced widget management is coming for
>> 2.8 launch? We'd like to contribute code to that - we reckon it is
>> important to specify which pages/posts widgets display on... kinda
>> like slayers but with better UI :P
>>
>
> Don't think there will be any significant feature changes any more. We are
> getting close to first beta for 2.8, not enough time left. Also the code/API
> has to stay backwards compatible.
>
> Will probably revisit widgets for 2.9 when (hopefully) all widgets will be
> using the new multi-widget class so we can streamline the API functions and
> add features without breaking compatibility.
>
> On the other hand if you need more hooks, choose a good place that won't
> limit future changes and open a ticket. In the worst case it will be left
> for 2.9.
>
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From jane at automattic.com  Thu Apr 16 11:32:47 2009
From: jane at automattic.com (Jane Wells)
Date: Thu Apr 16 11:33:04 2009
Subject: [wp-testers] 24-hour has-patch marathon
In-Reply-To: <20090416084720.C6674672E@comox.textdrive.com>
References: <20090416084720.C6674672E@comox.textdrive.com>
Message-ID: <63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>

Hi everyone. A reminder post will go live on the dev blog at 4pm UTC/ 
9am Pacific about the 24-hour has-patch marathon that's happening  
today/tomorrow, but I thought I'd drop a note in here as well. Since  
the key to the marathon resulting in a lot of commits today/tonight is  
having patches tested before the core devs get to them, this event is  
really about you guys. Yes, people are encouraged to submit patches  
during the marathon, but the real need is testing. There are almost  
200 patches sitting in Trac waiting to be evaluated, and most of them  
need testing. If you can take some time today to test a few, that  
would be great. Here are the tickets with patches:

http://core.trac.wordpress.org/query?status=assigned&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&milestone=2.8&keywords= 
~has-patch

And if anyone plans to stay up and actually test patches for a full 24  
hours, let me know. If you're blogging/twittering about it throughout  
the marathon (saying what tickets you're currently testing or  
whatever), we might point to you as an example from the WordPress  
twitter account.

When I put up the results of the marathon on the dev blog on Monday,  
I'll also link to the top 5 testers from the 24-hour marathon period  
(measured by number of patches tested/commented in trac treads).

Thanks!
Jane
From prodevstudio at gmail.com  Thu Apr 16 17:02:31 2009
From: prodevstudio at gmail.com (ProDevStudio)
Date: Thu Apr 16 17:03:03 2009
Subject: [wp-testers] 24-hour has-patch marathon
In-Reply-To: <63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
References: <20090416084720.C6674672E@comox.textdrive.com> 
	<63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
Message-ID: <d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>

Hi Jane,

Interesting but that link is broken in Gmail. the "~has-patch" part does not
get linked... might want to use a shorter link next time.

Will try testing some...

Regards,

Azizur Rahman
ProDevStudio

Do you need cost effective web hosting solution and Domain name try
http://prodevstudio.com

Do you need a new web site try http://cgandc.net

Missed the last Friday Khutbah, try catchup a Khutbah on-line now at
http://fridaykhutbah.com


On Thu, Apr 16, 2009 at 12:32 PM, Jane Wells <jane@automattic.com> wrote:

> Hi everyone. A reminder post will go live on the dev blog at 4pm UTC/9am
> Pacific about the 24-hour has-patch marathon that's happening
> today/tomorrow, but I thought I'd drop a note in here as well. Since the key
> to the marathon resulting in a lot of commits today/tonight is having
> patches tested before the core devs get to them, this event is really about
> you guys. Yes, people are encouraged to submit patches during the marathon,
> but the real need is testing. There are almost 200 patches sitting in Trac
> waiting to be evaluated, and most of them need testing. If you can take some
> time today to test a few, that would be great. Here are the tickets with
> patches:
>
>
> http://core.trac.wordpress.org/query?status=assigned&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&milestone=2.8&keywords=
> ~has-patch
>
> And if anyone plans to stay up and actually test patches for a full 24
> hours, let me know. If you're blogging/twittering about it throughout the
> marathon (saying what tickets you're currently testing or whatever), we
> might point to you as an example from the WordPress twitter account.
>
> When I put up the results of the marathon on the dev blog on Monday, I'll
> also link to the top 5 testers from the 24-hour marathon period (measured by
> number of patches tested/commented in trac treads).
>
> Thanks!
> Jane
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From matt at sivel.net  Thu Apr 16 17:10:54 2009
From: matt at sivel.net (Matt Martz)
Date: Thu Apr 16 17:11:28 2009
Subject: [wp-testers] 24-hour has-patch marathon
In-Reply-To: <d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
References: <20090416084720.C6674672E@comox.textdrive.com> 
	<63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
	<d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
Message-ID: <518fa9630904161010o5aa92bd9t27e25a2ed9e296ff@mail.gmail.com>

On Thu, Apr 16, 2009 at 1:02 PM, ProDevStudio <prodevstudio@gmail.com> wrote:
> Hi Jane,
>
> Interesting but that link is broken in Gmail. the "~has-patch" part does not
> get linked... might want to use a shorter link next time.
>
> Will try testing some...
>
> Regards,
>
> Azizur Rahman
> ProDevStudio

Azizur,  here is a link that should work for you.  Shortened for ease of use:

http://tinyurl.com/chct78

-- 
Matt Martz
matt@sivel.net
http://sivel.net/
From spockers at gmail.com  Thu Apr 16 17:12:52 2009
From: spockers at gmail.com (Tim and Farah Jones)
Date: Thu Apr 16 17:13:06 2009
Subject: [wp-testers] 24-hour has-patch marathon
In-Reply-To: <d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
References: <20090416084720.C6674672E@comox.textdrive.com>
	<63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
	<d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
Message-ID: <b066747d0904161012y365da078j1832c8f051322ba2@mail.gmail.com>

Maybe the link is an I.Q. test -- anyone capable of testing patches should
be able to figure out the link, LOL.

On Thu, Apr 16, 2009 at 1:02 PM, ProDevStudio <prodevstudio@gmail.com>wrote:

> Hi Jane,
>
> Interesting but that link is broken in Gmail. the "~has-patch" part does
> not
> get linked... might want to use a shorter link next time.
>
> Will try testing some...
>
> Regards,
>
> Azizur Rahman
> ProDevStudio
>
> Do you need cost effective web hosting solution and Domain name try
> http://prodevstudio.com
>
> Do you need a new web site try http://cgandc.net
>
> Missed the last Friday Khutbah, try catchup a Khutbah on-line now at
> http://fridaykhutbah.com
>
>
> On Thu, Apr 16, 2009 at 12:32 PM, Jane Wells <jane@automattic.com> wrote:
>
> > Hi everyone. A reminder post will go live on the dev blog at 4pm UTC/9am
> > Pacific about the 24-hour has-patch marathon that's happening
> > today/tomorrow, but I thought I'd drop a note in here as well. Since the
> key
> > to the marathon resulting in a lot of commits today/tonight is having
> > patches tested before the core devs get to them, this event is really
> about
> > you guys. Yes, people are encouraged to submit patches during the
> marathon,
> > but the real need is testing. There are almost 200 patches sitting in
> Trac
> > waiting to be evaluated, and most of them need testing. If you can take
> some
> > time today to test a few, that would be great. Here are the tickets with
> > patches:
> >
> >
> >
> http://core.trac.wordpress.org/query?status=assigned&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&milestone=2.8&keywords=
> > ~has-patch
> >
> > And if anyone plans to stay up and actually test patches for a full 24
> > hours, let me know. If you're blogging/twittering about it throughout the
> > marathon (saying what tickets you're currently testing or whatever), we
> > might point to you as an example from the WordPress twitter account.
> >
> > When I put up the results of the marathon on the dev blog on Monday, I'll
> > also link to the top 5 testers from the 24-hour marathon period (measured
> by
> > number of patches tested/commented in trac treads).
> >
> > Thanks!
> > Jane
> > _______________________________________________
> > wp-testers mailing list
> > wp-testers@lists.automattic.com
> > http://lists.automattic.com/mailman/listinfo/wp-testers
> >
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From prodevstudio at gmail.com  Thu Apr 16 17:20:54 2009
From: prodevstudio at gmail.com (ProDevStudio)
Date: Thu Apr 16 17:21:26 2009
Subject: [wp-testers] 24-hour has-patch marathon
In-Reply-To: <b066747d0904161012y365da078j1832c8f051322ba2@mail.gmail.com>
References: <20090416084720.C6674672E@comox.textdrive.com> 
	<63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
	<d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com> 
	<b066747d0904161012y365da078j1832c8f051322ba2@mail.gmail.com>
Message-ID: <d9ef2a8f0904161020i1982820bk2505b29a8c155fae@mail.gmail.com>

Thanks Matt,

-> to Tim I know my way around Trac! and got to the has-patch page before
even writing the email.

I was just pointing out limit on Gmail! so that everyone is aware of it.

Should have just created the tiny url then posted it back!


On Thu, Apr 16, 2009 at 6:12 PM, Tim and Farah Jones <spockers@gmail.com>wrote:

> Maybe the link is an I.Q. test -- anyone capable of testing patches should
> be able to figure out the link, LOL.
>
> On Thu, Apr 16, 2009 at 1:02 PM, ProDevStudio <prodevstudio@gmail.com
> >wrote:
>
> > Hi Jane,
> >
> > Interesting but that link is broken in Gmail. the "~has-patch" part does
> > not
> > get linked... might want to use a shorter link next time.
> >
> > Will try testing some...
> >
> > Regards,
> >
> > Azizur Rahman
> > ProDevStudio
> >
> > Do you need cost effective web hosting solution and Domain name try
> > http://prodevstudio.com
> >
> > Do you need a new web site try http://cgandc.net
> >
> > Missed the last Friday Khutbah, try catchup a Khutbah on-line now at
> > http://fridaykhutbah.com
> >
> >
> > On Thu, Apr 16, 2009 at 12:32 PM, Jane Wells <jane@automattic.com>
> wrote:
> >
> > > Hi everyone. A reminder post will go live on the dev blog at 4pm
> UTC/9am
> > > Pacific about the 24-hour has-patch marathon that's happening
> > > today/tomorrow, but I thought I'd drop a note in here as well. Since
> the
> > key
> > > to the marathon resulting in a lot of commits today/tonight is having
> > > patches tested before the core devs get to them, this event is really
> > about
> > > you guys. Yes, people are encouraged to submit patches during the
> > marathon,
> > > but the real need is testing. There are almost 200 patches sitting in
> > Trac
> > > waiting to be evaluated, and most of them need testing. If you can take
> > some
> > > time today to test a few, that would be great. Here are the tickets
> with
> > > patches:
> > >
> > >
> > >
> >
> http://core.trac.wordpress.org/query?status=assigned&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&milestone=2.8&keywords=
> > > ~has-patch
> > >
> > > And if anyone plans to stay up and actually test patches for a full 24
> > > hours, let me know. If you're blogging/twittering about it throughout
> the
> > > marathon (saying what tickets you're currently testing or whatever), we
> > > might point to you as an example from the WordPress twitter account.
> > >
> > > When I put up the results of the marathon on the dev blog on Monday,
> I'll
> > > also link to the top 5 testers from the 24-hour marathon period
> (measured
> > by
> > > number of patches tested/commented in trac treads).
> > >
> > > Thanks!
> > > Jane
> > > _______________________________________________
> > > wp-testers mailing list
> > > wp-testers@lists.automattic.com
> > > http://lists.automattic.com/mailman/listinfo/wp-testers
> > >
> > _______________________________________________
> > wp-testers mailing list
> > wp-testers@lists.automattic.com
> > http://lists.automattic.com/mailman/listinfo/wp-testers
> >
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From bryanharley at gmail.com  Thu Apr 16 17:36:02 2009
From: bryanharley at gmail.com (Bryan Harley)
Date: Thu Apr 16 17:36:21 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz> <49E6DF89.7090006@laptoptips.ca>
	<c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>
Message-ID: <58410e2e0904161036t6620860dre9e7c018d4b8e9b3@mail.gmail.com>

Looks great!!!  We can finally drag widgets in between sidebars easily and
efficiently again!  Thank you.


On Thu, Apr 16, 2009 at 2:14 AM, Paleo Pat <tpblogeditor@gmail.com> wrote:

> All works here... so far, there's an error, believe me, you'll know about
> it. ;-P
>
> (warning the following might have wordy derd or two, or as it is commonly
> known as, a swear word or two in it...)
>
> In an sorta related, and sorta not item. I have hosting with site5.com.
> They're doing server upgrades, and anyways, I did the update to the latest
> build and I notice the new widget layout. Anyways, I wanted to add a little
> square banner to my Blog, and so, I went and snagged the code, and was
> going
> to add it to a preexisting widget. So, I pasted said code and hit save and
> I
> see the swirl, going around and around and around... and I'm thinking
> "Uh-oh...." and I hit refresh, and sure enough, dead flippin' server, no
> response, I let out a very long drawn out "ooooohhh Fuuuuuuck....." and
> went
> over to tech support and started the process of finding out what exactly
> happened, and what I broke.
>
> Well, believe it or not, It wasn't me. They were doing server upgrades an
> guess who's got done first... Mine. When the support tech guy told me that,
> I nearly died laughing, I would have loved to been the fly on the wall
> during that tech support meeting! "Yeah, let's do the server that the
> asshole political blogger is on FIRST, he's very picky and the minute the
> server goes down, he is on us like a mad man!" LOL! Anyhow, the server was
> back up in like 5 minutes. I was able to add my code without any trouble at
> all.
>
> It might not be as funny to you guys, but for me, it was the best laugh I'd
> had in a while. You know you're important when they upgrade your server
> first! LOL!
>
> -Paleo Pat
> http://www.politicalbyline.com
>
>
>
>
> On Thu, Apr 16, 2009 at 3:34 AM, Andrew Ozz <admin@laptoptips.ca> wrote:
>
> > Does everything on the widgets page work as expected? Anything that feels
> > awkward/hard to use? Any widgets that fail to save or bring js errors?
> >
> > It's all AJAX-ified and all sidebars (including the Available Widgets
> area)
> > can be folded to make it easier to use on smaller screens. The Inactive
> > Widgets area is for storing widgets that are configured but not in any
> > sidebar at the moment. Also when changing themes if the new theme has
> less
> > sidebars than the old one, all widgets from the extra sidebar(s) are
> moved
> > to Inactive.
> >
> > Dan Milward wrote:
> >
> >> I agree it looks very nice.
> >>
> >
> > The look isn't fully completed yet. Hopefully it will look even nicer :)
> >
> >  Does anybody know if a more advanced widget management is coming for
> >> 2.8 launch? We'd like to contribute code to that - we reckon it is
> >> important to specify which pages/posts widgets display on... kinda
> >> like slayers but with better UI :P
> >>
> >
> > Don't think there will be any significant feature changes any more. We
> are
> > getting close to first beta for 2.8, not enough time left. Also the
> code/API
> > has to stay backwards compatible.
> >
> > Will probably revisit widgets for 2.9 when (hopefully) all widgets will
> be
> > using the new multi-widget class so we can streamline the API functions
> and
> > add features without breaking compatibility.
> >
> > On the other hand if you need more hooks, choose a good place that won't
> > limit future changes and open a ticket. In the worst case it will be left
> > for 2.9.
> >
> >
> > _______________________________________________
> > wp-testers mailing list
> > wp-testers@lists.automattic.com
> > http://lists.automattic.com/mailman/listinfo/wp-testers
> >
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From bryanharley at gmail.com  Thu Apr 16 17:37:24 2009
From: bryanharley at gmail.com (Bryan Harley)
Date: Thu Apr 16 17:37:39 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <58410e2e0904161036t6620860dre9e7c018d4b8e9b3@mail.gmail.com>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz> <49E6DF89.7090006@laptoptips.ca>
	<c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>
	<58410e2e0904161036t6620860dre9e7c018d4b8e9b3@mail.gmail.com>
Message-ID: <58410e2e0904161037h5dc74041k9c13341159aba02d@mail.gmail.com>

One thing I would recommend is that the "Widgets" page finally become a
top-level navigation item, like it should be.  Widgets are definitely on the
same level as Posts, Pages, Comments, etc.  Widgets contain vital pieces of
blog/web site data.


On Thu, Apr 16, 2009 at 10:36 AM, Bryan Harley <bryanharley@gmail.com>wrote:

> Looks great!!!  We can finally drag widgets in between sidebars easily and
> efficiently again!  Thank you.
>
>
>
> On Thu, Apr 16, 2009 at 2:14 AM, Paleo Pat <tpblogeditor@gmail.com> wrote:
>
>> All works here... so far, there's an error, believe me, you'll know about
>> it. ;-P
>>
>> (warning the following might have wordy derd or two, or as it is commonly
>> known as, a swear word or two in it...)
>>
>> In an sorta related, and sorta not item. I have hosting with site5.com.
>> They're doing server upgrades, and anyways, I did the update to the latest
>> build and I notice the new widget layout. Anyways, I wanted to add a
>> little
>> square banner to my Blog, and so, I went and snagged the code, and was
>> going
>> to add it to a preexisting widget. So, I pasted said code and hit save and
>> I
>> see the swirl, going around and around and around... and I'm thinking
>> "Uh-oh...." and I hit refresh, and sure enough, dead flippin' server, no
>> response, I let out a very long drawn out "ooooohhh Fuuuuuuck....." and
>> went
>> over to tech support and started the process of finding out what exactly
>> happened, and what I broke.
>>
>> Well, believe it or not, It wasn't me. They were doing server upgrades an
>> guess who's got done first... Mine. When the support tech guy told me
>> that,
>> I nearly died laughing, I would have loved to been the fly on the wall
>> during that tech support meeting! "Yeah, let's do the server that the
>> asshole political blogger is on FIRST, he's very picky and the minute the
>> server goes down, he is on us like a mad man!" LOL! Anyhow, the server was
>> back up in like 5 minutes. I was able to add my code without any trouble
>> at
>> all.
>>
>> It might not be as funny to you guys, but for me, it was the best laugh
>> I'd
>> had in a while. You know you're important when they upgrade your server
>> first! LOL!
>>
>> -Paleo Pat
>> http://www.politicalbyline.com
>>
>>
>>
>>
>> On Thu, Apr 16, 2009 at 3:34 AM, Andrew Ozz <admin@laptoptips.ca> wrote:
>>
>> > Does everything on the widgets page work as expected? Anything that
>> feels
>> > awkward/hard to use? Any widgets that fail to save or bring js errors?
>> >
>> > It's all AJAX-ified and all sidebars (including the Available Widgets
>> area)
>> > can be folded to make it easier to use on smaller screens. The Inactive
>> > Widgets area is for storing widgets that are configured but not in any
>> > sidebar at the moment. Also when changing themes if the new theme has
>> less
>> > sidebars than the old one, all widgets from the extra sidebar(s) are
>> moved
>> > to Inactive.
>> >
>> > Dan Milward wrote:
>> >
>> >> I agree it looks very nice.
>> >>
>> >
>> > The look isn't fully completed yet. Hopefully it will look even nicer :)
>> >
>> >  Does anybody know if a more advanced widget management is coming for
>> >> 2.8 launch? We'd like to contribute code to that - we reckon it is
>> >> important to specify which pages/posts widgets display on... kinda
>> >> like slayers but with better UI :P
>> >>
>> >
>> > Don't think there will be any significant feature changes any more. We
>> are
>> > getting close to first beta for 2.8, not enough time left. Also the
>> code/API
>> > has to stay backwards compatible.
>> >
>> > Will probably revisit widgets for 2.9 when (hopefully) all widgets will
>> be
>> > using the new multi-widget class so we can streamline the API functions
>> and
>> > add features without breaking compatibility.
>> >
>> > On the other hand if you need more hooks, choose a good place that won't
>> > limit future changes and open a ticket. In the worst case it will be
>> left
>> > for 2.9.
>> >
>> >
>> > _______________________________________________
>> > wp-testers mailing list
>> > wp-testers@lists.automattic.com
>> > http://lists.automattic.com/mailman/listinfo/wp-testers
>> >
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>
>
From ryan at boren.nu  Thu Apr 16 17:40:43 2009
From: ryan at boren.nu (Ryan Boren)
Date: Thu Apr 16 17:41:17 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <58410e2e0904161037h5dc74041k9c13341159aba02d@mail.gmail.com>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz> <49E6DF89.7090006@laptoptips.ca>
	<c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>
	<58410e2e0904161036t6620860dre9e7c018d4b8e9b3@mail.gmail.com>
	<58410e2e0904161037h5dc74041k9c13341159aba02d@mail.gmail.com>
Message-ID: <c8f37c930904161040l3c6dbfe9lba8b78aa3bd8a177@mail.gmail.com>

On Thu, Apr 16, 2009 at 10:37 AM, Bryan Harley <bryanharley@gmail.com> wrote:
> One thing I would recommend is that the "Widgets" page finally become a
> top-level navigation item, like it should be. ?Widgets are definitely on the
> same level as Posts, Pages, Comments, etc. ?Widgets contain vital pieces of
> blog/web site data.

We're going to look at that as well as some other menu tweaks for 2.9.
 We'll mockup different arrangements and do some more polls.
From wp-hackers at striderweb.com  Thu Apr 16 18:54:08 2009
From: wp-hackers at striderweb.com (Stephen Rider)
Date: Thu Apr 16 18:54:49 2009
Subject: [wp-testers] URLs in email (was: 24-hour has-patch marathon)
In-Reply-To: <d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
References: <20090416084720.C6674672E@comox.textdrive.com>
	<63895CD4-6C02-4252-ABE5-4E39700BEA87@automattic.com>
	<d9ef2a8f0904161002i6ae3ecbcn657b61d803fca16@mail.gmail.com>
Message-ID: <92DB9B90-048F-4472-ABD7-9BDAE6BFDBE3@striderweb.com>

On Apr 16, 2009, at 12:02 PM, ProDevStudio wrote:

> Interesting but that link is broken in Gmail. the "~has-patch" part  
> does not
> get linked... might want to use a shorter link next time.


I posted this to Jane privately, but since it's been brought up....

For future reference, if you want to make a more email-compatible URL  
-- especially a very long one -- put it inside angle brackets, like so:

<http://core.trac.wordpress.org/query?status=assigned&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&milestone=2.8&keywords=~has-patch 
 >

This is a standard as old as email itself, and is pretty universally  
understood by email clients.

Without the brackets, some email clients don't know to make that URL  
clickable, and when they do make it clickable, some don't know quite  
where the URL ends.  For instance, in Apple's "Mail" app, [and  
apparently in GMail], I can click on the URL, but it doesn't know to  
include past the tilde at the end, so the "~has-patch" bit is left  
off.  Kind of important, that.  ;-)

Stephen


-- 
Stephen Rider
http://striderweb.com/




From wp-hackers at striderweb.com  Thu Apr 16 18:49:25 2009
From: wp-hackers at striderweb.com (Stephen Rider)
Date: Thu Apr 16 19:15:15 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <58410e2e0904161037h5dc74041k9c13341159aba02d@mail.gmail.com>
References: <c3a04f3c0904152254m3f576e66la7392e9dbdf399cc@mail.gmail.com>
	<2F7A5C201057467EB54E3274F54D47AF@wpww>
	<9cc937bf0904152330x7bcdb941m790fc7f088b564c2@mail.gmail.com>
	<49E6D326.8000507@instinct.co.nz> <49E6DF89.7090006@laptoptips.ca>
	<c3a04f3c0904160214h5cea92d7o571e9ef757a04854@mail.gmail.com>
	<58410e2e0904161036t6620860dre9e7c018d4b8e9b3@mail.gmail.com>
	<58410e2e0904161037h5dc74041k9c13341159aba02d@mail.gmail.com>
Message-ID: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com>

-1 on that.

Widgets are part of the site design, and are entirely appropriate  
under the Design menu; whereas a Post, Page, or Comment is a specific  
piece of content.

On Apr 16, 2009, at 12:37 PM, Bryan Harley wrote:

> One thing I would recommend is that the "Widgets" page finally  
> become a
> top-level navigation item, like it should be.  Widgets are  
> definitely on the
> same level as Posts, Pages, Comments, etc.  Widgets contain vital  
> pieces of
> blog/web site data.

From gp at iampearce.com  Thu Apr 16 19:18:31 2009
From: gp at iampearce.com (George Pearce)
Date: Thu Apr 16 19:19:11 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com>
Message-ID: <49e7849e.0405560a.0ea8.fffff48d@mx.google.com>

I agree with Stephen. They aren't used enough to warrant their own top level
navigation - for most, widgets are rarely changed; are they not?
 
-----Original Message-----
From: wp-testers-bounces@lists.automattic.com
[mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Stephen Rider
Sent: 16 April 2009 19:49
To: wp-testers@lists.automattic.com
Subject: Re: [wp-testers] Widgets in 2.8 Bleeding...

-1 on that.

Widgets are part of the site design, and are entirely appropriate  
under the Design menu; whereas a Post, Page, or Comment is a specific  
piece of content.

On Apr 16, 2009, at 12:37 PM, Bryan Harley wrote:

> One thing I would recommend is that the "Widgets" page finally  
> become a
> top-level navigation item, like it should be.  Widgets are  
> definitely on the
> same level as Posts, Pages, Comments, etc.  Widgets contain vital  
> pieces of
> blog/web site data.

_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

From tpblogeditor at gmail.com  Thu Apr 16 19:21:19 2009
From: tpblogeditor at gmail.com (Paleo Pat)
Date: Thu Apr 16 19:21:33 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <49e7849e.0405560a.0ea8.fffff48d@mx.google.com>
References: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com>
	<49e7849e.0405560a.0ea8.fffff48d@mx.google.com>
Message-ID: <c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com>

Depends on the Blog. I'm always add, removing and changing stuff around. So,
I vote in favor of it. :)




On Thu, Apr 16, 2009 at 3:18 PM, George Pearce <gp@iampearce.com> wrote:

> I agree with Stephen. They aren't used enough to warrant their own top
> level
> navigation - for most, widgets are rarely changed; are they not?
>
> -----Original Message-----
> From: wp-testers-bounces@lists.automattic.com
> [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Stephen
> Rider
> Sent: 16 April 2009 19:49
> To: wp-testers@lists.automattic.com
> Subject: Re: [wp-testers] Widgets in 2.8 Bleeding...
>
> -1 on that.
>
> Widgets are part of the site design, and are entirely appropriate
> under the Design menu; whereas a Post, Page, or Comment is a specific
> piece of content.
>
> On Apr 16, 2009, at 12:37 PM, Bryan Harley wrote:
>
> > One thing I would recommend is that the "Widgets" page finally
> > become a
> > top-level navigation item, like it should be.  Widgets are
> > definitely on the
> > same level as Posts, Pages, Comments, etc.  Widgets contain vital
> > pieces of
> > blog/web site data.
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From Jesse.Silverstein at xerox.com  Thu Apr 16 19:28:59 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Thu Apr 16 19:30:11 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com>
References: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com><49e7849e.0405560a.0ea8.fffff48d@mx.google.com>
	<c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com>
Message-ID: <F25F2C8DE17FB546A90DB3CF7746142706400D30@USA0300MS04.na.xerox.net>

I don't think Widgets should have top-level navigation globally. They are fundamentally part of Design. I do think it would be fairly simple to write a plugin that moves the Widgets link out of the Design menu so those who want it can have Widgets be top-level.

-----Original Message-----
From: wp-testers-bounces@lists.automattic.com [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Paleo Pat
Sent: Thursday, April 16, 2009 3:21 PM
To: wp-testers@lists.automattic.com
Subject: Re: [wp-testers] Widgets in 2.8 Bleeding...

Depends on the Blog. I'm always add, removing and changing stuff around. So,
I vote in favor of it. :)




On Thu, Apr 16, 2009 at 3:18 PM, George Pearce <gp@iampearce.com> wrote:

> I agree with Stephen. They aren't used enough to warrant their own top
> level
> navigation - for most, widgets are rarely changed; are they not?
>
> -----Original Message-----
> From: wp-testers-bounces@lists.automattic.com
> [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Stephen
> Rider
> Sent: 16 April 2009 19:49
> To: wp-testers@lists.automattic.com
> Subject: Re: [wp-testers] Widgets in 2.8 Bleeding...
>
> -1 on that.
>
> Widgets are part of the site design, and are entirely appropriate
> under the Design menu; whereas a Post, Page, or Comment is a specific
> piece of content.
>
> On Apr 16, 2009, at 12:37 PM, Bryan Harley wrote:
>
> > One thing I would recommend is that the "Widgets" page finally
> > become a
> > top-level navigation item, like it should be.  Widgets are
> > definitely on the
> > same level as Posts, Pages, Comments, etc.  Widgets contain vital
> > pieces of
> > blog/web site data.
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.11.58/2061 - Release Date: 04/16/09 08:12:00
From dougal at gunters.org  Thu Apr 16 20:15:05 2009
From: dougal at gunters.org (Dougal Campbell)
Date: Thu Apr 16 20:15:35 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <F25F2C8DE17FB546A90DB3CF7746142706400D30@USA0300MS04.na.xerox.net>
References: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com><49e7849e.0405560a.0ea8.fffff48d@mx.google.com>	<c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com>
	<F25F2C8DE17FB546A90DB3CF7746142706400D30@USA0300MS04.na.xerox.net>
Message-ID: <49E791C9.6030804@gunters.org>

Silverstein, Jesse wrote:
> I don't think Widgets should have top-level navigation globally. They are fundamentally part of Design. I do think it would be fairly simple to write a plugin that moves the Widgets link out of the Design menu so those who want it can have Widgets be top-level.
>   

I agree. While I'm sure there are a fair number of people who tweak 
their widgets frequently, I'd be willing to bet that *most* folks don't 
reconfigure their widgets very often. And as Jesse suggets, a plugin to 
move the menu item would be a satisfactory compromise for the former case.

Widgets are conceptually a part of the Design. Especially when you 
consider that some themes come with pre-bundled widgets of their own.

-- 
Dougal Campbell <dougal@gunters.org>
http://dougal.gunters.org/
http://twitter.com/dougal
http://twitual.com/
*
*
From pablorobinson at gmail.com  Thu Apr 16 21:30:32 2009
From: pablorobinson at gmail.com (Paul Robinson)
Date: Thu Apr 16 21:31:01 2009
Subject: [wp-testers] **Maybe OT** White Screen In 2.8
Message-ID: <1931c86d0904161430q411bada1m5d03860a92770b87@mail.gmail.com>

Hi,

I've just done something really stupid. I have just mistakenly uploaded my
test (2.8) version.php over a 2.7.1 install when uploading something, I
didn't realize & hit update (because it said keep up to date) not realizing
it meant keep up to date with 2.8 development version & it got stuck at
updating database & now I get a white screen no matter where I visit. I do
have backups just in case, but I'm just wondering if anyone has any clues as
to what has happened.

Also a lession for you kids out there, read everything really carefully.
**DOH**

Paul *Feeling Really Stupid*.
From pablorobinson at gmail.com  Thu Apr 16 21:36:37 2009
From: pablorobinson at gmail.com (Paul Robinson)
Date: Thu Apr 16 21:38:12 2009
Subject: [wp-testers] Re: **Maybe OT** White Screen In 2.8
In-Reply-To: <1931c86d0904161430q411bada1m5d03860a92770b87@mail.gmail.com>
References: <1931c86d0904161430q411bada1m5d03860a92770b87@mail.gmail.com>
Message-ID: <1931c86d0904161436n78cee599ofa2ec595d14b1917@mail.gmail.com>

Actually I've just noticed some of the problem was Firefox caching. The
front end of the blog is fine & visible to all, it's just the admin section.
If I try to visit wp-login.php or the admin it shows a white screen.

2009/4/16 Paul Robinson <pablorobinson@gmail.com>

> Hi,
>
> I've just done something really stupid. I have just mistakenly uploaded my
> test (2.8) version.php over a 2.7.1 install when uploading something, I
> didn't realize & hit update (because it said keep up to date) not realizing
> it meant keep up to date with 2.8 development version & it got stuck at
> updating database & now I get a white screen no matter where I visit. I do
> have backups just in case, but I'm just wondering if anyone has any clues as
> to what has happened.
>
> Also a lession for you kids out there, read everything really carefully.
> **DOH**
>
> Paul *Feeling Really Stupid*.
>
From hempsworth at googlemail.com  Fri Apr 17 09:25:55 2009
From: hempsworth at googlemail.com (Alex Hempton-Smith)
Date: Fri Apr 17 09:26:22 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <49E791C9.6030804@gunters.org>
References: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com> 
	<49e7849e.0405560a.0ea8.fffff48d@mx.google.com>
	<c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com> 
	<F25F2C8DE17FB546A90DB3CF7746142706400D30@USA0300MS04.na.xerox.net> 
	<49E791C9.6030804@gunters.org>
Message-ID: <5a1dad880904170225y9b7180jefa2d6f7c155f3a5@mail.gmail.com>

Just out of interest, and OT for this thread, but is there currently a way
(plugin), for admins to drag and drop menu items around to re-order them?
With AJAX saving of the positions of course.
If this were created we could customise the admin menu as much as we liked,
and even drag items out of their parent groups and make them top-level as
discussed here.

Just an idea, perhaps for a plugin, or even an enhancement for 2.9?

-- Alex
From wordpress at dd32.id.au  Fri Apr 17 14:35:13 2009
From: wordpress at dd32.id.au (DD32)
Date: Fri Apr 17 14:35:41 2009
Subject: [wp-testers] [Testers Wanted] SSH2 Support
Message-ID: <op.usjb4zhfk6w4mc@dd32.no-ip.com>

Morning/Afternoon/Evening All,

If WordPress supporting SSH2 for upgrades is news to you, Or you use shared hosting, You can probably stop reading now.

Since the SSH2 layer was introduced, There's been a few long standing issues, Unreliability, non-connecting, failing with obscure results, Failing with certain filenames, among others.

If in the past you've attempted to use it on your VPS or Dedicated server, Now is probably a time to give it another shot (Please: Create a separate user account for the testing! - You have absolutely no excuse!)

If you need some instructions on how to install the PHP SSH2 Extension, Then its actually relatively easy if you have command line experience.
On some installs, mearly running 'pecl install ssh2' will work, on others, a bit more is needed
The header of the SSH2 file has some info: http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-filesystem-ssh2.php#L9 - Its not the best, i agree, but its better than nothing, Combined with manual compile notes: http://iparrizar.mnstate.edu/~juan/urania/2008/12/11/activating-ssh-support-in-macports-php/ hopefully most can work it out. 

Now, Once your server is actually up and running with SSH2, Its time to actually test the stuff.
If it hasnt already been commited by the time you read this, you'll need to apply this Diff patch: http://core.trac.wordpress.org/ticket/8210#comment:7 (Once again, I'm going to assume you know how to do this stuff..)

I'd appreciate reports of whats working, whats not working, with regards to the SSH2 layer

Yes, I know a lot of you on this list are not full-on-technical people, But thats OK, Theres some techies out there who'll want to tinker over the weekend :)

Cheers,
Dion
From wordpress at dd32.id.au  Fri Apr 17 14:51:14 2009
From: wordpress at dd32.id.au (DD32)
Date: Fri Apr 17 14:51:38 2009
Subject: [wp-testers] [Testers Wanted] Plugin/Theme Installs/Upgrades
Message-ID: <op.usjcvoe7k6w4mc@dd32.no-ip.com>

If you dont have a Test environment setup that can handle FTP, then you might as well stop reading now, since this isnt going to affect you much right now

http://core.trac.wordpress.org/ticket/7875#comment:25
For a long time i've been meaning to combine the ever-growing list of code blocks in WP which manipulate the filesystem, There were 7 copies of near-identical code consisting of ~120lines each previously.. Not very elegant, and if a bug was found in one place, it'd have to be patched in multiple places.

The result was me finally rewriting the code to be a bit more robust. And we're now looking at a 100kb Diff..

I need people to test it.

Its as simple as that, I need those with a development environment, or testing environment, with non-critical data/live data that they can do some testing with to locate any bad bugs - I've not found any recently, I did destroy quite a few things whilst writing the code though..

This time, I'd rather not have it commited, and then (Master) Matt turn around and mention that it deleted all his plugins.. :).

So, If you've got a -second- ftp account separate from your main WP installs (Just so it cant get confused and mess up something it shouldnt!), then please do give the changes a whirl, and report back on what works/doesnt work.

The Diff in question is this one: http://core.trac.wordpress.org/attachment/ticket/7875/7875.6.diff (Please do check for a later patch on that ticket though..)

Comments either Here, or on that ticket, If posted here, I'll just link to the thread from the ticket in the morning


Cheers,
Dion
From bryanharley at gmail.com  Fri Apr 17 17:37:35 2009
From: bryanharley at gmail.com (Bryan Harley)
Date: Fri Apr 17 17:37:49 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
In-Reply-To: <5a1dad880904170225y9b7180jefa2d6f7c155f3a5@mail.gmail.com>
References: <9CF7F916-3E3D-43F6-938A-0366CC4D88A9@striderweb.com>
	<49e7849e.0405560a.0ea8.fffff48d@mx.google.com>
	<c3a04f3c0904161221h7ab12652h95ee8d2c0583dc3d@mail.gmail.com>
	<F25F2C8DE17FB546A90DB3CF7746142706400D30@USA0300MS04.na.xerox.net>
	<49E791C9.6030804@gunters.org>
	<5a1dad880904170225y9b7180jefa2d6f7c155f3a5@mail.gmail.com>
Message-ID: <58410e2e0904171037g61eeab9cy6839c91a42b3ff38@mail.gmail.com>

Alex,

There's already a great plugin for this called Admin Menu Editor. It's a bit
more complex that what you describe, but it has a lot more features as
well.  http://w-shadow.com/blog/2008/12/20/admin-menu-editor-for-wordpress/

Good idea for core though.

-Bryan

On Fri, Apr 17, 2009 at 2:25 AM, Alex Hempton-Smith <
hempsworth@googlemail.com> wrote:

> Just out of interest, and OT for this thread, but is there currently a way
> (plugin), for admins to drag and drop menu items around to re-order them?
> With AJAX saving of the positions of course.
> If this were created we could customise the admin menu as much as we liked,
> and even drag items out of their parent groups and make them top-level as
> discussed here.
>
> Just an idea, perhaps for a plugin, or even an enhancement for 2.9?
>
> -- Alex
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From jeffro at jeffro2pt0.com  Fri Apr 17 20:00:13 2009
From: jeffro at jeffro2pt0.com (Jeff Chandler)
Date: Fri Apr 17 20:00:29 2009
Subject: [wp-testers] Widgets in 2.8 Bleeding...
Message-ID: <49E8DFCD.9060904@jeffro2pt0.com>

Yep, it's called admin menu editor. It's pretty darn slick but doesn't 
work well on PHP4 based webhosts.

http://w-shadow.com/blog/2008/12/20/admin-menu-editor-for-wordpress/

From blablaplanet at gmail.com  Sat Apr 18 17:53:35 2009
From: blablaplanet at gmail.com (blablaplanet redactie)
Date: Sat Apr 18 17:54:02 2009
Subject: [wp-testers] [Testers Wanted] Plugin/Theme Installs/Upgrades
In-Reply-To: <op.usjcvoe7k6w4mc@dd32.no-ip.com>
References: <op.usjcvoe7k6w4mc@dd32.no-ip.com>
Message-ID: <b0d32e290904181053sfd4958di87662363287003b0@mail.gmail.com>

where can i download a testversion??

2009/4/17 DD32 <wordpress@dd32.id.au>

> If you dont have a Test environment setup that can handle FTP, then you
> might as well stop reading now, since this isnt going to affect you much
> right now
>
> http://core.trac.wordpress.org/ticket/7875#comment:25
> For a long time i've been meaning to combine the ever-growing list of code
> blocks in WP which manipulate the filesystem, There were 7 copies of
> near-identical code consisting of ~120lines each previously.. Not very
> elegant, and if a bug was found in one place, it'd have to be patched in
> multiple places.
>
> The result was me finally rewriting the code to be a bit more robust. And
> we're now looking at a 100kb Diff..
>
> I need people to test it.
>
> Its as simple as that, I need those with a development environment, or
> testing environment, with non-critical data/live data that they can do some
> testing with to locate any bad bugs - I've not found any recently, I did
> destroy quite a few things whilst writing the code though..
>
> This time, I'd rather not have it commited, and then (Master) Matt turn
> around and mention that it deleted all his plugins.. :).
>
> So, If you've got a -second- ftp account separate from your main WP
> installs (Just so it cant get confused and mess up something it shouldnt!),
> then please do give the changes a whirl, and report back on what
> works/doesnt work.
>
> The Diff in question is this one:
> http://core.trac.wordpress.org/attachment/ticket/7875/7875.6.diff (Please
> do check for a later patch on that ticket though..)
>
> Comments either Here, or on that ticket, If posted here, I'll just link to
> the thread from the ticket in the morning
>
>
> Cheers,
> Dion
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From scribu at gmail.com  Sat Apr 18 18:07:19 2009
From: scribu at gmail.com (scribu)
Date: Sat Apr 18 18:07:34 2009
Subject: [wp-testers] [Testers Wanted] Plugin/Theme Installs/Upgrades
In-Reply-To: <b0d32e290904181053sfd4958di87662363287003b0@mail.gmail.com>
References: <op.usjcvoe7k6w4mc@dd32.no-ip.com>
	<b0d32e290904181053sfd4958di87662363287003b0@mail.gmail.com>
Message-ID: <349fe48b0904181107ua64f368u403a3053371bff0d@mail.gmail.com>

You have to use svn to download trunk then apply the patch. See
http://wordpress.org/download/svn/

On Sat, Apr 18, 2009 at 8:53 PM, blablaplanet redactie <
blablaplanet@gmail.com> wrote:

> where can i download a testversion??
>

-- 
http://scribu.net
From otto at ottodestruct.com  Sun Apr 19 15:10:26 2009
From: otto at ottodestruct.com (Otto)
Date: Sun Apr 19 15:10:58 2009
Subject: [wp-testers] [Testers Wanted] Plugin/Theme Installs/Upgrades
In-Reply-To: <349fe48b0904181107ua64f368u403a3053371bff0d@mail.gmail.com>
References: <op.usjcvoe7k6w4mc@dd32.no-ip.com>
	<b0d32e290904181053sfd4958di87662363287003b0@mail.gmail.com> 
	<349fe48b0904181107ua64f368u403a3053371bff0d@mail.gmail.com>
Message-ID: <161617690904190810p35ed2e54gfa2fe68a584d3e5f@mail.gmail.com>

The latest nightly can also be found here:
http://wordpress.org/nightly-builds/wordpress-latest.zip

-Otto
Sent from Memphis, Tennessee, United States


On Sat, Apr 18, 2009 at 1:07 PM, scribu <scribu@gmail.com> wrote:
> You have to use svn to download trunk then apply the patch. See
> http://wordpress.org/download/svn/
>
> On Sat, Apr 18, 2009 at 8:53 PM, blablaplanet redactie <
> blablaplanet@gmail.com> wrote:
>
>> where can i download a testversion??
>>
>
> --
> http://scribu.net
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From sloveman at us.edu  Sun Apr 19 15:58:07 2009
From: sloveman at us.edu (Loveman Sherrie)
Date: Sun Apr 19 15:58:29 2009
Subject: [wp-testers] unsubscribe
Message-ID: <E25A3BAB8793FB41967507FEBEB538D002D2DA45@exchange2.us.local>

 

From dan at instinct.co.nz  Thu Apr 23 22:43:01 2009
From: dan at instinct.co.nz (Dan Milward)
Date: Thu Apr 23 23:11:49 2009
Subject: [wp-testers] Hook for editing posts / pages AND text Widgets
In-Reply-To: <349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>	<49E6C3DB.1080903@instinct.co.nz>
	<349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
Message-ID: <49F0EEF5.3030709@instinct.co.nz>

I just got a crazy request from somebody asking if we could make 
something like http://www.crunchbase.com/company/flickr  using WordPress.

Scribu's Plugin [http://scribu.net/wordpress/front-end-editor] has the 
inline editing sorted for pages and posts. What are the chances of 
adding a hook to Text Widgets in 2.8 so that they too are editable 
inline using something like front-end-editor.

It might already be possible - it all goes towards making WordPress much 
more customizable and easy for noob users (like my Mum) what do you guys 
think?

Best,
Dan

From scribu at gmail.com  Thu Apr 23 23:21:17 2009
From: scribu at gmail.com (scribu)
Date: Thu Apr 23 23:21:33 2009
Subject: [wp-testers] Hook for editing posts / pages AND text Widgets
In-Reply-To: <49F0EEF5.3030709@instinct.co.nz>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>
	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>
	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>
	<49E6C3DB.1080903@instinct.co.nz>
	<349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>
	<49F0EEF5.3030709@instinct.co.nz>
Message-ID: <349fe48b0904231621h708d3856tb9793cdb81c52abc@mail.gmail.com>

My plugin already makes text widgets editable!

You're the second user that fails to notice that. I'm starting to wonder if
the plugin page is clear enough:

http://wordpress.org/extend/plugins/front-end-editor/


-- 
http://scribu.net
From dan at instinct.co.nz  Thu Apr 23 23:44:46 2009
From: dan at instinct.co.nz (Dan Milward)
Date: Thu Apr 23 23:45:05 2009
Subject: [wp-testers] Hook for editing posts / pages AND text Widgets
In-Reply-To: <349fe48b0904231621h708d3856tb9793cdb81c52abc@mail.gmail.com>
References: <c8f37c930904141004y3aefbca5m6ef29d3ded51437c@mail.gmail.com>	<C8EC2088-8777-4AED-A652-9AF6952C9996@instinct.co.nz>	<EF1DAED7-05E1-4C2D-94D3-12C6F688FAA4@gmail.com>	<49E6C3DB.1080903@instinct.co.nz>	<349fe48b0904152355y1526fb59v24069e4dcda9996c@mail.gmail.com>	<49F0EEF5.3030709@instinct.co.nz>
	<349fe48b0904231621h708d3856tb9793cdb81c52abc@mail.gmail.com>
Message-ID: <49F0FD6E.7070503@instinct.co.nz>

LOL. Now I feel like a total jack ass!!!

I'll take a look at this  :)

Best,
Dan

scribu wrote:
> My plugin already makes text widgets editable!
>
> You're the second user that fails to notice that. I'm starting to wonder if
> the plugin page is clear enough:
>
> http://wordpress.org/extend/plugins/front-end-editor/
>
>
>   
From jane at automattic.com  Sat Apr 25 17:11:56 2009
From: jane at automattic.com (Jane Wells)
Date: Sat Apr 25 17:12:15 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <20090415120028.2110D6B95@comox.textdrive.com>
References: <20090415120028.2110D6B95@comox.textdrive.com>
Message-ID: <54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>

I'm saying this flat out: this announcement is coming with no notice.  
There's a post on the dev blog now about an opportunity for community  
designers to take a stab at making the header/nav of the admin look a  
little more polished. The idea only came up last night, and with the  
2.8 deadline looming, it would have made more sense to just have Matt  
Thomas (who did the visual styling of 2.7) kick out a revised comp,  
but we thought it would be cool to let the community submit design  
suggestions in visual form. We posted a PSD of Matt's, and anyone who  
would like to propose an approach is welcome to submit a design.

Since it's a small project, we think this is reasonable. Matt Thomas  
is working on a comp, so if no one wants to jump in and take on the  
challenge, that's okay. Like I said, the idea just came up... we  
didn't think we'd have time for this kind of thing until 2.9. In 2.9,  
there will be some screen design opportunities around the media upload  
process, and those larger design projects will be announced a week in  
advance, and have reasonable turnaround times for deliverables. But  
not this time! We're trying to squeeze this in under the wire. All  
details are in the post: http://wordpress.org/development/2009/04/design-tweaks-whos-in-an-idea-in-three-acts/

Slightly but not really off topic: I do want to say that I paid close  
attention to the thread about the has-patch marathon and the two-days'  
notice not being enough. I started to write a lengthy response, but  
decided it would be better to turn that energy toward making change,  
rather than responding point by point to the complaint. I'm going to  
start working on figuring out how to improve communication between  
core devs/contributing devs/Automattic, which will include things like  
the Ideas forum, the lists, the dev channel, support forums, community  
blogs, etc. I'm gathering my thoughts right now and trying to get 2.8  
out of the way, but in the very near future I'll start soliciting  
feedback around this issue, and even more importantly, soliciting  
SUGGESTIONS. Complaints may get the issue noticed, but only by working  
together for an improved system can we solve these issues.

Thanks!
Jane
From josiahrobertson at gmail.com  Sat Apr 25 17:15:02 2009
From: josiahrobertson at gmail.com (Josiah Robertson)
Date: Sat Apr 25 17:15:27 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
References: <20090415120028.2110D6B95@comox.textdrive.com>
	<54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
Message-ID: <D2FD34E9-3F83-4F0D-B0E3-2DC3F923F641@gmail.com>

Unsubscribe.

Josiah Robertson
Sent from my iPod

On Apr 25, 2009, at 1:11 PM, Jane Wells <jane@automattic.com> wrote:

> I'm saying this flat out: this announcement is coming with no  
> notice. There's a post on the dev blog now about an opportunity for  
> community designers to take a stab at making the header/nav of the  
> admin look a little more polished. The idea only came up last night,  
> and with the 2.8 deadline looming, it would have made more sense to  
> just have Matt Thomas (who did the visual styling of 2.7) kick out a  
> revised comp, but we thought it would be cool to let the community  
> submit design suggestions in visual form. We posted a PSD of Matt's,  
> and anyone who would like to propose an approach is welcome to  
> submit a design.
>
> Since it's a small project, we think this is reasonable. Matt Thomas  
> is working on a comp, so if no one wants to jump in and take on the  
> challenge, that's okay. Like I said, the idea just came up... we  
> didn't think we'd have time for this kind of thing until 2.9. In  
> 2.9, there will be some screen design opportunities around the media  
> upload process, and those larger design projects will be announced a  
> week in advance, and have reasonable turnaround times for  
> deliverables. But not this time! We're trying to squeeze this in  
> under the wire. All details are in the post: http://wordpress.org/development/2009/04/design-tweaks-whos-in-an-idea-in-three-acts/
>
> Slightly but not really off topic: I do want to say that I paid  
> close attention to the thread about the has-patch marathon and the  
> two-days' notice not being enough. I started to write a lengthy  
> response, but decided it would be better to turn that energy toward  
> making change, rather than responding point by point to the  
> complaint. I'm going to start working on figuring out how to improve  
> communication between core devs/contributing devs/Automattic, which  
> will include things like the Ideas forum, the lists, the dev  
> channel, support forums, community blogs, etc. I'm gathering my  
> thoughts right now and trying to get 2.8 out of the way, but in the  
> very near future I'll start soliciting feedback around this issue,  
> and even more importantly, soliciting SUGGESTIONS. Complaints may  
> get the issue noticed, but only by working together for an improved  
> system can we solve these issues.
>
> Thanks!
> Jane
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
From wp-hackers at striderweb.com  Sat Apr 25 18:02:00 2009
From: wp-hackers at striderweb.com (Stephen Rider)
Date: Sat Apr 25 18:02:27 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
References: <20090415120028.2110D6B95@comox.textdrive.com>
	<54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
Message-ID: <C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>

I'm not a big fan of changing it, frankly.  It makes sense for Mu, I  
guess, but it *doesn't* make sense for regular WP.  IMO, you're  
diminishing the design of WP to advance MU.

Stephen

On Apr 25, 2009, at 12:11 PM, Jane Wells wrote:

> I'm saying this flat out: this announcement is coming with no  
> notice. There's a post on the dev blog now about an opportunity for  
> community designers to take a stab at making the header/nav of the  
> admin look a little more polished. The idea only came up last night,  
> and with the 2.8 deadline looming, it would have made more sense to  
> just have Matt Thomas (who did the visual styling of 2.7) kick out a  
> revised comp, but we thought it would be cool to let the community  
> submit design suggestions in visual form. We posted a PSD of Matt's,  
> and anyone who would like to propose an approach is welcome to  
> submit a design.
From mst at eyesx.com  Sat Apr 25 18:23:52 2009
From: mst at eyesx.com (Mattias Tengblad)
Date: Sat Apr 25 18:24:31 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>
References: <20090415120028.2110D6B95@comox.textdrive.com>	<54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
	<C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>
Message-ID: <49F35538.6050203@eyesx.com>

+1

*Mvh*
/Mattias Tengblad/
Webbplats: eyesx.com <http://eyesx.com>
E-post/Live Messenger: mst@eyesx.com <mailto:mst@eyesx.com>


Den 2009-04-25 20:02, Stephen Rider skrev:
> I'm not a big fan of changing it, frankly.  It makes sense for Mu, I 
> guess, but it *doesn't* make sense for regular WP.  IMO, you're 
> diminishing the design of WP to advance MU.
>
> Stephen
>
> On Apr 25, 2009, at 12:11 PM, Jane Wells wrote:
>
>> I'm saying this flat out: this announcement is coming with no notice. 
>> There's a post on the dev blog now about an opportunity for community 
>> designers to take a stab at making the header/nav of the admin look a 
>> little more polished. The idea only came up last night, and with the 
>> 2.8 deadline looming, it would have made more sense to just have Matt 
>> Thomas (who did the visual styling of 2.7) kick out a revised comp, 
>> but we thought it would be cool to let the community submit design 
>> suggestions in visual form. We posted a PSD of Matt's, and anyone who 
>> would like to propose an approach is welcome to submit a design.
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From bryanharley at gmail.com  Sun Apr 26 06:35:59 2009
From: bryanharley at gmail.com (Bryan Harley)
Date: Sun Apr 26 06:36:16 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <49F35538.6050203@eyesx.com>
References: <20090415120028.2110D6B95@comox.textdrive.com>
	<54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
	<C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>
	<49F35538.6050203@eyesx.com>
Message-ID: <58410e2e0904252335g2ece478cid2c0e1b66e7ffdfb@mail.gmail.com>

That said, I kinda like Matt Thomas' tweak.

On Sat, Apr 25, 2009 at 11:23 AM, Mattias Tengblad <mst@eyesx.com> wrote:

> +1
>
> *Mvh*
> /Mattias Tengblad/
> Webbplats: eyesx.com <http://eyesx.com>
> E-post/Live Messenger: mst@eyesx.com <mailto:mst@eyesx.com>
>
>
> Den 2009-04-25 20:02, Stephen Rider skrev:
>
>  I'm not a big fan of changing it, frankly.  It makes sense for Mu, I
>> guess, but it *doesn't* make sense for regular WP.  IMO, you're diminishing
>> the design of WP to advance MU.
>>
>> Stephen
>>
>> On Apr 25, 2009, at 12:11 PM, Jane Wells wrote:
>>
>>  I'm saying this flat out: this announcement is coming with no notice.
>>> There's a post on the dev blog now about an opportunity for community
>>> designers to take a stab at making the header/nav of the admin look a little
>>> more polished. The idea only came up last night, and with the 2.8 deadline
>>> looming, it would have made more sense to just have Matt Thomas (who did the
>>> visual styling of 2.7) kick out a revised comp, but we thought it would be
>>> cool to let the community submit design suggestions in visual form. We
>>> posted a PSD of Matt's, and anyone who would like to propose an approach is
>>> welcome to submit a design.
>>>
>> _______________________________________________
>> wp-testers mailing list
>> wp-testers@lists.automattic.com
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>>  _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
From sarekofvulcan at gmail.com  Mon Apr 27 14:01:18 2009
From: sarekofvulcan at gmail.com (Garrett Fitzgerald)
Date: Mon Apr 27 14:01:32 2009
Subject: [wp-testers] Bleeding-edge errors on my blog
Message-ID: <cf9c5e350904270701w75b672b8k9df01844fda78a94@mail.gmail.com>

I run on 2.8-bleeding-edge, updating regularly using SVN. It's been a
while since this has been a problem, but recently, I killed the blog.
I was able to bring it back, but it seemed a bit unstable. I was
having problems with searching and categories, so I updated to the
current nightly (11096) to see if that fixed it. Now, at the top of
every page, I get the following 3 messages, identical except for line
number:

"Warning: Call-time pass-by-reference has been deprecated; If you
would like to pass it by reference, modify the declaration of
apply_filters(). If you would like to enable call-time
pass-by-reference, you can set allow_call_time_pass_reference to true
in your INI file in
/home/.vuitton/sarekofvulcan/donnael.com/blog/wp-includes/widgets.php
on line 170", "line 231", and "line 261".

To trouble-shoot, I removed all the widgets from the sidebar,
inactivated all the plug-ins, and changed to one of the default
themes, with no obvious result (except that I could search by category
again, which was broken before). I tried exporting earlier to see if I
could restore to a stable version, but neither one of the exports got
all of my posts.
From Jesse.Silverstein at xerox.com  Mon Apr 27 14:08:21 2009
From: Jesse.Silverstein at xerox.com (Silverstein, Jesse)
Date: Mon Apr 27 14:09:32 2009
Subject: [wp-testers] Widgets Pass By Reference Errors (was: Bleeding-edge
	errors on my blog)
In-Reply-To: <cf9c5e350904270701w75b672b8k9df01844fda78a94@mail.gmail.com>
References: <cf9c5e350904270701w75b672b8k9df01844fda78a94@mail.gmail.com>
Message-ID: <F25F2C8DE17FB546A90DB3CF77461427065B3F48@USA0300MS04.na.xerox.net>

Good catch. For an immediate fix, for each of the line numbers it lists,
in the wp-includes/widgets.php put an @ in front of apply_filters(...);

i.e. $variable = @apply_filters('some_filter_name', $variable, &$this);

I haven't looked into why $this is being passed by reference. Maybe a
Dev or someone who already knows can comment?

-Jesse

-----Original Message-----
From: wp-testers-bounces@lists.automattic.com
[mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Garrett
Fitzgerald
Sent: Monday, April 27, 2009 10:01 AM
To: wp-testers@lists.automattic.com
Subject: [wp-testers] Bleeding-edge errors on my blog

I run on 2.8-bleeding-edge, updating regularly using SVN. It's been a
while since this has been a problem, but recently, I killed the blog.
I was able to bring it back, but it seemed a bit unstable. I was
having problems with searching and categories, so I updated to the
current nightly (11096) to see if that fixed it. Now, at the top of
every page, I get the following 3 messages, identical except for line
number:

"Warning: Call-time pass-by-reference has been deprecated; If you
would like to pass it by reference, modify the declaration of
apply_filters(). If you would like to enable call-time
pass-by-reference, you can set allow_call_time_pass_reference to true
in your INI file in
/home/.vuitton/sarekofvulcan/donnael.com/blog/wp-includes/widgets.php
on line 170", "line 231", and "line 261".

To trouble-shoot, I removed all the widgets from the sidebar,
inactivated all the plug-ins, and changed to one of the default
themes, with no obvious result (except that I could search by category
again, which was broken before). I tried exporting earlier to see if I
could restore to a stable version, but neither one of the exports got
all of my posts.
_______________________________________________
wp-testers mailing list
wp-testers@lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers

No virus found in this incoming message.
Checked by AVG - www.avg.com 
Version: 8.0.238 / Virus Database: 270.12.4/2081 - Release Date:
04/27/09 06:19:00
From xavier at borderie.net  Mon Apr 27 14:21:34 2009
From: xavier at borderie.net (Xavier Borderie)
Date: Mon Apr 27 14:22:03 2009
Subject: [wp-testers] No-Notice Design Opportunity
In-Reply-To: <C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>
References: <20090415120028.2110D6B95@comox.textdrive.com> 
	<54C27CEE-D293-48AA-AB46-62901152D078@automattic.com>
	<C8AA1CC8-A4DA-4EEC-BAFE-5C7A4DB02CA8@striderweb.com>
Message-ID: <9e4ae73e0904270721j77377248q913af4164bc2c7fd@mail.gmail.com>

Agreed with Stephen, but hopefully the suggestion solutions will be
awesome enough as to change my mind :)

-x.


2009/4/25 Stephen Rider <wp-hackers@striderweb.com>:
> I'm not a big fan of changing it, frankly. ?It makes sense for Mu, I guess,
> but it *doesn't* make sense for regular WP. ?IMO, you're diminishing the
> design of WP to advance MU.
>
> Stephen
>
> On Apr 25, 2009, at 12:11 PM, Jane Wells wrote:
>
>> I'm saying this flat out: this announcement is coming with no notice.
>> There's a post on the dev blog now about an opportunity for community
>> designers to take a stab at making the header/nav of the admin look a little
>> more polished. The idea only came up last night, and with the 2.8 deadline
>> looming, it would have made more sense to just have Matt Thomas (who did the
>> visual styling of 2.7) kick out a revised comp, but we thought it would be
>> cool to let the community submit design suggestions in visual form. We
>> posted a PSD of Matt's, and anyone who would like to propose an approach is
>> welcome to submit a design.
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers
>



-- 
Xavier Borderie
From tklingenberg at lastflood.net  Mon Apr 27 17:11:52 2009
From: tklingenberg at lastflood.net (Tom Klingenberg)
Date: Mon Apr 27 17:11:41 2009
Subject: [wp-testers] Widgets Pass By Reference Errors (was: Bleeding-edge
	errors on my blog)
In-Reply-To: <F25F2C8DE17FB546A90DB3CF77461427065B3F48@USA0300MS04.na.xerox.net>
References: <cf9c5e350904270701w75b672b8k9df01844fda78a94@mail.gmail.com>
	<F25F2C8DE17FB546A90DB3CF77461427065B3F48@USA0300MS04.na.xerox.net>
Message-ID: <op.us1112tcsed26o@monolith.gonzales>

hi all,

looks like this is related to a changed php configuration on your server.  
this is error reporting related. disable strict errors.

On Mon, 27 Apr 2009 16:08:21 +0200, Silverstein, Jesse  
<Jesse.Silverstein@xerox.com> wrote:

> Good catch. For an immediate fix, for each of the line numbers it lists,
> in the wp-includes/widgets.php put an @ in front of apply_filters(...);
>
> i.e. $variable = @apply_filters('some_filter_name', $variable, &$this);

I would not suggest that. there are already too many @s in there. instead  
of that, configure your php setup. do the according ini-setting. or do  
what really is suggested: disable strict error reporting:

/**
  * error_reporting_unstrict
  *
  * Disable Strict Errors if applicable because wordpress
  * is not php 5 strict compatible.
  */
function error_reporting_unstrict()
{
	// check if E_STRICT does already exists
	if ( defined($name = 'E_STRICT') === FALSE )
	{
		return;
	}

	/*
	 * Change Error-Reporting by only removing
	 * the E_STRICT
	 */

	// Read out current Error Reporting value
	$orig = error_reporting(0);
	error_reporting($orig);

	// If E_STRICT is set, unset it in the bitmask
	if ( $orig & E_STRICT )
	{
		// Unsetting E_STRICT from bitmask
		$changed = ($orig ^ E_STRICT);

		// Set the changed Bitmask
		error_reporting($changed);
	}	
}

// Disable Strict Errors //
error_reporting_unstrict();

you can put it on top of wp-config.php. should do the job.

>
> I haven't looked into why $this is being passed by reference. Maybe a
> Dev or someone who already knows can comment?

all that is related to php 4 issues. as long as wordpress stays php 4  
(yes, it is php 4 code), you will encounter those problems on php 5  
installations. when php 4 compability is dropped, this will change. until  
then, disable strict error reporting or do the ini setting to call-time  
pass-by-referenceenable.


-- Tom


>
> -Jesse
>
> -----Original Message-----
> From: wp-testers-bounces@lists.automattic.com
> [mailto:wp-testers-bounces@lists.automattic.com] On Behalf Of Garrett
> Fitzgerald
> Sent: Monday, April 27, 2009 10:01 AM
> To: wp-testers@lists.automattic.com
> Subject: [wp-testers] Bleeding-edge errors on my blog
> [...]
From tpblogeditor at gmail.com  Mon Apr 27 22:43:58 2009
From: tpblogeditor at gmail.com (Paleo Pat)
Date: Mon Apr 27 22:44:13 2009
Subject: [wp-testers] Re: BUG: Insert Button on MS-Word Import is broken...
In-Reply-To: <c3a04f3c0904271525t2e79d560o373188a35fe5dda4@mail.gmail.com>
References: <c3a04f3c0904271525t2e79d560o373188a35fe5dda4@mail.gmail.com>
Message-ID: <c3a04f3c0904271543x4af116aev77475be5ab63d677@mail.gmail.com>

I submitted a ticket. Hopefully this one get fixed soon.

http://core.trac.wordpress.org/ticket/9659

I have another one to submit about the text import function as well.

-Pat



On Mon, Apr 27, 2009 at 6:25 PM, Paleo Pat <tpblogeditor@gmail.com> wrote:

> Just an FYI:
>
> .... on 2.8 bleeding, insert button on the MS-Word import function is
> broken. I click and nothing happens. :(
>
> I can submit a ticket, if need be.
>
>
>
> -Paleo Pat
> http://www.politicalbyline.com
>
>
>
From tpblogeditor at gmail.com  Mon Apr 27 22:25:52 2009
From: tpblogeditor at gmail.com (Paleo Pat)
Date: Mon Apr 27 23:03:39 2009
Subject: [wp-testers] BUG: Insert Button on MS-Word Import is broken...
Message-ID: <c3a04f3c0904271525t2e79d560o373188a35fe5dda4@mail.gmail.com>

Just an FYI:

.... on 2.8 bleeding, insert button on the MS-Word import function is
broken. I click and nothing happens. :(

I can submit a ticket, if need be.



-Paleo Pat
http://www.politicalbyline.com