[wp-testers] Change of behaviour of smilie translations and WP-Grins

[Les Bessant]

Following up on my own post...

A small modification to wp-grins so that it adds spaces around the tags
inserted means that the current translation behaviour will work in new posts
and comments.

Line 34 (the same one that needs to be changed for WP2.0.x, now reads:

$grins .= '<img
src="'.get_settings('siteurl').'/wp-includes/images/smilies/'.$grin.'"
alt="'.$tag.'" onclick="grin(\' '.$tag.' \');"/> ';

(Spaces inserted before and after $tag in the onlick value.)

Editing old posts and comments that are broken could be fun, though.


Les Bessant les at lcb.me.uk
Losing it[1] - http://lcb.me.uk
My flickr pictures - http://flickr.com/photos/lesbessant/


> -----Original Message-----
> From: wp-testers-bounces at lists.automattic.com [mailto:wp-testers-
> bounces at lists.automattic.com] On Behalf Of Les Bessant
> Sent: 16 January 2007 20:03
> To: wp-testers at lists.automattic.com
> Subject: [wp-testers] Change of behaviour of smilie translations and
WP-Grins
> 
> Found this behaviour with the betas (it may precede them, but I didn't
look
> too closely before).
> 
> All posts imported from my live 2.0.x installation into a test site using
> 2.1.
> 
> I have a number of custom smilies, all defined in wp-config.php. As I
often
> string several together, not all their translations have spaces in. In
fact,
> hardly any do. Most are of the form ':rant:' with the surrounding colons
> being enough to ensure they are only translated when I want them to.
> 
> This all works as expected in 2.0.x.
> 
> In 2.1, I find that translation does not happen unless there are spaces
> around the string to be translated. So a smiley at the beginning of a
> comment tends not to be translated, two in a row don't get translated, and
> those inserted straight after words or punctuation don't get translated.
> 
> I found this: http://trac.wordpress.org/ticket/2444 in trac - I'm not a
> coder, so I have little chance of working out what it means, but it looks
> like it might be related.
> 
> Is this behaviour expected[1] or is it something that can be changed
> 
> And on the subject of smilies, the traditional way of using WP-Grins
> (http://www.tamba2.org.uk/wordpress/smilies/) doesn't seem doable any
more.
> I've looked at the code, but don't have any idea where to start with
finding
> where to put the call. I did manage to put the function call into a new
> block on the sidebar, but that's not as neat as running them above the
post
> form. Suggestions would be useful - I know a lot of people like clickable
> smilies....
> 
> [1] Or "by design" as Microsoft like to say about annoying "features" ;-)
> 
> 
> 
> Les Bessant les at lcb.me.uk
> Losing it[1] - http://lcb.me.uk
> My flickr pictures - http://flickr.com/photos/lesbessant/
> 
> 
> 
> _______________________________________________
> wp-testers mailing list
> wp-testers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-testers