[wp-testers] WP Grins breaks in 1.6

[Les Bessant]

The path is set in line 34 of wp-grins.php (in my copy, anyway)

Just changed it to read:

$grins .= '<img
src="'.get_settings('siteurl').'/wp-includes/images/smilies/'.$grin.'"
alt="'.$tag.'" onclick="grin(\''.$tag.'\');"/> ';

And smilies now work.

In WYSISWYG, there used to be a clickable pop up smilies window, but it was
ever so slightly broken, and seems to have been removed. Would be nice to
see a working version.  


________________________________

Les Bessant les at lcb.me.uk
Losing it[1] - http://lcb.me.uk/

-----Original Message-----
From: wp-testers-bounces at lists.automattic.com
[mailto:wp-testers-bounces at lists.automattic.com] On Behalf Of Podz
Sent: 05 November 2005 13:32
To: Testers
Subject: [wp-testers] WP Grins breaks in 1.6

Very popular plugin judging by forum posts, and 1.6 breaks it a lot.

1. Inserting the code to call it is not difficult:
line 134 in edit-form-advanced.php
<fieldset id="postdiv">
<legend><?php _e('Post') ?></legend>
<?php wp_grins(); ?>

But with the wysiwyg activated, it does not work.
Deactivate that and it does work
But,
It then looks for the smilies here:
<img src='http://localhost/copy/wp-includes/images/smilies/biggrin.gif'
alt=':grin:'
whereas on my site, it looks here:
<img src='http://www.tamba2.org.uk/T2/wp-images/smilies/smile.gif' alt=':)'

So it seems that upgraded users will need to maintain two sets of smilies ?

I know this isn't core code, but there really does have to be a working
replacement for this plugin ready for the launch of 1.6

P.