<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29679] trunk/src/wp-admin: Plugin install: Better styling to accommodate plugin icons.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29679">29679</a></dd>
<dt>Author</dt> <dd>helen</dd>
<dt>Date</dt> <dd>2014-09-02 19:46:19 +0000 (Tue, 02 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Plugin install: Better styling to accommodate plugin icons.
fixes <a href="http://core.trac.wordpress.org/ticket/29466">#29466</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswpplugininstalllisttablephp">trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/list-tables.css (29678 => 29679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/list-tables.css 2014-09-02 19:35:35 UTC (rev 29678)
+++ trunk/src/wp-admin/css/list-tables.css 2014-09-02 19:46:19 UTC (rev 29679)
</span><span class="lines">@@ -1306,8 +1306,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .plugin-card-top {
</span><ins>+ position: relative;
</ins><span class="cx"> padding: 20px 20px 10px;
</span><del>- min-height: 115px; /* 2 lines for the description + author */
</del><ins>+ min-height: 135px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> div.action-links,
</span><span class="lines">@@ -1318,8 +1319,22 @@
</span><span class="cx"> .plugin-card h4 {
</span><span class="cx"> margin: 0 0 12px;
</span><span class="cx"> font-size: 18px;
</span><ins>+ line-height: 1.3;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+.plugin-card .name,
+.plugin-card .desc {
+ margin-left: 148px; /* icon + margin */
+ margin-right: 120px; /* action links */
+}
+
+.plugin-card .action-links {
+ position: absolute;
+ top: 20px;
+ right: 20px;
+ width: 120px;
+}
+
</ins><span class="cx"> .plugin-action-buttons {
</span><span class="cx"> clear: right;
</span><span class="cx"> float: right;
</span><span class="lines">@@ -1384,6 +1399,7 @@
</span><span class="cx"> text-decoration: none !important;
</span><span class="cx"> color: #444;
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> .plugin-card .compatibility-incompatible:before {
</span><span class="cx"> content: '\f158';
</span><span class="cx"> }
</span><span class="lines">@@ -1397,12 +1413,19 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .plugin-icon {
</span><ins>+ position: absolute;
+ top: 20px;
+ left: 20px;
</ins><span class="cx"> width: 128px;
</span><span class="cx"> height: 128px;
</span><del>- float: left;
</del><span class="cx"> margin: 0 20px 20px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.plugin-icon img {
+ width: 128px;
+ height: 128px;
+}
+
</ins><span class="cx"> .no-plugin-results {
</span><span class="cx"> color: #999;
</span><span class="cx"> font-size: 18px;
</span><span class="lines">@@ -1430,9 +1453,38 @@
</span><span class="cx"> /* =Media Queries
</span><span class="cx"> -------------------------------------------------------------- */
</span><span class="cx">
</span><del>-/**
- * HiDPI Displays
- */
</del><ins>+@media screen and ( max-width: 1100px ) and ( min-width: 782px ), ( max-width: 480px ) {
+ .plugin-card .action-links {
+ position: static;
+ margin-left: 148px;
+ width: auto;
+ }
+
+ .plugin-action-buttons {
+ float: none;
+ margin: 1em 0 0;
+ text-align: left;
+ }
+
+ .plugin-action-buttons li {
+ display: inline-block;
+ vertical-align: middle;
+ }
+
+ .plugin-action-buttons li .button {
+ margin-right: 20px;
+ }
+
+ .plugin-card .name,
+ .plugin-card .desc {
+ margin-right: 0;
+ }
+
+ .plugin-card .desc p:first-of-type {
+ margin-top: 0;
+ }
+}
+
</ins><span class="cx"> @media screen and ( max-width: 782px ) {
</span><span class="cx"> /* WP List Table Options & Filters */
</span><span class="cx"> .tablenav {
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpplugininstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (29678 => 29679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php 2014-09-02 19:35:35 UTC (rev 29678)
+++ trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php 2014-09-02 19:46:19 UTC (rev 29679)
</span><span class="lines">@@ -435,7 +435,10 @@
</span><span class="cx"> ?>
</span><span class="cx"> <div class="plugin-card">
</span><span class="cx"> <div class="plugin-card-top">
</span><del>- <a href="<?php echo esc_url( $details_link ); ?>" class="thickbox"><img src="<?php echo esc_attr( $plugin_icon_url ) ?>" class="plugin-icon" /></a>
</del><ins>+ <a href="<?php echo esc_url( $details_link ); ?>" class="thickbox plugin-icon"><img src="<?php echo esc_attr( $plugin_icon_url ) ?>" /></a>
+ <div class="name column-name">
+ <h4><a href="<?php echo esc_url( $details_link ); ?>" class="thickbox"><?php echo $title; ?></a></h4>
+ </div>
</ins><span class="cx"> <div class="action-links">
</span><span class="cx"> <?php
</span><span class="cx"> if ( $action_links ) {
</span><span class="lines">@@ -443,9 +446,6 @@
</span><span class="cx"> }
</span><span class="cx"> ?>
</span><span class="cx"> </div>
</span><del>- <div class="name column-name">
- <h4><a href="<?php echo esc_url( $details_link ); ?>" class="thickbox"><?php echo $title; ?></a></h4>
- </div>
</del><span class="cx"> <div class="desc column-description">
</span><span class="cx"> <p><?php echo $description; ?></p>
</span><span class="cx"> <p class="authors"><?php echo $author; ?></p>
</span></span></pre>
</div>
</div>
</body>
</html>