<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29632] trunk/src: Media modals: Better responsive views, especially the header.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29632">29632</a></dd>
<dt>Author</dt> <dd>helen</dd>
<dt>Date</dt> <dd>2014-08-26 21:49:39 +0000 (Tue, 26 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Media modals: Better responsive views, especially the header.
* Only show the "dropdown" when there is a menu. Note that this uses a `:not()` selector, but it is supported in browsers that support media queries so it is safe to use here.
* Make the header shorter when on particularly narrow screens, which also tend to be shorter.
* Don't restrict the height of images in the attachment details modal, to take advantage of all available space.
fixes <a href="http://core.trac.wordpress.org/ticket/29339">#29339</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincssmediacss">trunk/src/wp-admin/css/media.css</a></li>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincssmediacss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/media.css (29631 => 29632)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/media.css 2014-08-26 20:00:07 UTC (rev 29631)
+++ trunk/src/wp-admin/css/media.css 2014-08-26 21:49:39 UTC (rev 29632)
</span><span class="lines">@@ -1145,17 +1145,44 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @media only screen and (max-width: 480px) {
</span><ins>+ .edit-attachment-frame .media-frame-title {
+ right: 110px;
+ }
+
+ .upload-php .media-modal-close,
+ .edit-attachment-frame .edit-media-header .left,
+ .edit-attachment-frame .edit-media-header .right {
+ width: 40px;
+ height: 40px;
+ }
+
+ .upload-php .media-modal-close .media-modal-icon {
+ margin: 9px 10px;
+ }
+
+ .edit-attachment-frame .edit-media-header .right:before,
+ .edit-attachment-frame .edit-media-header .left:before {
+ line-height: 40px !important;
+ }
+
+ .edit-attachment-frame .edit-media-header .left {
+ right: 82px;
+ }
+
+ .edit-attachment-frame .edit-media-header .right {
+ right: 41px;
+ }
+
+ .edit-attachment-frame .media-frame-content {
+ top: 40px;
+ }
+
</ins><span class="cx"> .edit-attachment-frame .attachment-media-view {
</span><span class="cx"> float: none;
</span><del>- max-height: 70%;
</del><span class="cx"> height: auto;
</span><span class="cx"> width: 100%;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .edit-attachment-frame .attachment-media-view.portrait {
- height: 70%;
- }
-
</del><span class="cx"> .edit-attachment-frame .attachment-info {
</span><span class="cx"> height: auto;
</span><span class="cx"> width: 100%;
</span></span></pre></div>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/media-views.css (29631 => 29632)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/media-views.css 2014-08-26 20:00:07 UTC (rev 29631)
+++ trunk/src/wp-includes/css/media-views.css 2014-08-26 21:49:39 UTC (rev 29632)
</span><span class="lines">@@ -2147,19 +2147,19 @@
</span><span class="cx"> @media only screen and (max-width: 900px) {
</span><span class="cx">
</span><span class="cx"> /* Drop-down menu */
</span><del>- .media-frame .media-frame-title,
- .media-frame .media-frame-router,
- .media-frame .media-frame-content,
- .media-frame .media-frame-toolbar {
</del><ins>+ .media-frame:not(.hide-menu) .media-frame-title,
+ .media-frame:not(.hide-menu) .media-frame-router,
+ .media-frame:not(.hide-menu) .media-frame-content,
+ .media-frame:not(.hide-menu) .media-frame-toolbar {
</ins><span class="cx"> left: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-frame-menu {
</del><ins>+ .media-frame:not(.hide-menu) .media-frame-menu {
</ins><span class="cx"> position: static;
</span><span class="cx"> width: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-menu {
</del><ins>+ .media-frame:not(.hide-menu) .media-menu {
</ins><span class="cx"> width: auto;
</span><span class="cx"> max-width: 80%;
</span><span class="cx"> overflow: auto;
</span><span class="lines">@@ -2172,34 +2172,34 @@
</span><span class="cx"> border: 1px solid #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-menu.visible {
</del><ins>+ .media-frame:not(.hide-menu) .media-menu.visible {
</ins><span class="cx"> left: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-menu > a {
</del><ins>+ .media-frame:not(.hide-menu) .media-menu > a {
</ins><span class="cx"> padding: 12px 16px;
</span><span class="cx"> font-size: 16px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-menu > a.active {
</del><ins>+ .media-frame:not(.hide-menu) .media-menu > a.active {
</ins><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-menu .separator {
</del><ins>+ .media-frame:not(.hide-menu) .media-menu .separator {
</ins><span class="cx"> margin: 5px 10px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-frame-title {
</del><ins>+ .media-frame:not(.hide-menu) .media-frame-title {
</ins><span class="cx"> left: 0;
</span><span class="cx"> color: #21759b;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-frame-title .dashicons {
</del><ins>+ .media-frame:not(.hide-menu) .media-frame-title .dashicons {
</ins><span class="cx"> display: inline-block;
</span><span class="cx"> line-height: 50px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame .media-frame-title h1 {
</del><ins>+ .media-frame:not(.hide-menu) .media-frame-title h1 {
</ins><span class="cx"> line-height: 3;
</span><span class="cx"> font-size: 18px;
</span><span class="cx"> float: left;
</span><span class="lines">@@ -2458,6 +2458,38 @@
</span><span class="cx"> .media-frame-content .media-toolbar .attachment-filters {
</span><span class="cx"> max-width: 90px;
</span><span class="cx"> }
</span><ins>+
+ .media-modal-close {
+ top: 5px;
+ right: 5px;
+ }
+
+ .media-modal .media-frame-title {
+ height: 40px;
+ }
+
+ .media-modal .media-frame-title h1,
+ .media-frame:not(.hide-menu) .media-frame-title h1 {
+ font-size: 18px;
+ line-height: 40px;
+ }
+
+ .media-frame:not(.hide-menu) .media-frame-title .dashicons {
+ line-height: 40px;
+ }
+
+ .media-frame-router,
+ .media-frame:not(.hide-menu) .media-menu {
+ top: 40px;
+ }
+
+ .media-frame-content {
+ top: 74px;
+ }
+
+ .media-frame.hide-router .media-frame-content {
+ top: 40px;
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>