<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29616] trunk/src: Focus styling: bring the blue glow to more places.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29616">29616</a></dd>
<dt>Author</dt> <dd>helen</dd>
<dt>Date</dt> <dd>2014-08-26 05:16:14 +0000 (Tue, 26 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Focus styling: bring the blue glow to more places.
Handles color picker, theme browser, help/screen options, TinyMCE dialog buttons, jQuery UI dialog buttons, and buttons in color schemes.
props avryl, celloexpressions. fixes <a href="http://core.trac.wordpress.org/ticket/28267">#28267</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsscolorpickercss">trunk/src/wp-admin/css/color-picker.css</a></li>
<li><a href="#trunksrcwpadmincsscolors_mixinsscss">trunk/src/wp-admin/css/colors/_mixins.scss</a></li>
<li><a href="#trunksrcwpadmincsscommoncss">trunk/src/wp-admin/css/common.css</a></li>
<li><a href="#trunksrcwpadmincssthemescss">trunk/src/wp-admin/css/themes.css</a></li>
<li><a href="#trunksrcwpadminjscolorpickerjs">trunk/src/wp-admin/js/color-picker.js</a></li>
<li><a href="#trunksrcwpincludescsseditorcss">trunk/src/wp-includes/css/editor.css</a></li>
<li><a href="#trunksrcwpincludescssjqueryuidialogcss">trunk/src/wp-includes/css/jquery-ui-dialog.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsscolorpickercss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/color-picker.css (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/color-picker.css 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-admin/css/color-picker.css 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -47,13 +47,15 @@
</span><span class="cx"> box-shadow: inset 0 1px 0 #fff;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-color-result:hover {
</del><ins>+.wp-color-result:hover,
+.wp-color-result:focus {
</ins><span class="cx"> background: #fafafa;
</span><span class="cx"> border-color: #999;
</span><span class="cx"> color: #222;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-color-result:hover:after {
</del><ins>+.wp-color-result:hover:after,
+.wp-color-result:focus:after {
</ins><span class="cx"> color: #222;
</span><span class="cx"> border-color: #aaa;
</span><span class="cx"> border-left: 1px solid #999;
</span><span class="lines">@@ -73,15 +75,14 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-color-result:focus {
</span><del>- border-color: #888;
- -webkit-box-shadow: 0 1px 2px rgba( 0, 0, 0, 0.2 );
- box-shadow: 0 1px 2px rgba( 0, 0, 0, 0.2 );
</del><ins>+ -webkit-box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
+ box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-color-result:focus:after {
- border-color: #888;
-}
-
</del><span class="cx"> .wp-picker-open + .wp-picker-input-wrap {
</span><span class="cx"> display: inline-block;
</span><span class="cx"> vertical-align: top;
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_mixinsscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors/_mixins.scss (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors/_mixins.scss 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-admin/css/colors/_mixins.scss 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -13,14 +13,22 @@
</span><span class="cx"> background: darken( $button-color, 5% );
</span><span class="cx"> border-color: darken( $button-color, 15% );
</span><span class="cx"> color: $text-color;
</span><del>- box-shadow: inset 0 1px 0 lighten( $button-color, 10% ), 0 1px 0 rgba(0,0,0,.15);
</del><ins>+ box-shadow: inset 0 1px 0 lighten( $button-color, 10% ),
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ &:focus {
+ box-shadow: inset 0 1px 0 lighten( $button-color, 10% ),
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, .8 );
+ }
+
</ins><span class="cx"> &:active {
</span><span class="cx"> background: darken( $button-color, 10% );
</span><span class="cx"> border-color: darken( $button-color, 15% );
</span><span class="cx"> color: $text-color;
</span><del>- box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</del><ins>+ box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 ),
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, .8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> &[disabled],
</span></span></pre></div>
<a id="trunksrcwpadmincsscommoncss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/common.css (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/common.css 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-admin/css/common.css 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -1382,12 +1382,6 @@
</span><span class="cx"> color: #333;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#screen-meta-links a:focus {
- border-color: #aaa;
- -webkit-box-shadow: 0 2px 3px rgba(0,0,0,0.15);
- box-shadow: 0 2px 3px rgba(0,0,0,0.15);
-}
-
</del><span class="cx"> #screen-meta-links a.show-settings {
</span><span class="cx"> display: block;
</span><span class="cx"> font-size: 13px;
</span></span></pre></div>
<a id="trunksrcwpadmincssthemescss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/themes.css (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/themes.css 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-admin/css/themes.css 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -188,13 +188,17 @@
</span><span class="cx"> -webkit-transition: opacity 0.1s ease-in-out;
</span><span class="cx"> transition: opacity 0.1s ease-in-out;
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> .theme-browser .theme:focus {
</span><del>- outline: 1px dotted #222;
</del><ins>+ border-color: #5b9dd9;
+ -webkit-box-shadow: 0 0 2px rgba( 30, 140, 190, 0.8 );
+ box-shadow: 0 0 2px rgba( 30, 140, 190, 0.8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-browser .theme:focus .more-details {
</span><span class="cx"> opacity: 1;
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> /* Current theme needs to have its action always on view */
</span><span class="cx"> .theme-browser .theme.active:focus .theme-actions {
</span><span class="cx"> display: block;
</span></span></pre></div>
<a id="trunksrcwpadminjscolorpickerjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/color-picker.js (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/color-picker.js 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-admin/js/color-picker.js 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> });
</span><span class="cx"> },
</span><span class="cx"> open: function() {
</span><del>- this.element.show().iris( 'toggle' );
</del><ins>+ this.element.show().iris( 'toggle' ).focus();
</ins><span class="cx"> this.button.removeClass( 'hidden' );
</span><span class="cx"> this.toggler.addClass( 'wp-picker-open' );
</span><span class="cx"> $( 'body' ).trigger( 'click.wpcolorpicker' ).on( 'click.wpcolorpicker', this.close );
</span></span></pre></div>
<a id="trunksrcwpincludescsseditorcss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/editor.css (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/editor.css 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-includes/css/editor.css 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -414,8 +414,8 @@
</span><span class="cx"> -webkit-border-radius: 3px;
</span><span class="cx"> border-radius: 3px;
</span><span class="cx"> white-space: nowrap;
</span><del>- -webkit-box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba(0,0,0,.08);
- box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba(0,0,0,.08);
</del><ins>+ -webkit-box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba( 0, 0, 0, 0.08 );
+ box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba( 0, 0, 0, 0.08 );
</ins><span class="cx"> background-image: none;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -427,28 +427,34 @@
</span><span class="cx"> padding: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.mce-window .mce-btn:hover {
</del><ins>+.mce-window .mce-btn:hover,
+.mce-window .mce-btn:focus {
</ins><span class="cx"> background: #fafafa;
</span><span class="cx"> border-color: #999;
</span><span class="cx"> color: #222;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn:focus {
</span><del>- -webkit-box-shadow: 1px 1px 1px rgba(0,0,0,.2);
- box-shadow: 1px 1px 1px rgba(0,0,0,.2);
</del><ins>+ -webkit-box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
+ box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn:active {
</span><span class="cx"> background: #eee;
</span><span class="cx"> border-color: #999;
</span><span class="cx"> color: #333;
</span><del>- -webkit-box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
- box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</del><ins>+ -webkit-box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
+ box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn.mce-disabled {
</span><span class="cx"> color: #aaa;
</span><span class="cx"> border-color: #ddd;
</span><ins>+ background: #f7f7f7;
</ins><span class="cx"> -webkit-box-shadow: none;
</span><span class="cx"> box-shadow: none;
</span><span class="cx"> text-shadow: 0 1px 0 #fff;
</span><span class="lines">@@ -458,39 +464,50 @@
</span><span class="cx"> .mce-window .mce-btn.mce-primary {
</span><span class="cx"> background: #2ea2cc;
</span><span class="cx"> border-color: #0074a2;
</span><del>- -webkit-box-shadow: inset 0 1px 0 rgba(120,200,230,0.5), 0 1px 0 rgba(0,0,0,.15);
- box-shadow: inset 0 1px 0 rgba(120,200,230,0.5), 0 1px 0 rgba(0,0,0,.15);
</del><ins>+ -webkit-box-shadow: inset 0 1px 0 rgba( 120, 200, 230, 0.5), 0 1px 0 rgba( 0, 0, 0, 0.15 );
+ box-shadow: inset 0 1px 0 rgba( 120, 200, 230, 0.5 ), 0 1px 0 rgba( 0, 0, 0, 0.15 );
</ins><span class="cx"> color: #fff;
</span><span class="cx"> text-decoration: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.mce-window .mce-btn.mce-primary:hover {
</del><ins>+.mce-window .mce-btn.mce-primary:hover,
+.mce-window .mce-btn.mce-primary:focus {
</ins><span class="cx"> background: #1e8cbe;
</span><span class="cx"> border-color: #0074a2;
</span><del>- -webkit-box-shadow: inset 0 1px 0 rgba(120,200,230,0.6);
- box-shadow: inset 0 1px 0 rgba(120,200,230,0.6);
</del><ins>+ -webkit-box-shadow: inset 0 1px 0 rgba( 120, 200, 230, 0.6 );
+ box-shadow: inset 0 1px 0 rgba( 120, 200, 230, 0.6 );
</ins><span class="cx"> color: #fff;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn.mce-primary:focus {
</span><span class="cx"> border-color: #0e3950;
</span><del>- -webkit-box-shadow: inset 0 1px 0 rgba(120,200,230,0.6), 1px 1px 2px rgba(0,0,0,0.4);
- box-shadow: inset 0 1px 0 rgba(120,200,230,0.6), 1px 1px 2px rgba(0,0,0,0.4);
</del><ins>+ -webkit-box-shadow:
+ inset 0 1px 0 rgba( 120, 200, 230, 0.6 ),
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
+ box-shadow:
+ inset 0 1px 0 rgba( 120, 200, 230, 0.6 ),
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn.mce-primary:active {
</span><span class="cx"> background: #1b7aa6;
</span><span class="cx"> border-color: #005684;
</span><del>- color: rgba(255,255,255,0.95);
- -webkit-box-shadow: inset 0 1px 0 rgba(0,0,0,0.1);
- box-shadow: inset 0 1px 0 rgba(0,0,0,0.1);
</del><ins>+ color: rgba( 255, 255, 255, 0.95 );
+ -webkit-box-shadow: inset 0 1px 0 rgba( 0, 0, 0, 0.1 );
+ box-shadow: inset 0 1px 0 rgba( 0, 0, 0, 0.1 );
+ vertical-align: top;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-window .mce-btn.mce-primary.mce-disabled {
</span><span class="cx"> color: #94cde7;
</span><span class="cx"> background: #298cba;
</span><span class="cx"> border-color: #1b607f;
</span><del>- text-shadow: 0 -1px 0 rgba(0,0,0,0.1);
</del><ins>+ -webkit-box-shadow: none;
+ box-shadow: none;
+ text-shadow: 0 -1px 0 rgba( 0, 0, 0, 0.1 );
+ cursor: default;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .mce-menubtn.mce-fixed-width button span {
</span></span></pre></div>
<a id="trunksrcwpincludescssjqueryuidialogcss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/jquery-ui-dialog.css (29615 => 29616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/jquery-ui-dialog.css 2014-08-26 04:45:54 UTC (rev 29615)
+++ trunk/src/wp-includes/css/jquery-ui-dialog.css 2014-08-26 05:16:14 UTC (rev 29616)
</span><span class="lines">@@ -181,11 +181,16 @@
</span><span class="cx"> color: #555;
</span><span class="cx"> border-color: #cccccc;
</span><span class="cx"> background: #f7f7f7;
</span><del>- -webkit-box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba(0,0,0,.08);
- box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba(0,0,0,.08);
</del><ins>+ -webkit-box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba( 0, 0, 0, 0.08 );
+ box-shadow: inset 0 1px 0 #fff, 0 1px 0 rgba( 0, 0, 0, 0.08 );
</ins><span class="cx"> vertical-align: top;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.ui-button:active,
+.ui-button:focus {
+ outline: none;
+}
+
</ins><span class="cx"> /* Remove the dotted border on :focus and the extra padding in Firefox */
</span><span class="cx"> .ui-button::-moz-focus-inner {
</span><span class="cx"> border-width: 1px 0;
</span><span class="lines">@@ -194,24 +199,28 @@
</span><span class="cx"> padding: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.ui-button:hover {
</del><ins>+.ui-button:hover,
+.ui-button:focus {
</ins><span class="cx"> background: #fafafa;
</span><span class="cx"> border-color: #999;
</span><span class="cx"> color: #222;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .ui-button:focus {
</span><del>- -webkit-box-shadow: 1px 1px 1px rgba(0,0,0,.2);
- box-shadow: 1px 1px 1px rgba(0,0,0,.2);
</del><ins>+ -webkit-box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
+ box-shadow:
+ 0 0 0 1px #5b9dd9,
+ 0 0 2px 1px rgba( 30, 140, 190, 0.8 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .ui-button:active {
</span><span class="cx"> background: #eee;
</span><span class="cx"> border-color: #999;
</span><span class="cx"> color: #333;
</span><del>- -webkit-box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
- box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
- outline: none;
</del><ins>+ -webkit-box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
+ box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .ui-button[disabled],
</span></span></pre>
</div>
</div>
</body>
</html>