<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29583] trunk/src/wp-admin: Apply accessibility improvements to Plugins screen too.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29583">29583</a></dd>
<dt>Author</dt> <dd>ocean90</dd>
<dt>Date</dt> <dd>2014-08-24 16:21:20 +0000 (Sun, 24 Aug 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Apply accessibility improvements to Plugins screen too.

props SergeyBiryukov.
fixes <a href="http://core.trac.wordpress.org/ticket/29342">#29342</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminjsplugininstalljs">trunk/src/wp-admin/js/plugin-install.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (29582 => 29583)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php      2014-08-24 16:17:01 UTC (rev 29582)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2014-08-24 16:21:20 UTC (rev 29583)
</span><span class="lines">@@ -522,10 +522,13 @@
</span><span class="cx">                                  if ( ( ! is_multisite() || $screen->in_admin( 'network' ) ) ) {
</span><span class="cx">                                          // Details link using API info, if available
</span><span class="cx">                                          if ( isset( $plugin_data['slug'] ) ) {
</span><del>-                                                       $plugin_meta[] = sprintf( '<a href="%s" class="thickbox">%s</a>',
</del><ins>+                                                        $plugin_meta[] = sprintf( '<a href="%s" class="thickbox" aria-label="%s" data-title="%s">%s</a>',
</ins><span class="cx">                                                           esc_url( self_admin_url( 'plugin-install.php?tab=plugin-information&plugin=' . $plugin_data['slug'] .
</span><span class="cx">                                                                  '&TB_iframe=true&width=600&height=550' ) ),
</span><del>-                                                               __( 'View details' ) );
</del><ins>+                                                                esc_attr( sprintf( __( 'More information about %s' ), $plugin_name ) ),
+                                                               esc_attr( $plugin_name ),
+                                                               __( 'View details' )
+                                                       );
</ins><span class="cx">                                           } elseif ( ! empty( $plugin_data['PluginURI'] ) ) {
</span><span class="cx">                                                  $plugin_meta[] = sprintf( '<a href="%s">%s</a>',
</span><span class="cx">                                                          esc_url( $plugin_data['PluginURI'] ),
</span></span></pre></div>
<a id="trunksrcwpadminjsplugininstalljs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/plugin-install.js (29582 => 29583)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/plugin-install.js  2014-08-24 16:17:01 UTC (rev 29582)
+++ trunk/src/wp-admin/js/plugin-install.js     2014-08-24 16:21:20 UTC (rev 29583)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">          tb_position();
</span><span class="cx">  });
</span><span class="cx"> 
</span><del>-       $('.plugin-card').on( 'click', 'a.thickbox', function() {
</del><ins>+        $( '.plugin-card, .plugins .column-description' ).on( 'click', 'a.thickbox', function() {
</ins><span class="cx">           tb_click.call(this);
</span><span class="cx"> 
</span><span class="cx">          $('#TB_title').css({'background-color':'#222','color':'#cfcfcf'});
</span></span></pre>
</div>
</div>

</body>
</html>