<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29521] trunk/src/wp-includes/js/tinymce/plugins: TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes #29235.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29521">29521</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2014-08-17 20:10:16 +0000 (Sun, 17 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes <a href="http://core.trac.wordpress.org/ticket/29235">#29235</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjstinymcepluginswpeditimagepluginjs">trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js</a></li>
<li><a href="#trunksrcwpincludesjstinymcepluginswpviewpluginjs">trunk/src/wp-includes/js/tinymce/plugins/wpview/plugin.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjstinymcepluginswpeditimagepluginjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js (29520 => 29521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js 2014-08-17 15:00:40 UTC (rev 29520)
+++ trunk/src/wp-includes/js/tinymce/plugins/wpeditimage/plugin.js 2014-08-17 20:10:16 UTC (rev 29521)
</span><span class="lines">@@ -549,8 +549,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( 'ontouchend' in document ) {
</span><del>- editor.on( 'touchend', edit );
-
</del><span class="cx"> editor.on( 'click', function( event ) {
</span><span class="cx"> var target = event.target;
</span><span class="cx">
</span><span class="lines">@@ -563,10 +561,10 @@
</span><span class="cx"> event.stopPropagation();
</span><span class="cx"> }
</span><span class="cx"> });
</span><del>- } else {
- editor.on( 'mouseup', edit );
</del><span class="cx"> }
</span><span class="cx">
</span><ins>+ editor.on( 'mouseup touchend', edit );
+
</ins><span class="cx"> editor.on( 'init', function() {
</span><span class="cx"> var dom = editor.dom,
</span><span class="cx"> captionClass = editor.getParam( 'wpeditimage_html5_captions' ) ? 'html5-captions' : 'html4-captions';
</span></span></pre></div>
<a id="trunksrcwpincludesjstinymcepluginswpviewpluginjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/tinymce/plugins/wpview/plugin.js (29520 => 29521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/tinymce/plugins/wpview/plugin.js 2014-08-17 15:00:40 UTC (rev 29520)
+++ trunk/src/wp-includes/js/tinymce/plugins/wpview/plugin.js 2014-08-17 20:10:16 UTC (rev 29521)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx"> toRemove = false,
</span><span class="cx"> firstFocus = true,
</span><span class="cx"> _noop = function() { return false; },
</span><del>- isTouchDevice = ( 'ontouchend' in document ),
</del><ins>+ isios = /iPad|iPod|iPhone/.test( navigator.userAgent ),
</ins><span class="cx"> cursorInterval, lastKeyDownNode, setViewCursorTries, focus, execCommandView;
</span><span class="cx">
</span><span class="cx"> function getView( node ) {
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> dom.bind( selected, 'beforedeactivate focusin focusout', _stop );
</span><span class="cx">
</span><span class="cx"> // select the hidden div
</span><del>- if ( isTouchDevice ) {
</del><ins>+ if ( isios ) {
</ins><span class="cx"> editor.selection.select( clipboard );
</span><span class="cx"> } else {
</span><span class="cx"> editor.selection.select( clipboard, true );
</span><span class="lines">@@ -298,8 +298,7 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> editor.on( 'mousedown mouseup click touchend', function( event ) {
</span><del>- var view = getView( event.target ),
- type = isTouchDevice ? 'touchend' : 'mousedown';
</del><ins>+ var view = getView( event.target );
</ins><span class="cx">
</span><span class="cx"> firstFocus = false;
</span><span class="cx">
</span><span class="lines">@@ -308,7 +307,7 @@
</span><span class="cx"> event.stopImmediatePropagation();
</span><span class="cx"> event.preventDefault();
</span><span class="cx">
</span><del>- if ( event.type === type && ! event.metaKey && ! event.ctrlKey ) {
</del><ins>+ if ( ( event.type === 'touchend' || event.type === 'mousedown' ) && ! event.metaKey && ! event.ctrlKey ) {
</ins><span class="cx"> if ( editor.dom.hasClass( event.target, 'edit' ) ) {
</span><span class="cx"> wp.mce.views.edit( view );
</span><span class="cx"> editor.focus();
</span><span class="lines">@@ -329,7 +328,7 @@
</span><span class="cx"> // Unfortunately, it also inhibits the dragging of views to a new location.
</span><span class="cx"> return false;
</span><span class="cx"> } else {
</span><del>- if ( event.type === type ) {
</del><ins>+ if ( event.type === 'touchend' || event.type === 'mousedown' ) {
</ins><span class="cx"> deselect();
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>