<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29496] trunk/src/wp-includes: Small screen responsive for attachment details modal.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29496">29496</a></dd>
<dt>Author</dt> <dd>helen</dd>
<dt>Date</dt> <dd>2014-08-15 04:09:58 +0000 (Fri, 15 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Small screen responsive for attachment details modal. see <a href="http://core.trac.wordpress.org/ticket/28844">#28844</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
<li><a href="#trunksrcwpincludesmediatemplatephp">trunk/src/wp-includes/media-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/media-views.css (29495 => 29496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/media-views.css 2014-08-15 03:16:07 UTC (rev 29495)
+++ trunk/src/wp-includes/css/media-views.css 2014-08-15 04:09:58 UTC (rev 29496)
</span><span class="lines">@@ -285,42 +285,42 @@
</span><span class="cx"> margin: 24px 0 8px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting {
</del><ins>+.attachment-details .setting {
</ins><span class="cx"> display: block;
</span><span class="cx"> float: left;
</span><span class="cx"> width: 100%;
</span><span class="cx"> margin: 1px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting label {
</del><ins>+.attachment-details .setting label {
</ins><span class="cx"> display: block;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting .link-to-custom {
</del><ins>+.attachment-details .setting .link-to-custom {
</ins><span class="cx"> margin: 3px 2px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting span {
</del><ins>+.attachment-details .setting span {
</ins><span class="cx"> min-width: 30%;
</span><span class="cx"> margin-right: 4%;
</span><span class="cx"> font-size: 12px;
</span><span class="cx"> text-align: right;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting select {
</del><ins>+.attachment-details .setting select {
</ins><span class="cx"> max-width: 65%;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting input[type="checkbox"],
-.media-sidebar .field input[type="checkbox"],
-.media-sidebar .setting input[type="radio"],
-.media-sidebar .field input[type="radio"] {
</del><ins>+.attachment-details .setting input[type="checkbox"],
+.attachment-details .field input[type="checkbox"],
+.attachment-details .setting input[type="radio"],
+.attachment-details .field input[type="radio"] {
</ins><span class="cx"> float: none;
</span><span class="cx"> margin: 8px 3px 0;
</span><span class="cx"> padding: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting span,
</del><ins>+.attachment-details .setting span,
</ins><span class="cx"> .compat-item label span {
</span><span class="cx"> float: left;
</span><span class="cx"> min-height: 22px;
</span><span class="lines">@@ -334,32 +334,33 @@
</span><span class="cx"> text-align: right;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting input[type="text"],
-.media-sidebar .setting input[type="password"],
-.media-sidebar .setting input[type="email"],
-.media-sidebar .setting input[type="number"],
-.media-sidebar .setting input[type="search"],
-.media-sidebar .setting input[type="tel"],
-.media-sidebar .setting input[type="url"],
-.media-sidebar .setting textarea,
-.media-sidebar .setting .value {
</del><ins>+.attachment-details .setting input[type="text"],
+.attachment-details .setting input[type="password"],
+.attachment-details .setting input[type="email"],
+.attachment-details .setting input[type="number"],
+.attachment-details .setting input[type="search"],
+.attachment-details .setting input[type="tel"],
+.attachment-details .setting input[type="url"],
+.attachment-details .setting textarea,
+.attachment-details .setting .value {
+ box-sizing: border-box;
</ins><span class="cx"> margin: 1px;
</span><span class="cx"> width: 65%;
</span><span class="cx"> float: right;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting .value {
</del><ins>+.attachment-details .setting .value {
</ins><span class="cx"> margin: 0 1px;
</span><span class="cx"> text-align: left;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar .setting textarea,
</del><ins>+.attachment-details .setting textarea,
</ins><span class="cx"> .compat-item .field textarea {
</span><span class="cx"> height: 62px;
</span><span class="cx"> resize: vertical;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-sidebar select {
</del><ins>+.attachment-details select {
</ins><span class="cx"> margin-top: 3px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2172,19 +2173,19 @@
</span><span class="cx"> @media only screen and (max-width: 900px) {
</span><span class="cx">
</span><span class="cx"> /* Drop-down menu */
</span><del>- .media-frame-title,
- .media-frame-router,
- .media-frame-content,
- .media-frame-toolbar {
</del><ins>+ .media-frame .media-frame-title,
+ .media-frame .media-frame-router,
+ .media-frame .media-frame-content,
+ .media-frame .media-frame-toolbar {
</ins><span class="cx"> left: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-menu {
</del><ins>+ .media-frame .media-frame-menu {
</ins><span class="cx"> position: static;
</span><span class="cx"> width: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu {
</del><ins>+ .media-frame .media-menu {
</ins><span class="cx"> width: auto;
</span><span class="cx"> max-width: 80%;
</span><span class="cx"> overflow: auto;
</span><span class="lines">@@ -2197,34 +2198,34 @@
</span><span class="cx"> border: 1px solid #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu.visible {
</del><ins>+ .media-frame .media-menu.visible {
</ins><span class="cx"> left: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu > a {
</del><ins>+ .media-frame .media-menu > a {
</ins><span class="cx"> padding: 12px 16px;
</span><span class="cx"> font-size: 16px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu > a.active {
</del><ins>+ .media-frame .media-menu > a.active {
</ins><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu .separator {
</del><ins>+ .media-frame .media-menu .separator {
</ins><span class="cx"> margin: 5px 10px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-title {
</del><ins>+ .media-frame .media-frame-title {
</ins><span class="cx"> left: 0;
</span><span class="cx"> color: #21759b;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-title .dashicons {
</del><ins>+ .media-frame .media-frame-title .dashicons {
</ins><span class="cx"> display: inline-block;
</span><span class="cx"> line-height: 56px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-title h1 {
</del><ins>+ .media-frame .media-frame-title h1 {
</ins><span class="cx"> line-height: 3;
</span><span class="cx"> font-size: 18px;
</span><span class="cx"> float: left;
</span><span class="lines">@@ -2242,18 +2243,18 @@
</span><span class="cx"> right: 262px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting {
</del><ins>+ .attachment-details .setting {
</ins><span class="cx"> margin: 6px 0px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting input,
- .media-sidebar .setting textarea,
- .media-sidebar .setting span,
</del><ins>+ .attachment-details .setting input,
+ .attachment-details .setting textarea,
+ .attachment-details .setting span,
</ins><span class="cx"> .compat-item label span {
</span><span class="cx"> float: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting span,
</del><ins>+ .attachment-details .setting span,
</ins><span class="cx"> .compat-item label span {
</span><span class="cx"> text-align: inherit;
</span><span class="cx"> min-height: 16px;
</span><span class="lines">@@ -2261,26 +2262,27 @@
</span><span class="cx"> padding: 8px 2px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting .value {
</del><ins>+ .attachment-details .setting .value {
</ins><span class="cx"> float: none;
</span><span class="cx"> width: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting input[type="text"],
- .media-sidebar .setting input[type="password"],
- .media-sidebar .setting input[type="email"],
- .media-sidebar .setting input[type="number"],
- .media-sidebar .setting input[type="search"],
- .media-sidebar .setting input[type="tel"],
- .media-sidebar .setting input[type="url"],
- .media-sidebar .setting textarea,
- .media-sidebar .setting select {
</del><ins>+ .attachment-details .setting input[type="text"],
+ .attachment-details .setting input[type="password"],
+ .attachment-details .setting input[type="email"],
+ .attachment-details .setting input[type="number"],
+ .attachment-details .setting input[type="search"],
+ .attachment-details .setting input[type="tel"],
+ .attachment-details .setting input[type="url"],
+ .attachment-details .setting textarea,
+ .attachment-details .setting select {
+ float: none;
</ins><span class="cx"> width: 98%;
</span><span class="cx"> max-width: none;
</span><span class="cx"> height: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-sidebar .setting select.columns {
</del><ins>+ .attachment-details .setting select.columns {
</ins><span class="cx"> width: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2742,17 +2744,11 @@
</span><span class="cx"> display: block;
</span><span class="cx"> margin-bottom: 16px;
</span><span class="cx"> max-width: 100%;
</span><ins>+ max-height: 90%;
</ins><span class="cx"> max-height: -webkit-calc( 100% - 42px );
</span><span class="cx"> max-height: calc( 100% - 42px ); /* leave space for actions underneath */
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame .delete-attachment,
-.edit-attachment-frame .trash-attachment,
-.edit-attachment-frame .untrash-attachment {
- float: right;
- margin-top: 7px;
-}
-
</del><span class="cx"> .edit-attachment-frame .wp-media-wrapper {
</span><span class="cx"> margin-bottom: 12px;
</span><span class="cx"> }
</span><span class="lines">@@ -2773,92 +2769,30 @@
</span><span class="cx"> background: #f3f3f3;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame input,
-.edit-attachment-frame textarea {
- padding: 6px 8px;
- line-height: 16px;
-}
-
</del><span class="cx"> .edit-attachment-frame .attachment-info .details,
</span><span class="cx"> .edit-attachment-frame .attachment-info .settings {
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> float: none;
</span><del>- position: relative;
</del><span class="cx"> margin-bottom: 15px;
</span><span class="cx"> padding-bottom: 15px;
</span><span class="cx"> border-bottom: 1px solid #ddd;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame .attachment-info .setting {
- display: block;
- float: left;
- width: 100%;
- margin: 1px 0;
</del><ins>+.attachment-info .actions {
+ margin-bottom: 16px;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame .attachment-info .setting label {
- display: block;
</del><ins>+.attachment-info .actions a {
+ display: inline;
+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame .attachment-info .setting .link-to-custom {
- margin: 3px 0;
-}
-
-.edit-attachment-frame .attachment-info .setting .name {
- min-width: 30%;
- margin-right: 4%;
- font-size: 12px;
- text-align: right;
-}
-
-.edit-attachment-frame .attachment-info .setting select {
- max-width: 65%;
-}
-
-.edit-attachment-frame .attachment-info .setting input[type="checkbox"],
-.edit-attachment-frame .attachment-info .field input[type="checkbox"],
-.edit-attachment-frame .attachment-info .setting input[type="radio"],
-.edit-attachment-frame .attachment-info .field input[type="radio"] {
- float: none;
- margin: 8px 3px 0;
- padding: 0;
-}
-
-.edit-attachment-frame .attachment-info .setting span {
- float: left;
- min-height: 22px;
- padding-top: 8px;
</del><ins>+.edit-attachment-frame input,
+.edit-attachment-frame textarea {
+ padding: 6px 8px;
</ins><span class="cx"> line-height: 16px;
</span><del>- font-weight: normal;
- color: #666;
</del><span class="cx"> }
</span><span class="cx">
</span><del>-.edit-attachment-frame .attachment-info .setting input[type="text"],
-.edit-attachment-frame .attachment-info .setting input[type="password"],
-.edit-attachment-frame .attachment-info .setting input[type="email"],
-.edit-attachment-frame .attachment-info .setting input[type="number"],
-.edit-attachment-frame .attachment-info .setting input[type="search"],
-.edit-attachment-frame .attachment-info .setting input[type="email"],
-.edit-attachment-frame .attachment-info .setting input[type="url"],
-.edit-attachment-frame .attachment-info .setting textarea,
-.edit-attachment-frame .attachment-info .setting .value {
- margin: 1px;
- width: 65%;
- float: right;
- -webkit-box-sizing: border-box;
- -moz-box-sizing: border-box;
- box-sizing: border-box;
-}
-
-.edit-attachment-frame .attachment-info .setting textarea {
- height: 62px;
- resize: vertical;
-}
-
-.edit-attachment-frame .attachment-info select {
- margin-top: 3px;
-}
-
</del><span class="cx"> /**
</span><span class="cx"> * Media queries for media grid.
</span><span class="cx"> */
</span><span class="lines">@@ -2877,6 +2811,24 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+@media only screen and (max-width: 480px) {
+ .edit-attachment-frame .attachment-media-view {
+ float: none;
+ max-height: 70%;
+ height: auto;
+ width: 100%;
+ }
+
+ .edit-attachment-frame .attachment-media-view.portrait {
+ height: 70%;
+ }
+
+ .edit-attachment-frame .attachment-info {
+ height: auto;
+ width: 100%;
+ }
+}
+
</ins><span class="cx"> .attachments[data-columns="1"] .attachment {
</span><span class="cx"> width: 100%;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunksrcwpincludesmediatemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/media-template.php (29495 => 29496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/media-template.php 2014-08-15 03:16:07 UTC (rev 29495)
+++ trunk/src/wp-includes/media-template.php 2014-08-15 04:09:58 UTC (rev 29496)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> </script>
</span><span class="cx">
</span><span class="cx"> <script type="text/html" id="tmpl-attachment-details-two-column">
</span><del>- <div class="attachment-media-view">
</del><ins>+ <div class="attachment-media-view {{ data.orientation }}">
</ins><span class="cx"> <div class="thumbnail thumbnail-{{ data.type }}">
</span><span class="cx"> <# if ( data.uploading ) { #>
</span><span class="cx"> <div class="media-progress-bar"><div></div></div>
</span><span class="lines">@@ -313,18 +313,6 @@
</span><span class="cx"> <# if ( 'image' === data.type && ! data.uploading ) { #>
</span><span class="cx"> <a class="button edit-attachment" href="#"><?php _e( 'Edit Image' ); ?></a>
</span><span class="cx"> <# } #>
</span><del>-
- <# if ( ! data.uploading && data.can.remove ) { #>
- <?php if ( MEDIA_TRASH ): ?>
- <# if ( 'trash' === data.status ) { #>
- <a class="untrash-attachment" href="#"><?php _e( 'Untrash' ); ?></a>
- <# } else { #>
- <a class="trash-attachment" href="#"><?php _e( 'Trash' ); ?></a>
- <# } #>
- <?php else: ?>
- <a class="delete-attachment" href="#"><?php _e( 'Delete Permanently' ); ?></a>
- <?php endif; ?>
- <# } #>
</del><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="lines">@@ -413,8 +401,21 @@
</span><span class="cx"> <div class="attachment-compat"></div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>- <a class="view-attachment" href="{{ data.link }}"><?php _e( 'View attachment page' ); ?></a> |
- <a href="post.php?post={{ data.id }}&action=edit"><?php _e( 'Edit more details' ); ?></a>
</del><ins>+ <div class="actions">
+ <a class="view-attachment" href="{{ data.link }}"><?php _e( 'View attachment page' ); ?></a> |
+ <a href="post.php?post={{ data.id }}&action=edit"><?php _e( 'Edit more details' ); ?></a>
+ <# if ( ! data.uploading && data.can.remove ) { #> |
+ <?php if ( MEDIA_TRASH ): ?>
+ <# if ( 'trash' === data.status ) { #>
+ <a class="untrash-attachment" href="#"><?php _e( 'Untrash' ); ?></a>
+ <# } else { #>
+ <a class="trash-attachment" href="#"><?php _e( 'Trash' ); ?></a>
+ <# } #>
+ <?php else: ?>
+ <a class="delete-attachment" href="#"><?php _e( 'Delete Permanently' ); ?></a>
+ <?php endif; ?>
+ <# } #>
+ </div>
</ins><span class="cx">
</span><span class="cx"> </div>
</span><span class="cx"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>