<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29294] trunk/src/wp-admin/includes: Adds `<label>`s to current page selector and bulk actions `<select>` field so that screen readers have an explicit label.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29294">29294</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-07-25 00:19:21 +0000 (Fri, 25 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Adds `<label>`s to current page selector and bulk actions `<select>` field so that screen readers have an explicit label.
Props joedolson.
Fixes <a href="http://core.trac.wordpress.org/ticket/28867">#28867</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-list-table.php (29293 => 29294)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2014-07-24 22:24:07 UTC (rev 29293)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2014-07-25 00:19:21 UTC (rev 29294)
</span><span class="lines">@@ -343,8 +343,10 @@
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><span class="cx"> * @access protected
</span><ins>+ *
+ * @param string $which The location of the bulk actions: 'top' or 'bottom'.
</ins><span class="cx"> */
</span><del>- protected function bulk_actions() {
</del><ins>+ protected function bulk_actions( $which ) {
</ins><span class="cx"> if ( is_null( $this->_actions ) ) {
</span><span class="cx"> $no_new_actions = $this->_actions = $this->get_bulk_actions();
</span><span class="cx"> /**
</span><span class="lines">@@ -369,7 +371,8 @@
</span><span class="cx"> if ( empty( $this->_actions ) )
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- echo "<select name='action$two'>\n";
</del><ins>+ echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . __( 'Select Bulk Action' ) . "</label>";
+ echo "<select name='action$two' id='bulk-action-selector-" . esc_attr( $which ) . "'>\n";
</ins><span class="cx"> echo "<option value='-1' selected='selected'>" . __( 'Bulk Actions' ) . "</option>\n";
</span><span class="cx">
</span><span class="cx"> foreach ( $this->_actions as $name => $title ) {
</span><span class="lines">@@ -638,7 +641,8 @@
</span><span class="cx"> if ( 'bottom' == $which ) {
</span><span class="cx"> $html_current_page = $current;
</span><span class="cx"> } else {
</span><del>- $html_current_page = sprintf( "<input class='current-page' title='%s' type='text' name='paged' value='%s' size='%d' />",
</del><ins>+ $html_current_page_label = "<label for='current-page-selector'>" . __( 'Select Page' ) . "</label>";
+ $html_current_page = $html_current_page_label . sprintf( "<input class='current-page' id='current-page-selector' title='%s' type='text' name='paged' value='%s' size='%d' />",
</ins><span class="cx"> esc_attr__( 'Current page' ),
</span><span class="cx"> $current,
</span><span class="cx"> strlen( $total_pages )
</span><span class="lines">@@ -898,7 +902,7 @@
</span><span class="cx"> <div class="tablenav <?php echo esc_attr( $which ); ?>">
</span><span class="cx">
</span><span class="cx"> <div class="alignleft actions bulkactions">
</span><del>- <?php $this->bulk_actions(); ?>
</del><ins>+ <?php $this->bulk_actions( $which ); ?>
</ins><span class="cx"> </div>
</span><span class="cx"> <?php
</span><span class="cx"> $this->extra_tablenav( $which );
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (29293 => 29294)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2014-07-24 22:24:07 UTC (rev 29293)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2014-07-25 00:19:21 UTC (rev 29294)
</span><span class="lines">@@ -298,13 +298,13 @@
</span><span class="cx"> return $actions;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function bulk_actions() {
</del><ins>+ public function bulk_actions( $which ) {
</ins><span class="cx"> global $status;
</span><span class="cx">
</span><span class="cx"> if ( in_array( $status, array( 'mustuse', 'dropins' ) ) )
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- parent::bulk_actions();
</del><ins>+ parent::bulk_actions( $which );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected function extra_tablenav( $which ) {
</span></span></pre>
</div>
</div>
</body>
</html>