<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29191] trunk/src/wp-includes/js/mce-view.js: Cleanup after [29179]:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29191">29191</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-07-16 18:18:18 +0000 (Wed, 16 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cleanup after <a href="http://core.trac.wordpress.org/changeset/29179">[29179]</a>:
* Pause players when media is edited via modal
* Remove players on unind
* Account for failure when an empty node is passed to an `mce.view.View`
See <a href="http://core.trac.wordpress.org/ticket/28905">#28905</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsmceviewjs">trunk/src/wp-includes/js/mce-view.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsmceviewjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/mce-view.js (29190 => 29191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/mce-view.js 2014-07-16 17:55:00 UTC (rev 29190)
+++ trunk/src/wp-includes/js/mce-view.js 2014-07-16 18:18:18 UTC (rev 29191)
</span><span class="lines">@@ -129,10 +129,10 @@
</span><span class="cx"> iframe, iframeDoc, i, resize;
</span><span class="cx">
</span><span class="cx"> node = $( node ).find( '.wpview-content' )[0];
</span><del>-
- if ( node ) {
- node.innerHTML = '';
</del><ins>+ if ( ! node ) {
+ return;
</ins><span class="cx"> }
</span><ins>+ node.innerHTML = '';
</ins><span class="cx">
</span><span class="cx"> iframe = dom.add( node, 'iframe', {
</span><span class="cx"> src: tinymce.Env.ie ? 'javascript:""' : '',
</span><span class="lines">@@ -511,10 +511,14 @@
</span><span class="cx">
</span><span class="cx"> _.bindAll( this, 'createIframe', 'setNode', 'fetch', 'pausePlayers' );
</span><span class="cx"> $( this ).on( 'ready', this.setNode );
</span><ins>+
+ $( document ).on( 'media:edit', this.pausePlayers );
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> setNode: function ( event, editor, node ) {
</span><del>- this.node = node;
</del><ins>+ if ( node ) {
+ this.node = node;
+ }
</ins><span class="cx"> editor.on( 'hide', this.pausePlayers );
</span><span class="cx">
</span><span class="cx"> if ( this.parsed ) {
</span><span class="lines">@@ -573,12 +577,25 @@
</span><span class="cx">
</span><span class="cx"> pausePlayers: function() {
</span><span class="cx"> var p, win = $( 'iframe', this.node ).get(0).contentWindow;
</span><del>- if ( win.mejs ) {
</del><ins>+ if ( win && win.mejs ) {
</ins><span class="cx"> for ( p in win.mejs.players ) {
</span><span class="cx"> win.mejs.players[p].pause();
</span><ins>+ }
+ }
+ },
+
+ unsetPlayers: function() {
+ var p, win = $( 'iframe', this.node ).get(0).contentWindow;
+ if ( win && win.mejs ) {
+ for ( p in win.mejs.players ) {
</ins><span class="cx"> win.mejs.players[p].remove();
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+ },
+
+ unbind: function() {
+ this.pausePlayers();
+ this.unsetPlayers();
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>