<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29137] trunk/src/wp-admin/includes: Fix mismatches in access modifiers for `WP_List_Table` + subclasses.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29137">29137</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-07-13 22:08:22 +0000 (Sun, 13 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix mismatches in access modifiers for `WP_List_Table` + subclasses.
Fixes <a href="http://core.trac.wordpress.org/ticket/28843">#28843</a>, <a href="http://core.trac.wordpress.org/ticket/28879">#28879</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswpcommentslisttablephp">trunk/src/wp-admin/includes/class-wp-comments-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplinkslisttablephp">trunk/src/wp-admin/includes/class-wp-links-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmedialisttablephp">trunk/src/wp-admin/includes/class-wp-media-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsthemeslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsuserslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpplugininstalllisttablephp">trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswptermslisttablephp">trunk/src/wp-admin/includes/class-wp-terms-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpthemeinstalllisttablephp">trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpthemeslisttablephp">trunk/src/wp-admin/includes/class-wp-themes-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpuserslisttablephp">trunk/src/wp-admin/includes/class-wp-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludeslisttablephp">trunk/src/wp-admin/includes/list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswpcommentslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-comments-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> _e( 'No comments found.' );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function get_views() {
</del><ins>+ protected function get_views() {
</ins><span class="cx"> global $post_id, $comment_status, $comment_type;
</span><span class="cx">
</span><span class="cx"> $status_links = array();
</span><span class="lines">@@ -201,7 +201,7 @@
</span><span class="cx"> return $status_links;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function get_bulk_actions() {
</del><ins>+ protected function get_bulk_actions() {
</ins><span class="cx"> global $comment_status;
</span><span class="cx">
</span><span class="cx"> $actions = array();
</span><span class="lines">@@ -225,7 +225,7 @@
</span><span class="cx"> return $actions;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function extra_tablenav( $which ) {
</del><ins>+ protected function extra_tablenav( $which ) {
</ins><span class="cx"> global $comment_status, $comment_type;
</span><span class="cx"> ?>
</span><span class="cx"> <div class="alignleft actions">
</span><span class="lines">@@ -301,7 +301,7 @@
</span><span class="cx"> return $columns;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function get_sortable_columns() {
</del><ins>+ protected function get_sortable_columns() {
</ins><span class="cx"> return array(
</span><span class="cx"> 'author' => 'comment_author',
</span><span class="cx"> 'response' => 'comment_post_ID'
</span><span class="lines">@@ -582,7 +582,7 @@
</span><span class="cx"> */
</span><span class="cx"> class WP_Post_Comments_List_Table extends WP_Comments_List_Table {
</span><span class="cx">
</span><del>- public function get_column_info() {
</del><ins>+ protected function get_column_info() {
</ins><span class="cx"> $this->_column_headers = array(
</span><span class="cx"> array(
</span><span class="cx"> 'author' => __( 'Author' ),
</span><span class="lines">@@ -595,7 +595,7 @@
</span><span class="cx"> return $this->_column_headers;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function get_table_classes() {
</del><ins>+ protected function get_table_classes() {
</ins><span class="cx"> $classes = parent::get_table_classes();
</span><span class="cx"> $classes[] = 'comments-box';
</span><span class="cx"> return $classes;
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplinkslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-links-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-links-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-links-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> global $cat_id;
</span><span class="cx">
</span><span class="cx"> $alt = 0;
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -333,9 +333,9 @@
</span><span class="cx"> * Display the bulk actions dropdown.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access public
</del><ins>+ * @access protected
</ins><span class="cx"> */
</span><del>- public function bulk_actions() {
</del><ins>+ protected function bulk_actions() {
</ins><span class="cx"> if ( is_null( $this->_actions ) ) {
</span><span class="cx"> $no_new_actions = $this->_actions = $this->get_bulk_actions();
</span><span class="cx"> /**
</span><span class="lines">@@ -762,11 +762,11 @@
</span><span class="cx"> * Print column headers, accounting for hidden and sortable columns.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access protected
</del><ins>+ * @access public
</ins><span class="cx"> *
</span><span class="cx"> * @param bool $with_id Whether to set the id attribute or not
</span><span class="cx"> */
</span><del>- protected function print_column_headers( $with_id = true ) {
</del><ins>+ public function print_column_headers( $with_id = true ) {
</ins><span class="cx"> list( $columns, $hidden, $sortable ) = $this->get_column_info();
</span><span class="cx">
</span><span class="cx"> $current_url = set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'] );
</span><span class="lines">@@ -913,9 +913,9 @@
</span><span class="cx"> * Generate the <tbody> part of the table
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access protected
</del><ins>+ * @access public
</ins><span class="cx"> */
</span><del>- protected function display_rows_or_placeholder() {
</del><ins>+ public function display_rows_or_placeholder() {
</ins><span class="cx"> if ( $this->has_items() ) {
</span><span class="cx"> $this->display_rows();
</span><span class="cx"> } else {
</span><span class="lines">@@ -929,9 +929,9 @@
</span><span class="cx"> * Generate the table rows
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access protected
</del><ins>+ * @access public
</ins><span class="cx"> */
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> foreach ( $this->items as $item )
</span><span class="cx"> $this->single_row( $item );
</span><span class="cx"> }
</span><span class="lines">@@ -940,11 +940,11 @@
</span><span class="cx"> * Generates content for a single row of the table
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access protected
</del><ins>+ * @access public
</ins><span class="cx"> *
</span><span class="cx"> * @param object $item The current item
</span><span class="cx"> */
</span><del>- protected function single_row( $item ) {
</del><ins>+ public function single_row( $item ) {
</ins><span class="cx"> static $row_class = '';
</span><span class="cx"> $row_class = ( $row_class == '' ? ' class="alternate"' : '' );
</span><span class="cx">
</span><span class="lines">@@ -1028,9 +1028,9 @@
</span><span class="cx"> /**
</span><span class="cx"> * Send required variables to JavaScript land
</span><span class="cx"> *
</span><del>- * @access private
</del><ins>+ * @access public
</ins><span class="cx"> */
</span><del>- private function _js_vars() {
</del><ins>+ public function _js_vars() {
</ins><span class="cx"> $args = array(
</span><span class="cx"> 'class' => get_class( $this ),
</span><span class="cx"> 'screen' => array(
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-media-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-media-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-media-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -232,7 +232,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> global $post;
</span><span class="cx">
</span><span class="cx"> add_filter( 'the_title','esc_html' );
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsthemeslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -250,12 +250,12 @@
</span><span class="cx"> return $actions;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> foreach ( $this->items as $theme )
</span><span class="cx"> $this->single_row( $theme );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function single_row( $theme ) {
</del><ins>+ public function single_row( $theme ) {
</ins><span class="cx"> global $status, $page, $s, $totals;
</span><span class="cx">
</span><span class="cx"> $context = $status;
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> global $mode;
</span><span class="cx">
</span><span class="cx"> $alt = '';
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpplugininstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -216,7 +216,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> $plugins_allowedtags = array(
</span><span class="cx"> 'a' => array( 'href' => array(),'title' => array(), 'target' => array() ),
</span><span class="cx"> 'abbr' => array( 'title' => array() ),'acronym' => array( 'title' => array() ),
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -323,7 +323,7 @@
</span><span class="cx"> return parent::current_action();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> global $status;
</span><span class="cx">
</span><span class="cx"> if ( is_multisite() && ! $this->screen->in_admin( 'network' ) && in_array( $status, array( 'mustuse', 'dropins' ) ) )
</span><span class="lines">@@ -333,7 +333,7 @@
</span><span class="cx"> $this->single_row( array( $plugin_file, $plugin_data ) );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function single_row( $item ) {
</del><ins>+ public function single_row( $item ) {
</ins><span class="cx"> global $status, $page, $s, $totals;
</span><span class="cx">
</span><span class="cx"> list( $plugin_file, $plugin_data ) = $item;
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -358,7 +358,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows( $posts = array(), $level = 0 ) {
</del><ins>+ public function display_rows( $posts = array(), $level = 0 ) {
</ins><span class="cx"> global $wp_query, $per_page;
</span><span class="cx">
</span><span class="cx"> if ( empty( $posts ) )
</span><span class="lines">@@ -525,7 +525,7 @@
</span><span class="cx"> unset( $children_pages[$parent] ); //required in order to keep track of orphans
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function single_row( $post, $level = 0 ) {
</del><ins>+ public function single_row( $post, $level = 0 ) {
</ins><span class="cx"> global $mode;
</span><span class="cx"> static $alternate;
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswptermslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-terms-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-terms-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-terms-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows_or_placeholder() {
</del><ins>+ public function display_rows_or_placeholder() {
</ins><span class="cx"> $taxonomy = $this->screen->taxonomy;
</span><span class="cx">
</span><span class="cx"> $args = wp_parse_args( $this->callback_args, array(
</span><span class="lines">@@ -240,7 +240,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function single_row( $tag, $level = 0 ) {
</del><ins>+ public function single_row( $tag, $level = 0 ) {
</ins><span class="cx"> global $taxonomy;
</span><span class="cx"> $tag = sanitize_term( $tag, $taxonomy );
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpthemeinstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx"> parent::tablenav( 'bottom' );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> $themes = $this->items;
</span><span class="cx"> foreach ( $themes as $theme ) {
</span><span class="cx"> ?>
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx"> * public 'description' => string 'A basic magazine style layout with a fully customizable layout through a backend interface. Designed by <a href="http://bavotasan.com">c.bavota</a> of <a href="http://tinkerpriestmedia.com">Tinker Priest Media</a>.'
</span><span class="cx"> * public 'download_link' => string 'http://wordpress.org/themes/download/magazine-basic.1.1.zip'
</span><span class="cx"> */
</span><del>- protected function single_row( $theme ) {
</del><ins>+ public function single_row( $theme ) {
</ins><span class="cx"> global $themes_allowedtags;
</span><span class="cx">
</span><span class="cx"> if ( empty( $theme ) )
</span><span class="lines">@@ -396,12 +396,12 @@
</span><span class="cx"> * Send required variables to JavaScript land
</span><span class="cx"> *
</span><span class="cx"> * @since 3.4.0
</span><del>- * @access private
</del><ins>+ * @access public
</ins><span class="cx"> *
</span><span class="cx"> * @uses $tab Global; current tab within Themes->Install screen
</span><span class="cx"> * @uses $type Global; type of search.
</span><span class="cx"> */
</span><del>- private function _js_vars( $extra_args = array() ) {
</del><ins>+ public function _js_vars( $extra_args = array() ) {
</ins><span class="cx"> global $tab, $type;
</span><span class="cx"> parent::_js_vars( compact( 'tab', 'type' ) );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpthemeslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-themes-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-themes-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-themes-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> return array();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows_or_placeholder() {
</del><ins>+ public function display_rows_or_placeholder() {
</ins><span class="cx"> if ( $this->has_items() ) {
</span><span class="cx"> $this->display_rows();
</span><span class="cx"> } else {
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- protected function display_rows() {
</del><ins>+ public function display_rows() {
</ins><span class="cx"> $themes = $this->items;
</span><span class="cx">
</span><span class="cx"> foreach ( $themes as $theme ):
</span><span class="lines">@@ -243,13 +243,13 @@
</span><span class="cx"> * Send required variables to JavaScript land
</span><span class="cx"> *
</span><span class="cx"> * @since 3.4.0
</span><del>- * @access private
</del><ins>+ * @access public
</ins><span class="cx"> *
</span><span class="cx"> * @uses $this->features Array of all feature search terms.
</span><span class="cx"> * @uses get_pagenum()
</span><span class="cx"> * @uses _pagination_args['total_pages']
</span><span class="cx"> */
</span><del>- private function _js_vars( $extra_args = array() ) {
</del><ins>+ public function _js_vars( $extra_args = array() ) {
</ins><span class="cx"> $search_string = isset( $_REQUEST['s'] ) ? esc_attr( wp_unslash( $_REQUEST['s'] ) ) : '';
</span><span class="cx">
</span><span class="cx"> $args = array(
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-users-list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-users-list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/class-wp-users-list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -127,11 +127,11 @@
</span><span class="cx"> * filtering of the user table.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access public
</del><ins>+ * @access protected
</ins><span class="cx"> *
</span><span class="cx"> * @return array An array of HTML links, one for each view.
</span><span class="cx"> */
</span><del>- public function get_views() {
</del><ins>+ protected function get_views() {
</ins><span class="cx"> global $wp_roles, $role;
</span><span class="cx">
</span><span class="cx"> if ( $this->is_site_users ) {
</span><span class="lines">@@ -173,11 +173,11 @@
</span><span class="cx"> * Retrieve an associative array of bulk actions available on this table.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access public
</del><ins>+ * @access protected
</ins><span class="cx"> *
</span><span class="cx"> * @return array Array of bulk actions.
</span><span class="cx"> */
</span><del>- public function get_bulk_actions() {
</del><ins>+ protected function get_bulk_actions() {
</ins><span class="cx"> $actions = array();
</span><span class="cx">
</span><span class="cx"> if ( is_multisite() ) {
</span><span class="lines">@@ -195,12 +195,12 @@
</span><span class="cx"> * Output the controls to allow user roles to be changed in bulk.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access public
</del><ins>+ * @access protected
</ins><span class="cx"> *
</span><span class="cx"> * @param string $which Whether this is being invoked above ("top")
</span><span class="cx"> * or below the table ("bottom").
</span><span class="cx"> */
</span><del>- public function extra_tablenav( $which ) {
</del><ins>+ protected function extra_tablenav( $which ) {
</ins><span class="cx"> if ( 'top' != $which )
</span><span class="cx"> return;
</span><span class="cx"> ?>
</span><span class="lines">@@ -272,11 +272,11 @@
</span><span class="cx"> * Get a list of sortable columns for the list table.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><del>- * @access public
</del><ins>+ * @access protected
</ins><span class="cx"> *
</span><span class="cx"> * @return array Array of sortable columns.
</span><span class="cx"> */
</span><del>- public function get_sortable_columns() {
</del><ins>+ protected function get_sortable_columns() {
</ins><span class="cx"> $c = array(
</span><span class="cx"> 'username' => 'login',
</span><span class="cx"> 'name' => 'name',
</span></span></pre></div>
<a id="trunksrcwpadminincludeslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/list-table.php (29136 => 29137)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/list-table.php 2014-07-13 16:15:36 UTC (rev 29136)
+++ trunk/src/wp-admin/includes/list-table.php 2014-07-13 22:08:22 UTC (rev 29137)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- public function get_column_info() {
</del><ins>+ protected function get_column_info() {
</ins><span class="cx"> $columns = get_column_headers( $this->_screen );
</span><span class="cx"> $hidden = get_hidden_columns( $this->_screen );
</span><span class="cx"> $sortable = array();
</span></span></pre>
</div>
</div>
</body>
</html>