<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29095] trunk/src/wp-content/themes/twentytwelve: Twenty Twelve: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than `h3` for the toggle element.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29095">29095</a></dd>
<dt>Author</dt> <dd>lancewillett</dd>
<dt>Date</dt> <dd>2014-07-11 17:46:11 +0000 (Fri, 11 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Twenty Twelve: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than `h3` for the toggle element. Fixes <a href="http://core.trac.wordpress.org/ticket/28224">#28224</a>, props rclations.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpcontentthemestwentytwelvefunctionsphp">trunk/src/wp-content/themes/twentytwelve/functions.php</a></li>
<li><a href="#trunksrcwpcontentthemestwentytwelveheaderphp">trunk/src/wp-content/themes/twentytwelve/header.php</a></li>
<li><a href="#trunksrcwpcontentthemestwentytwelvejsnavigationjs">trunk/src/wp-content/themes/twentytwelve/js/navigation.js</a></li>
<li><a href="#trunksrcwpcontentthemestwentytwelvestylecss">trunk/src/wp-content/themes/twentytwelve/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpcontentthemestwentytwelvefunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-content/themes/twentytwelve/functions.php (29094 => 29095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-content/themes/twentytwelve/functions.php 2014-07-11 11:15:49 UTC (rev 29094)
+++ trunk/src/wp-content/themes/twentytwelve/functions.php 2014-07-11 17:46:11 UTC (rev 29095)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> wp_enqueue_script( 'comment-reply' );
</span><span class="cx">
</span><span class="cx"> // Adds JavaScript for handling the navigation menu hide-and-show behavior.
</span><del>- wp_enqueue_script( 'twentytwelve-navigation', get_template_directory_uri() . '/js/navigation.js', array( 'jquery' ), '20140608', true );
</del><ins>+ wp_enqueue_script( 'twentytwelve-navigation', get_template_directory_uri() . '/js/navigation.js', array( 'jquery' ), '20140711', true );
</ins><span class="cx">
</span><span class="cx"> $font_url = twentytwelve_get_font_url();
</span><span class="cx"> if ( ! empty( $font_url ) )
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentytwelveheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-content/themes/twentytwelve/header.php (29094 => 29095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-content/themes/twentytwelve/header.php 2014-07-11 11:15:49 UTC (rev 29094)
+++ trunk/src/wp-content/themes/twentytwelve/header.php 2014-07-11 17:46:11 UTC (rev 29095)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> </hgroup>
</span><span class="cx">
</span><span class="cx"> <nav id="site-navigation" class="main-navigation" role="navigation">
</span><del>- <h3 class="menu-toggle"><?php _e( 'Menu', 'twentytwelve' ); ?></h3>
</del><ins>+ <button class="menu-toggle"><?php _e( 'Menu', 'twentytwelve' ); ?></button>
</ins><span class="cx"> <a class="assistive-text" href="#content" title="<?php esc_attr_e( 'Skip to content', 'twentytwelve' ); ?>"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a>
</span><span class="cx"> <?php wp_nav_menu( array( 'theme_location' => 'primary', 'menu_class' => 'nav-menu' ) ); ?>
</span><span class="cx"> </nav><!-- #site-navigation -->
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentytwelvejsnavigationjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-content/themes/twentytwelve/js/navigation.js (29094 => 29095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-content/themes/twentytwelve/js/navigation.js 2014-07-11 11:15:49 UTC (rev 29094)
+++ trunk/src/wp-content/themes/twentytwelve/js/navigation.js 2014-07-11 17:46:11 UTC (rev 29095)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- button = nav.getElementsByTagName( 'h3' )[0];
</del><ins>+ button = nav.getElementsByTagName( 'button' )[0];
</ins><span class="cx"> menu = nav.getElementsByTagName( 'ul' )[0];
</span><span class="cx"> if ( ! button ) {
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentytwelvestylecss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-content/themes/twentytwelve/style.css (29094 => 29095)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-content/themes/twentytwelve/style.css 2014-07-11 11:15:49 UTC (rev 29094)
+++ trunk/src/wp-content/themes/twentytwelve/style.css 2014-07-11 17:46:11 UTC (rev 29095)
</span><span class="lines">@@ -272,6 +272,7 @@
</span><span class="cx"> cursor: default;
</span><span class="cx"> }
</span><span class="cx"> .menu-toggle:hover,
</span><ins>+.menu-toggle:focus,
</ins><span class="cx"> button:hover,
</span><span class="cx"> input[type="submit"]:hover,
</span><span class="cx"> input[type="button"]:hover,
</span></span></pre>
</div>
</div>
</body>
</html>