<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29063] trunk: XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29063">29063</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2014-07-10 14:16:20 +0000 (Thu, 10 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.
Fixes <a href="http://core.trac.wordpress.org/ticket/28601">#28601</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpxmlrpcserverphp">trunk/src/wp-includes/class-wp-xmlrpc-server.php</a></li>
<li><a href="#trunktestsphpunittestsxmlrpcwpnewPostphp">trunk/tests/phpunit/tests/xmlrpc/wp/newPost.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpxmlrpcserverphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-xmlrpc-server.php (29062 => 29063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-xmlrpc-server.php 2014-07-10 14:05:22 UTC (rev 29062)
+++ trunk/src/wp-includes/class-wp-xmlrpc-server.php 2014-07-10 14:16:20 UTC (rev 29063)
</span><span class="lines">@@ -1103,13 +1103,13 @@
</span><span class="cx"> return $this->error;
</span><span class="cx">
</span><span class="cx"> // convert the date field back to IXR form
</span><del>- if ( isset( $content_struct['post_date'] ) ) {
</del><ins>+ if ( isset( $content_struct['post_date'] ) && ! is_a( $content_struct['post_date'], 'IXR_Date' ) ) {
</ins><span class="cx"> $content_struct['post_date'] = $this->_convert_date( $content_struct['post_date'] );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
</span><span class="cx"> // since _insert_post will ignore the non-GMT date if the GMT date is set
</span><del>- if ( isset( $content_struct['post_date_gmt'] ) ) {
</del><ins>+ if ( isset( $content_struct['post_date_gmt'] ) && ! is_a( $content_struct['post_date_gmt'], 'IXR_Date' ) ) {
</ins><span class="cx"> if ( $content_struct['post_date_gmt'] == '0000-00-00 00:00:00' || isset( $content_struct['post_date'] ) ) {
</span><span class="cx"> unset( $content_struct['post_date_gmt'] );
</span><span class="cx"> } else {
</span></span></pre></div>
<a id="trunktestsphpunittestsxmlrpcwpnewPostphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/xmlrpc/wp/newPost.php (29062 => 29063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/xmlrpc/wp/newPost.php 2014-07-10 14:05:22 UTC (rev 29062)
+++ trunk/tests/phpunit/tests/xmlrpc/wp/newPost.php 2014-07-10 14:16:20 UTC (rev 29063)
</span><span class="lines">@@ -357,4 +357,30 @@
</span><span class="cx"> $this->assertEquals( $date_string , $fetched_post->post_date_gmt );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ /**
+ * @ticket 28601
+ */
+ function test_valid_IXR_post_date() {
+ $this->make_user_by_role( 'author' );
+ $date_string = '1984-01-11 05:00:00';
+ $post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
+ $result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
+ $fetched_post = get_post( $result );
+ $this->assertStringMatchesFormat( '%d', $result );
+ $this->assertEquals( $date_string , $fetched_post->post_date );
+ }
+
+ /**
+ * @ticket 28601
+ */
+ function test_valid_IXR_post_date_gmt() {
+ $this->make_user_by_role( 'author' );
+ $date_string = '1984-01-11 05:00:00';
+ $post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date_gmt' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
+ $result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
+ $fetched_post = get_post( $result );
+ $this->assertStringMatchesFormat( '%d', $result );
+ $this->assertEquals( $date_string , $fetched_post->post_date_gmt );
+ }
+
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>