<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29035] trunk/src: Customizer panels:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/29035">29035</a></dd>
<dt>Author</dt> <dd>helen</dd>
<dt>Date</dt> <dd>2014-07-08 20:18:30 +0000 (Tue, 08 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Customizer panels:
* Close all accordion sections when going in and out of panels.
* Fix panel positioning when top-level Customizer controls are scrolled down.
* Keyboard accessibility: only focus on visible elements and transfer between them as needed when navigating around panels.
props celloexpressions. see <a href="http://core.trac.wordpress.org/ticket/27406">#27406</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjsaccordionjs">trunk/src/wp-admin/js/accordion.js</a></li>
<li><a href="#trunksrcwpincludesclasswpcustomizesectionphp">trunk/src/wp-includes/class-wp-customize-section.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjsaccordionjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/accordion.js (29034 => 29035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/accordion.js 2014-07-08 19:52:17 UTC (rev 29034)
+++ trunk/src/wp-admin/js/accordion.js 2014-07-08 20:18:30 UTC (rev 29035)
</span><span class="lines">@@ -69,26 +69,41 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function panelSwitch( panel ) {
</span><del>- var position,
</del><ins>+ var position, scroll,
</ins><span class="cx"> section = panel.closest( '.accordion-section' ),
</span><del>- container = section.closest( '.wp-full-overlay' ),
- siblings = container.find( '.accordion-section.open' ),
</del><ins>+ overlay = section.closest( '.wp-full-overlay' ),
+ container = section.closest( '.accordion-container' ),
+ siblings = container.find( '.open' ),
+ topPanel = overlay.find( '#customize-theme-controls > ul > .accordion-section > .accordion-section-title' ).add( '#customize-info > .accordion-section-title' ),
+ backBtn = section.find( '.control-panel-back' ),
+ panelTitle = section.find( '.accordion-section-title' ).first(),
</ins><span class="cx"> content = section.find( '.control-panel-content' );
</span><span class="cx">
</span><span class="cx"> if ( section.hasClass( 'current-panel' ) ) {
</span><span class="cx"> section.toggleClass( 'current-panel' );
</span><del>- container.toggleClass( 'in-sub-panel' );
</del><ins>+ overlay.toggleClass( 'in-sub-panel' );
</ins><span class="cx"> content.delay( 180 ).hide( 0, function() {
</span><span class="cx"> content.css( 'margin-top', 'inherit' ); // Reset
</span><span class="cx"> } );
</span><ins>+ topPanel.attr( 'tabindex', '0' );
+ backBtn.attr( 'tabindex', '-1' );
+ panelTitle.focus();
+ container.scrollTop( 0 );
</ins><span class="cx"> } else {
</span><ins>+ // Close all open sections in any accordion level.
</ins><span class="cx"> siblings.removeClass( 'open' );
</span><ins>+ siblings.find( sectionContent ).show().slideUp( 0 );
</ins><span class="cx"> content.show( 0, function() {
</span><span class="cx"> position = content.offset().top;
</span><del>- content.css( 'margin-top', ( 45 - position ) );
</del><ins>+ scroll = container.scrollTop();
+ content.css( 'margin-top', ( 45 - position - scroll ) );
</ins><span class="cx"> section.toggleClass( 'current-panel' );
</span><del>- container.toggleClass( 'in-sub-panel' );
</del><ins>+ overlay.toggleClass( 'in-sub-panel' );
+ container.scrollTop( 0 );
</ins><span class="cx"> } );
</span><ins>+ topPanel.attr( 'tabindex', '-1' );
+ backBtn.attr( 'tabindex', '0' );
+ backBtn.focus();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpcustomizesectionphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-customize-section.php (29034 => 29035)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-customize-section.php 2014-07-08 19:52:17 UTC (rev 29034)
+++ trunk/src/wp-includes/class-wp-customize-section.php 2014-07-08 20:18:30 UTC (rev 29035)
</span><span class="lines">@@ -240,7 +240,7 @@
</span><span class="cx"> ?>
</span><span class="cx"> <li id="accordion-section-<?php echo esc_attr( $this->id ); ?>" class="control-section control-panel accordion-section">
</span><span class="cx"> <h3 class="accordion-section-title" tabindex="0"><?php echo esc_html( $this->title ); ?></h3>
</span><del>- <span class="control-panel-back" tabindex="0"><span class="screen-reader-text">Back to Customize</span></span>
</del><ins>+ <span class="control-panel-back" tabindex="-1"><span class="screen-reader-text">Back to Customize</span></span>
</ins><span class="cx"> <ul class="accordion-sub-container control-panel-content">
</span><span class="cx"> <li class="accordion-section control-section<?php if ( empty( $this->description ) ) echo ' cannot-expand'; ?>">
</span><span class="cx"> <div class="accordion-section-title" tabindex="0">
</span></span></pre>
</div>
</div>
</body>
</html>