<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28897] trunk/src: Fix feature pointer positioning issues for both LTR and RTL.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28897">28897</a></dd>
<dt>Author</dt> <dd>SergeyBiryukov</dd>
<dt>Date</dt> <dd>2014-06-29 16:05:53 +0000 (Sun, 29 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix feature pointer positioning issues for both LTR and RTL.
fixes <a href="http://core.trac.wordpress.org/ticket/28062">#28062</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludestemplatephp">trunk/src/wp-admin/includes/template.php</a></li>
<li><a href="#trunksrcwpincludescsswppointercss">trunk/src/wp-includes/css/wp-pointer.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludestemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/template.php (28896 => 28897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/template.php 2014-06-29 14:09:39 UTC (rev 28896)
+++ trunk/src/wp-admin/includes/template.php 2014-06-29 16:05:53 UTC (rev 28897)
</span><span class="lines">@@ -1992,7 +1992,7 @@
</span><span class="cx">
</span><span class="cx"> self::print_js( 'wp360_revisions', '.misc-pub-section.misc-pub-revisions', array(
</span><span class="cx"> 'content' => $content,
</span><del>- 'position' => array( 'edge' => is_rtl() ? 'left' : 'right', 'align' => 'center', 'my' => is_rtl() ? 'left' : 'right-14px' ),
</del><ins>+ 'position' => array( 'edge' => is_rtl() ? 'left' : 'right', 'align' => 'center' ),
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2020,7 +2020,7 @@
</span><span class="cx">
</span><span class="cx"> if ( 'themes' === get_current_screen()->id ) {
</span><span class="cx"> $selector = '.theme.active .customize';
</span><del>- $position = array( 'edge' => is_rtl() ? 'right' : 'left', 'align' => 'center', 'my' => is_rtl() ? 'right-13px' : '' );
</del><ins>+ $position = array( 'edge' => is_rtl() ? 'right' : 'left', 'align' => 'center' );
</ins><span class="cx"> } else {
</span><span class="cx"> $selector = 'a[href="customize.php"]';
</span><span class="cx"> if ( is_rtl() ) {
</span></span></pre></div>
<a id="trunksrcwpincludescsswppointercss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/wp-pointer.css (28896 => 28897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/wp-pointer.css 2014-06-29 14:09:39 UTC (rev 28896)
+++ trunk/src/wp-includes/css/wp-pointer.css 2014-06-29 16:05:53 UTC (rev 28897)
</span><span class="lines">@@ -106,6 +106,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-pointer-bottom {
</span><ins>+ margin-top: -13px;
</ins><span class="cx"> padding-bottom: 13px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -115,6 +116,7 @@
</span><span class="cx"> }
</span><span class="cx"> /* @noflip */
</span><span class="cx"> .wp-pointer-right {
</span><ins>+ margin-left: -13px;
</ins><span class="cx"> padding-right: 13px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -139,10 +141,11 @@
</span><span class="cx"> border-bottom-color: #3592b6;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-pointer-top .wp-pointer-arrow:before,
-.wp-pointer-undefined .wp-pointer-arrow:before {
</del><ins>+.wp-pointer-top .wp-pointer-arrow-inner,
+.wp-pointer-undefined .wp-pointer-arrow-inner {
+ top: 1px;
</ins><span class="cx"> margin-left: -13px;
</span><del>- margin-top: -11px;
</del><ins>+ margin-top: -13px;
</ins><span class="cx"> border: 13px solid transparent;
</span><span class="cx"> border-bottom-color: #2ea2cc;
</span><span class="cx"> display: block;
</span><span class="lines">@@ -155,9 +158,10 @@
</span><span class="cx"> border-top-color: #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-pointer-bottom .wp-pointer-arrow:before {
</del><ins>+.wp-pointer-bottom .wp-pointer-arrow-inner {
+ bottom: 1px;
</ins><span class="cx"> margin-left: -13px;
</span><del>- margin-top: -14px;
</del><ins>+ margin-bottom: -13px;
</ins><span class="cx"> border: 13px solid transparent;
</span><span class="cx"> border-top-color: #fff;
</span><span class="cx"> display: block;
</span><span class="lines">@@ -171,8 +175,10 @@
</span><span class="cx"> border-right-color: #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-pointer-left .wp-pointer-arrow:before {
- margin-left: -14px;
</del><ins>+/* @noflip */
+.wp-pointer-left .wp-pointer-arrow-inner {
+ left: 1px;
+ margin-left: -13px;
</ins><span class="cx"> margin-top: -13px;
</span><span class="cx"> border: 13px solid transparent;
</span><span class="cx"> border-right-color: #fff;
</span><span class="lines">@@ -182,13 +188,15 @@
</span><span class="cx">
</span><span class="cx"> /* @noflip */
</span><span class="cx"> .wp-pointer-right .wp-pointer-arrow {
</span><del>- right:0;
</del><ins>+ right: 0;
</ins><span class="cx"> border-width: 13px 0 13px 13px;
</span><span class="cx"> border-left-color: #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-pointer-right .wp-pointer-arrow:before {
- margin-left: -14px;
</del><ins>+/* @noflip */
+.wp-pointer-right .wp-pointer-arrow-inner {
+ right: 1px;
+ margin-right: -13px;
</ins><span class="cx"> margin-top: -13px;
</span><span class="cx"> border: 13px solid transparent;
</span><span class="cx"> border-left-color: #fff;
</span><span class="lines">@@ -196,12 +204,6 @@
</span><span class="cx"> content: ' ';
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.rtl .wp-pointer-arrow:before {
- -webkit-transform: rotateY(180deg);
- -ms-transform: rotateY(180deg);
- transform: rotateY(180deg);
-}
-
</del><span class="cx"> /* Disable pointers at responsive sizes */
</span><span class="cx"> @media screen and ( max-width: 782px ) {
</span><span class="cx"> .wp-pointer {
</span></span></pre>
</div>
</div>
</body>
</html>