<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28882] trunk: `wp_extract_urls()` should not match dates.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28882">28882</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-06-28 04:15:30 +0000 (Sat, 28 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>`wp_extract_urls()` should not match dates.
Updates unit tests.
Props hinnerk, sergej.mueller.
Fixes <a href="http://core.trac.wordpress.org/ticket/28222">#28222</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesfunctionsphp">trunk/src/wp-includes/functions.php</a></li>
<li><a href="#trunktestsphpunittestsfunctionsphp">trunk/tests/phpunit/tests/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/functions.php (28881 => 28882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/functions.php 2014-06-28 04:06:12 UTC (rev 28881)
+++ trunk/src/wp-includes/functions.php 2014-06-28 04:15:30 UTC (rev 28882)
</span><span class="lines">@@ -441,7 +441,18 @@
</span><span class="cx"> */
</span><span class="cx"> function wp_extract_urls( $content ) {
</span><span class="cx"> preg_match_all(
</span><del>- "#((?:[\w-]+://?|[\w\d]+[.])[^\s()<>]+[.](?:\([\w\d]+\)|(?:[^`!()\[\]{};:'\".,<>?«»“”‘’\s]|(?:[:]\d+)?/?)+))#",
</del><ins>+ "#("
+ . "(?: ([\w-]+:)?//? )"
+ . "[^\s()<>]+"
+ . "[.]"
+ . "(?:"
+ . "\([\w\d]+\) |"
+ . "(?:"
+ . "[^`!()\[\]{};:'\".,<>?«»“”‘’\s] |"
+ . "(?: [:]\d+ )?/?"
+ . ")+"
+ . ")"
+ . ")#x",
</ins><span class="cx"> $content,
</span><span class="cx"> $post_links
</span><span class="cx"> );
</span></span></pre></div>
<a id="trunktestsphpunittestsfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/functions.php (28881 => 28882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/functions.php 2014-06-28 04:06:12 UTC (rev 28881)
+++ trunk/tests/phpunit/tests/functions.php 2014-06-28 04:15:30 UTC (rev 28882)
</span><span class="lines">@@ -370,6 +370,7 @@
</span><span class="cx"> $original_urls = array(
</span><span class="cx"> 'http://woo.com/1,2,3,4,5,6/-1-2-3-4-/woo.html',
</span><span class="cx"> 'http://this.com',
</span><ins>+ 'http://127.0.0.1',
</ins><span class="cx"> 'http://www111.urwyeoweytwutreyytqytwetowteuiiu.com/?346236346326&2134362574863.437',
</span><span class="cx"> 'http://wordpress-core/1,2,3,4,5,6/-1-2-3-4-/woo.html',
</span><span class="cx"> 'http://wordpress-core.com:8080/',
</span><span class="lines">@@ -419,7 +420,8 @@
</span><span class="cx"> 'http://تونس.icom.museum',
</span><span class="cx"> 'http://türkiye.icom.museum',
</span><span class="cx"> 'http://украина.icom.museum',
</span><del>- 'http://việtnam.icom.museum'
</del><ins>+ 'http://việtnam.icom.museum',
+ 'ftp://127.0.0.1/'
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> $blob ="
</span><span class="lines">@@ -427,6 +429,8 @@
</span><span class="cx">
</span><span class="cx"> http://this.com
</span><span class="cx">
</span><ins>+ http://127.0.0.1
+
</ins><span class="cx"> http://www111.urwyeoweytwutreyytqytwetowteuiiu.com/?346236346326&2134362574863.437
</span><span class="cx">
</span><span class="cx"> http://wordpress-core/1,2,3,4,5,6/-1-2-3-4-/woo.html
</span><span class="lines">@@ -476,6 +480,7 @@
</span><span class="cx"> http://türkiye.icom.museum
</span><span class="cx"> http://украина.icom.museum
</span><span class="cx"> http://việtnam.icom.museum
</span><ins>+ ftp://127.0.0.1/
</ins><span class="cx"> ";
</span><span class="cx">
</span><span class="cx"> $urls = wp_extract_urls( $blob );
</span><span class="lines">@@ -493,7 +498,7 @@
</span><span class="cx">
</span><span class="cx"> $blob ="Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor
</span><span class="cx"> incididunt ut labore http://woo.com/1,2,3,4,5,6/-1-2-3-4-/woo.html et dolore magna aliqua.
</span><del>- Ut http://this.com enim ad minim veniam, quis nostrud exercitation ullamco
</del><ins>+ Ut http://this.com enim ad minim veniam, quis nostrud exercitation 16.06. to 18.06.2014 ullamco http://127.0.0.1
</ins><span class="cx"> laboris nisi ut aliquip ex http://www111.urwyeoweytwutreyytqytwetowteuiiu.com/?346236346326&2134362574863.437 ea
</span><span class="cx"> commodo consequat. http://wordpress-core/1,2,3,4,5,6/-1-2-3-4-/woo.html Duis aute irure dolor in reprehenderit in voluptate
</span><span class="cx"> velit esse http://wordpress-core.com:8080/ cillum dolore eu fugiat nulla <A href=\"http://www.website.com:5000\">http://www.website.com:5000</B> pariatur. Excepteur sint occaecat cupidatat non proident,
</span><span class="lines">@@ -502,12 +507,12 @@
</span><span class="cx"> $urls = wp_extract_urls( $blob );
</span><span class="cx"> $this->assertNotEmpty( $urls );
</span><span class="cx"> $this->assertInternalType( 'array', $urls );
</span><del>- $this->assertCount( 7, $urls );
- $this->assertEquals( array_slice( $original_urls, 0, 7 ), $urls );
</del><ins>+ $this->assertCount( 8, $urls );
+ $this->assertEquals( array_slice( $original_urls, 0, 8 ), $urls );
</ins><span class="cx">
</span><span class="cx"> $blob = 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor
</span><span class="cx"> incididunt ut labore <a href="http://woo.com/1,2,3,4,5,6/-1-2-3-4-/woo.html">343462^</a> et dolore magna aliqua.
</span><del>- Ut <a href="http://this.com">&3640i6p1yi499</a> enim ad minim veniam, quis nostrud exercitation ullamco
</del><ins>+ Ut <a href="http://this.com">&3640i6p1yi499</a> enim ad minim veniam, quis nostrud exercitation 16.06. to 18.06.2014 ullamco <a href="http://127.0.0.1">localhost</a>
</ins><span class="cx"> laboris nisi ut aliquip ex <a href="http://www111.urwyeoweytwutreyytqytwetowteuiiu.com/?346236346326&2134362574863.437">343462^</a> ea
</span><span class="cx"> commodo consequat. <a href="http://wordpress-core/1,2,3,4,5,6/-1-2-3-4-/woo.html">343462^</a> Duis aute irure dolor in reprehenderit in voluptate
</span><span class="cx"> velit esse <a href="http://wordpress-core.com:8080/">-3-4--321-64-4@#!$^$!@^@^</a> cillum dolore eu <A href="http://www.website.com:5000">http://www.website.com:5000</B> fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident,
</span><span class="lines">@@ -516,7 +521,7 @@
</span><span class="cx"> $urls = wp_extract_urls( $blob );
</span><span class="cx"> $this->assertNotEmpty( $urls );
</span><span class="cx"> $this->assertInternalType( 'array', $urls );
</span><del>- $this->assertCount( 7, $urls );
- $this->assertEquals( array_slice( $original_urls, 0, 7 ), $urls );
</del><ins>+ $this->assertCount( 8, $urls );
+ $this->assertEquals( array_slice( $original_urls, 0, 8 ), $urls );
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>