<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28539] trunk/src: These functions import `$wpdb` but do not use it.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28539">28539</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-05-22 17:36:42 +0000 (Thu, 22 May 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>These functions import `$wpdb` but do not use it.

See <a href="http://core.trac.wordpress.org/ticket/27882">#27882</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesajaxactionsphp">trunk/src/wp-admin/includes/ajax-actions.php</a></li>
<li><a href="#trunksrcwpadminincludesdashboardphp">trunk/src/wp-admin/includes/dashboard.php</a></li>
<li><a href="#trunksrcwpadminincludesmetaboxesphp">trunk/src/wp-admin/includes/meta-boxes.php</a></li>
<li><a href="#trunksrcwpadminincludespostphp">trunk/src/wp-admin/includes/post.php</a></li>
<li><a href="#trunksrcwpincludescapabilitiesphp">trunk/src/wp-includes/capabilities.php</a></li>
<li><a href="#trunksrcwpincludesclasswpxmlrpcserverphp">trunk/src/wp-includes/class-wp-xmlrpc-server.php</a></li>
<li><a href="#trunksrcwpincludesgeneraltemplatephp">trunk/src/wp-includes/general-template.php</a></li>
<li><a href="#trunksrcwpincludestaxonomyphp">trunk/src/wp-includes/taxonomy.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesajaxactionsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/ajax-actions.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/ajax-actions.php     2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-admin/includes/ajax-actions.php        2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -103,8 +103,6 @@
</span><span class="cx">  * @since 3.1.0
</span><span class="cx">  */
</span><span class="cx"> function wp_ajax_ajax_tag_search() {
</span><del>-       global $wpdb;
-
</del><span class="cx">   if ( isset( $_GET['tax'] ) ) {
</span><span class="cx">          $taxonomy = sanitize_key( $_GET['tax'] );
</span><span class="cx">          $tax = get_taxonomy( $taxonomy );
</span><span class="lines">@@ -894,7 +892,7 @@
</span><span class="cx">  * @param string $action Action to perform.
</span><span class="cx">  */
</span><span class="cx"> function wp_ajax_replyto_comment( $action ) {
</span><del>-       global $wp_list_table, $wpdb;
</del><ins>+        global $wp_list_table;
</ins><span class="cx">   if ( empty( $action ) )
</span><span class="cx">          $action = 'replyto-comment';
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunksrcwpadminincludesdashboardphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/dashboard.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/dashboard.php        2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-admin/includes/dashboard.php   2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -761,8 +761,6 @@
</span><span class="cx">  * @return bool False if no comments were found. True otherwise.
</span><span class="cx">  */
</span><span class="cx"> function wp_dashboard_recent_comments( $total_items = 5 ) {
</span><del>-       global $wpdb;
-
</del><span class="cx">   // Select all comment types and filter out spam later for better query performance.
</span><span class="cx">  $comments = array();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunksrcwpadminincludesmetaboxesphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/meta-boxes.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/meta-boxes.php       2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-admin/includes/meta-boxes.php  2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -623,8 +623,6 @@
</span><span class="cx">  * @param object $post
</span><span class="cx">  */
</span><span class="cx"> function post_comment_meta_box( $post ) {
</span><del>-       global $wpdb;
-
</del><span class="cx">   wp_nonce_field( 'get-comments', 'add_comment_nonce', false );
</span><span class="cx">  ?>
</span><span class="cx">  <p class="hide-if-no-js" id="add-new-comment"><a class="button" href="#commentstatusdiv" onclick="window.commentReply && commentReply.addcomment(<?php echo $post->ID; ?>);return false;"><?php _e('Add comment'); ?></a></p>
</span></span></pre></div>
<a id="trunksrcwpadminincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/post.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/post.php     2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-admin/includes/post.php        2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -518,8 +518,6 @@
</span><span class="cx">  * @return WP_Post Post object containing all the default post data as attributes
</span><span class="cx">  */
</span><span class="cx"> function get_default_post_to_edit( $post_type = 'post', $create_in_db = false ) {
</span><del>-       global $wpdb;
-
</del><span class="cx">   $post_title = '';
</span><span class="cx">  if ( !empty( $_REQUEST['post_title'] ) )
</span><span class="cx">          $post_title = esc_html( wp_unslash( $_REQUEST['post_title'] ));
</span><span class="lines">@@ -733,7 +731,6 @@
</span><span class="cx">  * @return unknown
</span><span class="cx">  */
</span><span class="cx"> function add_meta( $post_ID ) {
</span><del>-       global $wpdb;
</del><span class="cx">   $post_ID = (int) $post_ID;
</span><span class="cx"> 
</span><span class="cx">  $metakeyselect = isset($_POST['metakeyselect']) ? wp_unslash( trim( $_POST['metakeyselect'] ) ) : '';
</span></span></pre></div>
<a id="trunksrcwpincludescapabilitiesphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/capabilities.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/capabilities.php   2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-includes/capabilities.php      2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx">          if ( ! $this->use_db )
</span><span class="cx">                  return;
</span><span class="cx"> 
</span><del>-               global $wpdb, $wp_user_roles;
</del><ins>+                global $wpdb;
</ins><span class="cx"> 
</span><span class="cx">          // Duplicated from _init() to avoid an extra function call.
</span><span class="cx">          $this->role_key = $wpdb->get_blog_prefix() . 'user_roles';
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpxmlrpcserverphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-xmlrpc-server.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-xmlrpc-server.php 2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-includes/class-wp-xmlrpc-server.php    2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -3190,8 +3190,6 @@
</span><span class="cx">   * @return mixed {@link wp_new_comment()}
</span><span class="cx">   */
</span><span class="cx">  public function wp_newComment($args) {
</span><del>-               global $wpdb;
-
</del><span class="cx">           $this->escape($args);
</span><span class="cx"> 
</span><span class="cx">          $blog_id        = (int) $args[0];
</span></span></pre></div>
<a id="trunksrcwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/general-template.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/general-template.php       2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-includes/general-template.php  2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -753,7 +753,7 @@
</span><span class="cx">  * @return string|null String on retrieve, null when displaying.
</span><span class="cx">  */
</span><span class="cx"> function wp_title($sep = '&raquo;', $display = true, $seplocation = '') {
</span><del>-       global $wpdb, $wp_locale;
</del><ins>+        global $wp_locale;
</ins><span class="cx"> 
</span><span class="cx">  $m = get_query_var('m');
</span><span class="cx">  $year = get_query_var('year');
</span></span></pre></div>
<a id="trunksrcwpincludestaxonomyphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/taxonomy.php (28538 => 28539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/taxonomy.php       2014-05-22 17:34:34 UTC (rev 28538)
+++ trunk/src/wp-includes/taxonomy.php  2014-05-22 17:36:42 UTC (rev 28539)
</span><span class="lines">@@ -3161,8 +3161,6 @@
</span><span class="cx">  * @return bool Always true when complete.
</span><span class="cx">  */
</span><span class="cx"> function wp_update_term_count_now( $terms, $taxonomy ) {
</span><del>-       global $wpdb;
-
</del><span class="cx">   $terms = array_map('intval', $terms);
</span><span class="cx"> 
</span><span class="cx">  $taxonomy = get_taxonomy($taxonomy);
</span></span></pre>
</div>
</div>

</body>
</html>