<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28521] trunk/src: Some classes with `__get()` method also need `__set()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28521">28521</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-05-19 06:31:00 +0000 (Mon, 19 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Some classes with `__get()` method also need `__set()`.
See <a href="http://core.trac.wordpress.org/ticket/27881">#27881</a>, <a href="http://core.trac.wordpress.org/ticket/22234">#22234</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincustombackgroundphp">trunk/src/wp-admin/custom-background.php</a></li>
<li><a href="#trunksrcwpadmincustomheaderphp">trunk/src/wp-admin/custom-header.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpfilesystembasephp">trunk/src/wp-admin/includes/class-wp-filesystem-base.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpincludescachephp">trunk/src/wp-includes/cache.php</a></li>
<li><a href="#trunksrcwpincludesclasswpajaxresponsephp">trunk/src/wp-includes/class-wp-ajax-response.php</a></li>
<li><a href="#trunksrcwpincludesclasswperrorphp">trunk/src/wp-includes/class-wp-error.php</a></li>
<li><a href="#trunksrcwpincludesclasswpwalkerphp">trunk/src/wp-includes/class-wp-walker.php</a></li>
<li><a href="#trunksrcwpincludesclasswpphp">trunk/src/wp-includes/class-wp.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincustombackgroundphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/custom-background.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/custom-background.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-admin/custom-background.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -70,6 +70,19 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+
+ /**
</ins><span class="cx"> * Set up the hooks for the Custom Background admin page.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.0.0
</span></span></pre></div>
<a id="trunksrcwpadmincustomheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/custom-header.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/custom-header.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-admin/custom-header.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -92,6 +92,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Set up the hooks for the Custom Header admin page.
</span><span class="cx"> *
</span><span class="cx"> * @since 2.1.0
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpfilesystembasephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-filesystem-base.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-filesystem-base.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-admin/includes/class-wp-filesystem-base.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -56,6 +56,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Return the path on the remote filesystem of ABSPATH.
</span><span class="cx"> *
</span><span class="cx"> * @access public
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/class-wp-list-table.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -107,6 +107,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Make private/protected methods readable for backwards compatibility
</span><span class="cx"> *
</span><span class="cx"> * @since 4.0.0
</span></span></pre></div>
<a id="trunksrcwpincludescachephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/cache.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/cache.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-includes/cache.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -268,7 +268,7 @@
</span><span class="cx"> * @access private
</span><span class="cx"> * @since 2.0.0
</span><span class="cx"> */
</span><del>- public $cache = array();
</del><ins>+ private $cache = array();
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * The amount of times the cache data was already stored in the cache.
</span><span class="lines">@@ -318,6 +318,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Adds data to the cache if it doesn't already exist.
</span><span class="cx"> *
</span><span class="cx"> * @uses WP_Object_Cache::_exists Checks to see if the cache already has data.
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpajaxresponsephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-ajax-response.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-ajax-response.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-includes/class-wp-ajax-response.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -41,6 +41,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Append to XML response based on given arguments.
</span><span class="cx"> *
</span><span class="cx"> * The arguments that can be passed in the $args parameter are below. It is
</span></span></pre></div>
<a id="trunksrcwpincludesclasswperrorphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-error.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-error.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-includes/class-wp-error.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -76,6 +76,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Retrieve all error codes.
</span><span class="cx"> *
</span><span class="cx"> * @since 2.1.0
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpwalkerphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp-walker.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp-walker.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-includes/class-wp-walker.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -51,6 +51,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Starts the list before the elements are added.
</span><span class="cx"> *
</span><span class="cx"> * The $args parameter holds additional values that may be used with the child
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/class-wp.php (28520 => 28521)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/class-wp.php 2014-05-19 06:24:06 UTC (rev 28520)
+++ trunk/src/wp-includes/class-wp.php 2014-05-19 06:31:00 UTC (rev 28521)
</span><span class="lines">@@ -674,6 +674,18 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Make private properties setable for backwards compatibility
+ *
+ * @since 4.0.0
+ * @param string $name
+ * @param string $value
+ * @return mixed
+ */
+ public function __set( $name, $value ) {
+ return $this->$name = $value;
+ }
+
+ /**
</ins><span class="cx"> * Make private/protected methods readable for backwards compatibility
</span><span class="cx"> *
</span><span class="cx"> * @since 4.0.0
</span></span></pre>
</div>
</div>
</body>
</html>