<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28427] trunk/src/wp-includes/comment.php: Eliminate the use of `extract()` in `wp_update_comment()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28427">28427</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-05-15 06:36:17 +0000 (Thu, 15 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Eliminate the use of `extract()` in `wp_update_comment()`. All unit tests pass.
See <a href="http://core.trac.wordpress.org/ticket/22400">#22400</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/comment.php (28426 => 28427)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/comment.php 2014-05-15 06:21:51 UTC (rev 28426)
+++ trunk/src/wp-includes/comment.php 2014-05-15 06:36:17 UTC (rev 28427)
</span><span class="lines">@@ -1805,9 +1805,9 @@
</span><span class="cx">
</span><span class="cx"> // First, get all of the original fields
</span><span class="cx"> $comment = get_comment($commentarr['comment_ID'], ARRAY_A);
</span><del>- if ( empty( $comment ) )
</del><ins>+ if ( empty( $comment ) ) {
</ins><span class="cx"> return 0;
</span><del>-
</del><ins>+ }
</ins><span class="cx"> // Escape data pulled from DB.
</span><span class="cx"> $comment = wp_slash($comment);
</span><span class="cx">
</span><span class="lines">@@ -1819,7 +1819,7 @@
</span><span class="cx"> $commentarr = wp_filter_comment( $commentarr );
</span><span class="cx">
</span><span class="cx"> // Now extract the merged array.
</span><del>- extract(wp_unslash($commentarr), EXTR_SKIP);
</del><ins>+ $data = wp_unslash( $commentarr );
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Filter the comment content before it is updated in the database.
</span><span class="lines">@@ -1828,22 +1828,26 @@
</span><span class="cx"> *
</span><span class="cx"> * @param string $comment_content The comment data.
</span><span class="cx"> */
</span><del>- $comment_content = apply_filters( 'comment_save_pre', $comment_content );
</del><ins>+ $data['comment_content'] = apply_filters( 'comment_save_pre', $data['comment_content'] );
</ins><span class="cx">
</span><del>- $comment_date_gmt = get_gmt_from_date($comment_date);
</del><ins>+ $data['comment_date_gmt'] = get_gmt_from_date( $data['comment_date'] );
</ins><span class="cx">
</span><del>- if ( !isset($comment_approved) )
- $comment_approved = 1;
- else if ( 'hold' == $comment_approved )
- $comment_approved = 0;
- else if ( 'approve' == $comment_approved )
- $comment_approved = 1;
</del><ins>+ if ( ! isset( $data['comment_approved'] ) ) {
+ $data['comment_approved'] = 1;
+ } else if ( 'hold' == $data['comment_approved'] ) {
+ $data['comment_approved'] = 0;
+ } else if ( 'approve' == $data['comment_approved'] ) {
+ $data['comment_approved'] = 1;
+ }
</ins><span class="cx">
</span><del>- $data = compact( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent' );
</del><ins>+ $comment_ID = $data['comment_ID'];
+ $comment_post_ID = $data['comment_post_ID'];
+ $keys = array( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent' );
+ $data = wp_array_slice_assoc( $data, $keys );
</ins><span class="cx"> $rval = $wpdb->update( $wpdb->comments, $data, compact( 'comment_ID' ) );
</span><span class="cx">
</span><del>- clean_comment_cache($comment_ID);
- wp_update_comment_count($comment_post_ID);
</del><ins>+ clean_comment_cache( $comment_ID );
+ wp_update_comment_count( $comment_post_ID );
</ins><span class="cx"> /**
</span><span class="cx"> * Fires immediately after a comment is updated in the database.
</span><span class="cx"> *
</span></span></pre>
</div>
</div>
</body>
</html>