<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28347] trunk/src/wp-admin/includes/post.php: Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28347">28347</a></dd>
<dt>Author</dt> <dd>DrewAPicture</dd>
<dt>Date</dt> <dd>2014-05-08 08:15:48 +0000 (Thu, 08 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly.
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.
Props Otto42 for the initial patch.
See <a href="http://core.trac.wordpress.org/ticket/26869">#26869</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludespostphp">trunk/src/wp-admin/includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/post.php (28346 => 28347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/post.php 2014-05-07 20:42:25 UTC (rev 28346)
+++ trunk/src/wp-admin/includes/post.php 2014-05-08 08:15:48 UTC (rev 28347)
</span><span class="lines">@@ -949,7 +949,7 @@
</span><span class="cx"> elseif ( isset($q['post_status']) && 'pending' == $q['post_status'] )
</span><span class="cx"> $order = 'ASC';
</span><span class="cx">
</span><del>- $per_page = 'edit_' . $post_type . '_per_page';
</del><ins>+ $per_page = "edit_{$post_type}_per_page";
</ins><span class="cx"> $posts_per_page = (int) get_user_option( $per_page );
</span><span class="cx"> if ( empty( $posts_per_page ) || $posts_per_page < 1 )
</span><span class="cx"> $posts_per_page = 20;
</span><span class="lines">@@ -957,26 +957,25 @@
</span><span class="cx"> /**
</span><span class="cx"> * Filter the number of items per page to show for a specific 'per_page' type.
</span><span class="cx"> *
</span><del>- * The dynamic hook name, $per_page, refers to a hook name comprised of the post type,
- * preceded by 'edit_', and succeeded by '_per_page', e.g. 'edit_$post_type_per_page'.
</del><ins>+ * The dynamic portion of the hook name, $post_type, refers to the post type.
</ins><span class="cx"> *
</span><span class="cx"> * Some examples of filter hooks generated here include: 'edit_attachment_per_page',
</span><span class="cx"> * 'edit_post_per_page', 'edit_page_per_page', etc.
</span><span class="cx"> *
</span><span class="cx"> * @since 3.0.0
</span><span class="cx"> *
</span><del>- * @param int $posts_per_page Number of posts to display per page for the given 'per_page'
</del><ins>+ * @param int $posts_per_page Number of posts to display per page for the given post
</ins><span class="cx"> * type. Default 20.
</span><span class="cx"> */
</span><del>- $posts_per_page = apply_filters( $per_page, $posts_per_page );
</del><ins>+ $posts_per_page = apply_filters( "edit_{$post_type}_per_page", $posts_per_page );
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Filter the number of posts displayed per page when specifically listing "posts".
</span><span class="cx"> *
</span><span class="cx"> * @since 2.8.0
</span><span class="cx"> *
</span><del>- * @param int $per_page Number of posts to be displayed. Default 20.
- * @param string $post_type The post type.
</del><ins>+ * @param int $posts_per_page Number of posts to be displayed. Default 20.
+ * @param string $post_type The post type.
</ins><span class="cx"> */
</span><span class="cx"> $posts_per_page = apply_filters( 'edit_posts_per_page', $posts_per_page, $post_type );
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>