<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28292] trunk/src/wp-admin/includes/ajax-actions.php: In `ajax-actions.php`, remove dead code:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28292">28292</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-05-06 15:18:42 +0000 (Tue, 06 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>In `ajax-actions.php`, remove dead code:
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See <a href="http://core.trac.wordpress.org/ticket/27882">#27882</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesajaxactionsphp">trunk/src/wp-admin/includes/ajax-actions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesajaxactionsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/includes/ajax-actions.php (28291 => 28292)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/includes/ajax-actions.php 2014-05-06 14:51:47 UTC (rev 28291)
+++ trunk/src/wp-admin/includes/ajax-actions.php 2014-05-06 15:18:42 UTC (rev 28292)
</span><span class="lines">@@ -638,7 +638,6 @@
</span><span class="cx"> global $wp_list_table;
</span><span class="cx">
</span><span class="cx"> check_ajax_referer( 'add-tag', '_wpnonce_add-tag' );
</span><del>- $post_type = !empty($_POST['post_type']) ? $_POST['post_type'] : 'post';
</del><span class="cx"> $taxonomy = !empty($_POST['taxonomy']) ? $_POST['taxonomy'] : 'post_tag';
</span><span class="cx"> $tax = get_taxonomy($taxonomy);
</span><span class="cx">
</span><span class="lines">@@ -878,8 +877,6 @@
</span><span class="cx"> edit_comment();
</span><span class="cx">
</span><span class="cx"> $position = ( isset($_POST['position']) && (int) $_POST['position']) ? (int) $_POST['position'] : '-1';
</span><del>- $comments_status = isset($_POST['comments_listing']) ? $_POST['comments_listing'] : '';
-
</del><span class="cx"> $checkbox = ( isset($_POST['checkbox']) && true == $_POST['checkbox'] ) ? 1 : 0;
</span><span class="cx"> $wp_list_table = _get_list_table( $checkbox ? 'WP_Comments_List_Table' : 'WP_Post_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
</span><span class="cx">
</span><span class="lines">@@ -1122,8 +1119,7 @@
</span><span class="cx">
</span><span class="cx"> function wp_ajax_hidden_columns() {
</span><span class="cx"> check_ajax_referer( 'screen-options-nonce', 'screenoptionnonce' );
</span><del>- $hidden = isset( $_POST['hidden'] ) ? $_POST['hidden'] : '';
- $hidden = explode( ',', $_POST['hidden'] );
</del><ins>+ $hidden = explode( ',', isset( $_POST['hidden'] ) ? $_POST['hidden'] : '' );
</ins><span class="cx"> $page = isset( $_POST['page'] ) ? $_POST['page'] : '';
</span><span class="cx">
</span><span class="cx"> if ( $page != sanitize_key( $page ) )
</span><span class="lines">@@ -1332,8 +1328,6 @@
</span><span class="cx">
</span><span class="cx"> $wp_list_table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => $_POST['screen'] ) );
</span><span class="cx">
</span><del>- $mode = $_POST['post_view'];
-
</del><span class="cx"> $level = 0;
</span><span class="cx"> $request_post = array( get_post( $_POST['post_ID'] ) );
</span><span class="cx"> $parent = $request_post[0]->post_parent;
</span><span class="lines">@@ -1395,15 +1389,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function wp_ajax_find_posts() {
</span><del>- global $wpdb;
-
</del><span class="cx"> check_ajax_referer( 'find-posts' );
</span><span class="cx">
</span><span class="cx"> $post_types = get_post_types( array( 'public' => true ), 'objects' );
</span><span class="cx"> unset( $post_types['attachment'] );
</span><span class="cx">
</span><span class="cx"> $s = wp_unslash( $_POST['ps'] );
</span><del>- $searchand = $search = '';
</del><span class="cx"> $args = array(
</span><span class="cx"> 'post_type' => array_keys( $post_types ),
</span><span class="cx"> 'post_status' => 'any',
</span><span class="lines">@@ -1709,16 +1700,11 @@
</span><span class="cx"> function wp_ajax_wp_fullscreen_save_post() {
</span><span class="cx"> $post_id = isset( $_POST['post_ID'] ) ? (int) $_POST['post_ID'] : 0;
</span><span class="cx">
</span><del>- $post = $post_type = null;
</del><ins>+ $post = null;
</ins><span class="cx">
</span><span class="cx"> if ( $post_id )
</span><span class="cx"> $post = get_post( $post_id );
</span><span class="cx">
</span><del>- if ( $post )
- $post_type = $post->post_type;
- elseif ( isset( $_POST['post_type'] ) && post_type_exists( $_POST['post_type'] ) )
- $post_type = $_POST['post_type'];
-
</del><span class="cx"> check_ajax_referer('update-post_' . $post_id, '_wpnonce');
</span><span class="cx">
</span><span class="cx"> $post_id = edit_post();
</span><span class="lines">@@ -1967,8 +1953,6 @@
</span><span class="cx"> if ( ! current_user_can( 'edit_post', $post_id ) )
</span><span class="cx"> wp_send_json_error();
</span><span class="cx">
</span><del>- $post = get_post( $post_id, ARRAY_A );
-
</del><span class="cx"> foreach ( $attachments as $attachment_id => $menu_order ) {
</span><span class="cx"> if ( ! current_user_can( 'edit_post', $attachment_id ) )
</span><span class="cx"> continue;
</span><span class="lines">@@ -2011,7 +1995,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $rel = $url = '';
</span><del>- $html = $title = isset( $attachment['post_title'] ) ? $attachment['post_title'] : '';
</del><ins>+ $html = isset( $attachment['post_title'] ) ? $attachment['post_title'] : '';
</ins><span class="cx"> if ( ! empty( $attachment['url'] ) ) {
</span><span class="cx"> $url = $attachment['url'];
</span><span class="cx"> if ( strpos( $url, 'attachment_id') || get_attachment_link( $id ) == $url )
</span></span></pre>
</div>
</div>
</body>
</html>