<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[28125] trunk/src/wp-includes/js/media-views.js: Image Details modal: Remember the last state of the advanced toggle.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/28125">28125</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2014-04-14 23:55:04 +0000 (Mon, 14 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Image Details modal: Remember the last state of the advanced toggle.
props gcorne.
fixes <a href="http://core.trac.wordpress.org/ticket/27366">#27366</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsmediaviewsjs">trunk/src/wp-includes/js/media-views.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsmediaviewsjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/media-views.js (28124 => 28125)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/media-views.js 2014-04-14 22:45:40 UTC (rev 28124)
+++ trunk/src/wp-includes/js/media-views.js 2014-04-14 23:55:04 UTC (rev 28125)
</span><span class="lines">@@ -6226,7 +6226,7 @@
</span><span class="cx"> events: _.defaults( media.view.Settings.AttachmentDisplay.prototype.events, {
</span><span class="cx"> 'click .edit-attachment': 'editAttachment',
</span><span class="cx"> 'click .replace-attachment': 'replaceAttachment',
</span><del>- 'click .advanced-toggle': 'toggleAdvanced',
</del><ins>+ 'click .advanced-toggle': 'onToggleAdvanced',
</ins><span class="cx"> 'change [data-setting="customWidth"]': 'onCustomSize',
</span><span class="cx"> 'change [data-setting="customHeight"]': 'onCustomSize',
</span><span class="cx"> 'keyup [data-setting="customWidth"]': 'onCustomSize',
</span><span class="lines">@@ -6238,6 +6238,7 @@
</span><span class="cx"> this.listenTo( this.model, 'change:url', this.updateUrl );
</span><span class="cx"> this.listenTo( this.model, 'change:link', this.toggleLinkSettings );
</span><span class="cx"> this.listenTo( this.model, 'change:size', this.toggleCustomSize );
</span><ins>+
</ins><span class="cx"> media.view.Settings.AttachmentDisplay.prototype.initialize.apply( this, arguments );
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -6277,6 +6278,9 @@
</span><span class="cx"> postRender: function() {
</span><span class="cx"> setTimeout( _.bind( this.resetFocus, this ), 10 );
</span><span class="cx"> this.toggleLinkSettings();
</span><ins>+ if ( getUserSetting( 'advImgDetails' ) === 'show' ) {
+ this.toggleAdvanced( true );
+ }
</ins><span class="cx"> this.trigger( 'post-render' );
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -6329,16 +6333,26 @@
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><del>- toggleAdvanced: function( event ) {
- var $advanced = $( event.target ).closest( '.advanced-section' );
</del><ins>+ onToggleAdvanced: function( event ) {
</ins><span class="cx"> event.preventDefault();
</span><del>- if ( $advanced.hasClass('advanced-visible') ) {
</del><ins>+ this.toggleAdvanced();
+ },
+
+ toggleAdvanced: function( show ) {
+ var $advanced = this.$el.find( '.advanced-section' ),
+ mode;
+
+ if ( $advanced.hasClass('advanced-visible') || show === false ) {
</ins><span class="cx"> $advanced.removeClass('advanced-visible');
</span><span class="cx"> $advanced.find('.advanced-settings').addClass('hidden');
</span><ins>+ mode = 'hide';
</ins><span class="cx"> } else {
</span><span class="cx"> $advanced.addClass('advanced-visible');
</span><span class="cx"> $advanced.find('.advanced-settings').removeClass('hidden');
</span><ins>+ mode = 'show';
</ins><span class="cx"> }
</span><ins>+
+ setUserSetting( 'advImgDetails', mode );
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> editAttachment: function( event ) {
</span></span></pre>
</div>
</div>
</body>
</html>