<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27900] trunk/src/wp-includes: wpLink: fix spinners selectors and add some throttling when searching with AJAX while the user is typing, fixes #27615</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27900">27900</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2014-04-02 02:26:12 +0000 (Wed, 02 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>wpLink: fix spinners selectors and add some throttling when searching with AJAX while the user is typing, fixes <a href="http://core.trac.wordpress.org/ticket/27615">#27615</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescsseditorcss">trunk/src/wp-includes/css/editor.css</a></li>
<li><a href="#trunksrcwpincludesjswplinkjs">trunk/src/wp-includes/js/wplink.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescsseditorcss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/editor.css (27899 => 27900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/editor.css 2014-04-02 02:17:39 UTC (rev 27899)
+++ trunk/src/wp-includes/css/editor.css 2014-04-02 02:26:12 UTC (rev 27900)
</span><span class="lines">@@ -1212,6 +1212,7 @@
</span><span class="cx"> #wp-link .river-waiting .spinner {
</span><span class="cx"> margin: 0 auto;
</span><span class="cx"> display: block;
</span><ins>+ float: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #wp-link .submitbox {
</span></span></pre></div>
<a id="trunksrcwpincludesjswplinkjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/wplink.js (27899 => 27900)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/wplink.js 2014-04-02 02:17:39 UTC (rev 27899)
+++ trunk/src/wp-includes/js/wplink.js 2014-04-02 02:26:12 UTC (rev 27900)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> var wpLink;
</span><span class="cx">
</span><span class="cx"> ( function( $ ) {
</span><del>- var inputs = {}, rivers = {}, editor, River, Query;
</del><ins>+ var inputs = {}, rivers = {}, editor, searchTimer, River, Query;
</ins><span class="cx">
</span><span class="cx"> wpLink = {
</span><span class="cx"> timeToTriggerRiver: 150,
</span><span class="lines">@@ -47,7 +47,14 @@
</span><span class="cx">
</span><span class="cx"> rivers.elements.on( 'river-select', wpLink.updateFields );
</span><span class="cx">
</span><del>- inputs.search.keyup( wpLink.searchInternalLinks );
</del><ins>+ inputs.search.keyup( function() {
+ var self = this;
+
+ window.clearTimeout( searchTimer );
+ searchTimer = window.setTimeout( function() {
+ wpLink.searchInternalLinks.call( self );
+ }, 500 );
+ });
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> open: function( editorId ) {
</span><span class="lines">@@ -283,7 +290,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> wpLink.lastSearch = search;
</span><del>- waiting = $( '#river-waiting' ).show();
</del><ins>+ waiting = t.parent().find('.spinner').show();
</ins><span class="cx">
</span><span class="cx"> rivers.search.change( search );
</span><span class="cx"> rivers.search.ajax( function() {
</span><span class="lines">@@ -381,7 +388,7 @@
</span><span class="cx"> this.element = element;
</span><span class="cx"> this.ul = element.children( 'ul' );
</span><span class="cx"> this.contentHeight = element.children( '#link-selector-height' );
</span><del>- this.waiting = $( '#river-waiting' );
</del><ins>+ this.waiting = element.find('.river-waiting');
</ins><span class="cx">
</span><span class="cx"> this.change( search );
</span><span class="cx"> this.refresh();
</span></span></pre>
</div>
</div>
</body>
</html>