<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27865] trunk/src/wp-includes: Using percentages for playlist font-sizing was ambitious, but fell prey to `editor-style.css` in the admin.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27865">27865</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-03-30 22:11:46 +0000 (Sun, 30 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Using percentages for playlist font-sizing was ambitious, but fell prey to `editor-style.css` in the admin. We have switched to using pixels. The editor styles were also forcing MediaElement players to inherit `font-family`, which was undesirable. And while we're at it, remove the top and bottom border from the playlist's list of tracks, which adds a dash of lovely to the playlist's default styles.
Props nacin for the addition of `—` in the playlist track list.
Fixes <a href="http://core.trac.wordpress.org/ticket/27600">#27600</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsmediaelementwpmediaelementcss">trunk/src/wp-includes/js/mediaelement/wp-mediaelement.css</a></li>
<li><a href="#trunksrcwpincludesmediaphp">trunk/src/wp-includes/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsmediaelementwpmediaelementcss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/mediaelement/wp-mediaelement.css (27864 => 27865)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/mediaelement/wp-mediaelement.css 2014-03-30 21:07:04 UTC (rev 27864)
+++ trunk/src/wp-includes/js/mediaelement/wp-mediaelement.css 2014-03-30 22:11:46 UTC (rev 27865)
</span><span class="lines">@@ -1,3 +1,7 @@
</span><ins>+.mejs-container * {
+ font-family: Helvetica, Arial;
+}
+
</ins><span class="cx"> .mejs-container, .mejs-embed, .mejs-embed body {
</span><span class="cx"> background: #000;
</span><span class="cx"> }
</span><span class="lines">@@ -59,8 +63,8 @@
</span><span class="cx"> border: 1px solid #ccc;
</span><span class="cx"> padding: 10px;
</span><span class="cx"> margin: 12px 0 18px;
</span><del>- font-size: 85%;
- line-height: 160%;
</del><ins>+ font-size: 14px;
+ line-height: 1.5;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-playlist video {
</span><span class="lines">@@ -92,46 +96,47 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-playlist-caption {
</span><del>- max-width: 85%;
</del><ins>+ max-width: 90%;
</ins><span class="cx"> overflow: hidden;
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="cx"> white-space: nowrap;
</span><ins>+ font-size: 14px;
+ line-height: 1.5;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-caption-meta {
</del><ins>+.wp-playlist-item-meta {
</ins><span class="cx"> display: block;
</span><ins>+ font-size: 14px;
+ line-height: 1.5;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-caption-title {
- font-size: 100%;
</del><ins>+.wp-playlist-item-title {
+ font-size: 14px;
+ line-height: 1.5;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-caption-album {
</del><ins>+.wp-playlist-item-album {
</ins><span class="cx"> font-style: italic;
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-caption-artist {
- font-size: 85%;
</del><ins>+.wp-playlist-item-artist {
+ font-size: 12px;
</ins><span class="cx"> text-transform: uppercase;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-caption-by {
- font-size: 65%;
- font-weight: bold;
-}
-
</del><span class="cx"> .wp-playlist-item-length {
</span><span class="cx"> position: absolute;
</span><span class="cx"> right: 3px;
</span><span class="cx"> top: 0;
</span><ins>+ font-size: 14px;
+ line-height: 1.5;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-playlist-tracks {
</span><span class="cx"> margin-top: 10px;
</span><del>- border-top: 1px solid #ccc;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .wp-playlist-item {
</span><span class="lines">@@ -141,6 +146,10 @@
</span><span class="cx"> border-bottom: 1px solid #ccc;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.wp-playlist-item:last-child {
+ border-bottom: 0;
+}
+
</ins><span class="cx"> .wp-playlist-light .wp-playlist-item {
</span><span class="cx"> color: #333;
</span><span class="cx"> }
</span><span class="lines">@@ -175,10 +184,12 @@
</span><span class="cx"> max-width: 60px;
</span><span class="cx"> height: auto;
</span><span class="cx"> margin-right: 10px;
</span><ins>+ padding: 0;
+ border: 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.wp-playlist-current-item .wp-caption-title,
-.wp-playlist-current-item .wp-caption-artist {
</del><ins>+.wp-playlist-current-item .wp-playlist-item-title,
+.wp-playlist-current-item .wp-playlist-item-artist {
</ins><span class="cx"> overflow: hidden;
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="cx"> white-space: nowrap;
</span></span></pre></div>
<a id="trunksrcwpincludesmediaphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/media.php (27864 => 27865)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/media.php 2014-03-30 21:07:04 UTC (rev 27864)
+++ trunk/src/wp-includes/media.php 2014-03-30 22:11:46 UTC (rev 27865)
</span><span class="lines">@@ -1019,9 +1019,9 @@
</span><span class="cx"> <img src="{{ data.thumb.src }}"/>
</span><span class="cx"> <# } #>
</span><span class="cx"> <div class="wp-playlist-caption">
</span><del>- <span class="wp-caption-meta wp-caption-title">“{{{ data.title }}}”</span>
- <# if ( data.meta.album ) { #><span class="wp-caption-meta wp-caption-album">{{ data.meta.album }}</span><# } #>
- <# if ( data.meta.artist ) { #><span class="wp-caption-meta wp-caption-artist">{{ data.meta.artist }}</span><# } #>
</del><ins>+ <span class="wp-playlist-item-meta wp-playlist-item-title">“{{{ data.title }}}”</span>
+ <# if ( data.meta.album ) { #><span class="wp-playlist-item-meta wp-playlist-item-album">{{ data.meta.album }}</span><# } #>
+ <# if ( data.meta.artist ) { #><span class="wp-playlist-item-meta wp-playlist-item-artist">{{ data.meta.artist }}</span><# } #>
</ins><span class="cx"> </div>
</span><span class="cx"> </script>
</span><span class="cx"> <script type="text/html" id="tmpl-wp-playlist-item">
</span><span class="lines">@@ -1031,10 +1031,9 @@
</span><span class="cx"> <# if ( data.caption ) { #>
</span><span class="cx"> {{{ data.caption }}}
</span><span class="cx"> <# } else { #>
</span><del>- <span class="wp-caption-title">“{{{ data.title }}}”</span>
</del><ins>+ <span class="wp-playlist-item-title">“{{{ data.title }}}”</span>
</ins><span class="cx"> <# if ( data.artists && data.meta.artist ) { #>
</span><del>- <span class="wp-caption-by"><?php _e( 'by' ) ?></span>
- <span class="wp-caption-artist">{{ data.meta.artist }}</span>
</del><ins>+ <span class="wp-playlist-item-artist"> — {{ data.meta.artist }}</span>
</ins><span class="cx"> <# } #>
</span><span class="cx"> <# } #>
</span><span class="cx"> </div>
</span></span></pre>
</div>
</div>
</body>
</html>