<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27755] trunk: In `wp_list_pages()`, add the `current_page_item` class where applicable when used with a custom post type.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27755">27755</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-03-26 22:46:16 +0000 (Wed, 26 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>In `wp_list_pages()`, add the `current_page_item` class where applicable when used with a custom post type.
Adds a unit test.
Props nacin.
Fixes <a href="http://core.trac.wordpress.org/ticket/17590">#17590</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesposttemplatephp">trunk/src/wp-includes/post-template.php</a></li>
<li><a href="#trunktestsphpunittestspostgetPagesphp">trunk/tests/phpunit/tests/post/getPages.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesposttemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/post-template.php (27754 => 27755)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/post-template.php 2014-03-26 22:31:04 UTC (rev 27754)
+++ trunk/src/wp-includes/post-template.php 2014-03-26 22:46:16 UTC (rev 27755)
</span><span class="lines">@@ -1009,8 +1009,15 @@
</span><span class="cx"> $output .= '<li class="pagenav">' . $r['title_li'] . '<ul>';
</span><span class="cx">
</span><span class="cx"> global $wp_query;
</span><del>- if ( is_page() || is_attachment() || $wp_query->is_posts_page )
- $current_page = $wp_query->get_queried_object_id();
</del><ins>+ if ( is_page() || is_attachment() || $wp_query->is_posts_page ) {
+ $current_page = get_queried_object_id();
+ } elseif ( is_singular() ) {
+ $queried_object = get_queried_object();
+ if ( is_post_type_hierarchical( $queried_object->post_type ) ) {
+ $current_page = $queried_object->ID;
+ }
+ }
+
</ins><span class="cx"> $output .= walk_page_tree($pages, $r['depth'], $current_page, $r);
</span><span class="cx">
</span><span class="cx"> if ( $r['title_li'] )
</span></span></pre></div>
<a id="trunktestsphpunittestspostgetPagesphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/post/getPages.php (27754 => 27755)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/post/getPages.php 2014-03-26 22:31:04 UTC (rev 27754)
+++ trunk/tests/phpunit/tests/post/getPages.php 2014-03-26 22:46:16 UTC (rev 27755)
</span><span class="lines">@@ -211,4 +211,29 @@
</span><span class="cx">
</span><span class="cx"> $this->assertEqualSets( array( $page_1, $page_2, $page_4, $page_3 ), wp_list_pluck( $pages, 'ID' ) );
</span><span class="cx"> }
</span><ins>+
+ function test_wp_list_pages_classes() {
+ $type = 'taco';
+ register_post_type( $type, array( 'hierarchical' => true, 'public' => true ) );
+
+ $posts = $this->factory->post->create_many( 2, array( 'post_type' => $type ) );
+ $post_id = reset( $posts );
+
+ $this->go_to( "/?p=$post_id&post_type=$type" );
+
+ $this->assertEquals( $post_id, get_queried_object_id() );
+
+ $output = wp_list_pages( array(
+ 'echo' => false,
+ 'title_li' => '',
+ 'post_type' => $type
+ ) );
+
+ $this->assertNotEmpty( $output );
+ $this->assertEquals( 2, substr_count( $output, 'class="page_item ' ) );
+ $this->assertContains( 'current_page_item', $output );
+ $this->assertEquals( 1, substr_count( $output, 'current_page_item' ) );
+
+ _unregister_post_type( $type );
+ }
</ins><span class="cx"> }
</span><span class="cx">\ No newline at end of file
</span></span></pre>
</div>
</div>
</body>
</html>