<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27719] trunk: Transients: Allow a non-expiring transient to be updated with an expiry.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27719">27719</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2014-03-25 18:22:49 +0000 (Tue, 25 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Transients: Allow a non-expiring transient to be updated with an expiry.
props shahpranaf, sandyr.
fixes <a href="http://core.trac.wordpress.org/ticket/22807">#22807</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesoptionphp">trunk/src/wp-includes/option.php</a></li>
<li><a href="#trunktestsphpunittestsoptiontransientphp">trunk/tests/phpunit/tests/option/transient.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesoptionphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/option.php (27718 => 27719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/option.php 2014-03-25 17:39:08 UTC (rev 27718)
+++ trunk/src/wp-includes/option.php 2014-03-25 18:22:49 UTC (rev 27719)
</span><span class="lines">@@ -642,9 +642,22 @@
</span><span class="cx"> }
</span><span class="cx"> $result = add_option( $transient, $value, '', $autoload );
</span><span class="cx"> } else {
</span><del>- if ( $expiration )
- update_option( $transient_timeout, time() + $expiration );
- $result = update_option( $transient, $value );
</del><ins>+ // If expiration is requested, but the transient has no timeout option,
+ // delete, then re-create transient rather than update.
+ $update = true;
+ if ( $expiration ) {
+ if ( false === get_option( $transient_timeout ) ) {
+ delete_option( $transient );
+ add_option( $transient_timeout, time() + $expiration, '', 'no' );
+ $result = add_option( $transient, $value, '', 'no' );
+ $update = false;
+ } else {
+ update_option( $transient_timeout, time() + $expiration );
+ }
+ }
+ if ( $update ) {
+ $result = update_option( $transient, $value );
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunktestsphpunittestsoptiontransientphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/option/transient.php (27718 => 27719)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/option/transient.php 2014-03-25 17:39:08 UTC (rev 27718)
+++ trunk/tests/phpunit/tests/option/transient.php 2014-03-25 18:22:49 UTC (rev 27719)
</span><span class="lines">@@ -33,4 +33,47 @@
</span><span class="cx"> $this->assertEquals( $value, get_transient( $key ) );
</span><span class="cx"> $this->assertTrue( delete_transient( $key ) );
</span><span class="cx"> }
</span><ins>+
+ /**
+ * @ticket 22807
+ */
+ function test_transient_data_with_timeout() {
+ $key = rand_str();
+ $value = rand_str();
+ $value2 = rand_str();
+
+ $this->assertFalse( get_option( '_transient_timeout_' . $key ) );
+ $now = time();
+
+ $this->assertTrue( set_transient( $key, $value, 100 ) );
+
+ // Ensure the transient timeout is set for 100-101 seconds in the future.
+ $this->assertGreaterThanOrEqual( $now + 100, get_option( '_transient_timeout_' . $key ) );
+ $this->assertLessThanOrEqual( $now + 101, get_option( '_transient_timeout_' . $key ) );
+
+ // Update the timeout to a second in the past and watch the transient be invalidated.
+ update_option( '_transient_timeout_' . $key, $now - 1 );
+ $this->assertFalse( get_transient( $key ) );
+ }
+
+ /**
+ * @ticket 22807
+ */
+ function test_transient_add_timeout() {
+ $key = rand_str();
+ $value = rand_str();
+ $value2 = rand_str();
+ $this->assertTrue( set_transient( $key, $value ) );
+ $this->assertEquals( $value, get_transient( $key ) );
+
+ $this->assertFalse( get_option( '_transient_timeout_' . $key ) );
+
+ $now = time();
+ // Add timeout to existing timeout-less transient.
+ $this->assertTrue( set_transient( $key, $value2, 1 ) );
+ $this->assertGreaterThanOrEqual( $now, get_option( '_transient_timeout_' . $key ) );
+
+ update_option( '_transient_timeout_' . $key, $now - 1 );
+ $this->assertFalse( get_transient( $key ) );
+ }
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>