<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27686] trunk: When using WP_Query's `"fields" => "ids"` (or `"fields" => "id=>parent"`), the returned values should be an array of integers, not array of integers represented by strings.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27686">27686</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-03-24 18:54:38 +0000 (Mon, 24 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>When using WP_Query's `"fields" => "ids"` (or `"fields" => "id=>parent"`), the returned values should be an array of integers, not array of integers represented by strings.
Adds unit tests. All other unit tests pass.
Props danielbachhuber.
Fixes <a href="http://core.trac.wordpress.org/ticket/27252">#27252</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesqueryphp">trunk/src/wp-includes/query.php</a></li>
<li><a href="#trunktestsphpunittestsqueryresultsphp">trunk/tests/phpunit/tests/query/results.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/query.php (27685 => 27686)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/query.php 2014-03-24 17:13:48 UTC (rev 27685)
+++ trunk/src/wp-includes/query.php 2014-03-24 18:54:38 UTC (rev 27686)
</span><span class="lines">@@ -2268,7 +2268,7 @@
</span><span class="cx"> // This overrides posts_per_page.
</span><span class="cx"> if ( ! empty( $q['posts_per_rss'] ) ) {
</span><span class="cx"> $q['posts_per_page'] = $q['posts_per_rss'];
</span><del>- } else {
</del><ins>+ } else {
</ins><span class="cx"> $q['posts_per_page'] = get_option( 'posts_per_rss' );
</span><span class="cx"> }
</span><span class="cx"> $q['nopaging'] = false;
</span><span class="lines">@@ -3205,7 +3205,7 @@
</span><span class="cx"> $this->post_count = count( $this->posts );
</span><span class="cx"> $this->set_found_posts( $q, $limits );
</span><span class="cx">
</span><del>- return $this->posts;
</del><ins>+ return array_map( 'intval', $this->posts );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( 'id=>parent' == $q['fields'] ) {
</span><span class="lines">@@ -3214,9 +3214,9 @@
</span><span class="cx"> $this->set_found_posts( $q, $limits );
</span><span class="cx">
</span><span class="cx"> $r = array();
</span><del>- foreach ( $this->posts as $post )
- $r[ $post->ID ] = $post->post_parent;
-
</del><ins>+ foreach ( $this->posts as $post ) {
+ $r[ (int) $post->ID ] = (int) $post->post_parent;
+ }
</ins><span class="cx"> return $r;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunktestsphpunittestsqueryresultsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/query/results.php (27685 => 27686)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/query/results.php 2014-03-24 17:13:48 UTC (rev 27685)
+++ trunk/tests/phpunit/tests/query/results.php 2014-03-24 18:54:38 UTC (rev 27686)
</span><span class="lines">@@ -46,10 +46,10 @@
</span><span class="cx"> $this->parent_one = $this->factory->post->create( array( 'post_title' => 'parent-one', 'post_date' => '2007-01-01 00:00:00' ) );
</span><span class="cx"> $this->parent_two = $this->factory->post->create( array( 'post_title' => 'parent-two', 'post_date' => '2007-01-01 00:00:00' ) );
</span><span class="cx"> $this->parent_three = $this->factory->post->create( array( 'post_title' => 'parent-three', 'post_date' => '2007-01-01 00:00:00' ) );
</span><del>- $this->factory->post->create( array( 'post_title' => 'child-one', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:01' ) );
- $this->factory->post->create( array( 'post_title' => 'child-two', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:02' ) );
- $this->factory->post->create( array( 'post_title' => 'child-three', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:03' ) );
- $this->factory->post->create( array( 'post_title' => 'child-four', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:04' ) );
</del><ins>+ $this->child_one = $this->factory->post->create( array( 'post_title' => 'child-one', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:01' ) );
+ $this->child_two = $this->factory->post->create( array( 'post_title' => 'child-two', 'post_parent' => $this->parent_one, 'post_date' => '2007-01-01 00:00:02' ) );
+ $this->child_three = $this->factory->post->create( array( 'post_title' => 'child-three', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:03' ) );
+ $this->child_four = $this->factory->post->create( array( 'post_title' => 'child-four', 'post_parent' => $this->parent_two, 'post_date' => '2007-01-01 00:00:04' ) );
</ins><span class="cx">
</span><span class="cx"> unset( $this->q );
</span><span class="cx"> $this->q = new WP_Query();
</span><span class="lines">@@ -370,6 +370,38 @@
</span><span class="cx"> ), wp_list_pluck( $posts, 'post_title' ) );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ /**
+ * @ticket 27252
+ */
+ function test_query_fields_integers() {
+
+ $parents = array(
+ (int) $this->parent_one,
+ (int) $this->parent_two
+ );
+ $posts1 = $this->q->query( array(
+ 'post__in' => $parents,
+ 'fields' => 'ids',
+ 'orderby' => 'post__in',
+ ) );
+
+ $this->assertSame( $parents, $posts1 );
+
+ $children = array(
+ (int) $this->child_one => (int) $this->parent_one,
+ (int) $this->child_two => (int) $this->parent_one
+ );
+
+ $posts2 = $this->q->query( array(
+ 'post__in' => array_keys( $children ),
+ 'fields' => 'id=>parent',
+ 'orderby' => 'post__in',
+ ) );
+
+ $this->assertSame( $children, $posts2 );
+
+ }
+
</ins><span class="cx"> function test_exlude_from_search_empty() {
</span><span class="cx"> global $wp_post_types;
</span><span class="cx"> foreach ( array_keys( $wp_post_types ) as $slug )
</span></span></pre>
</div>
</div>
</body>
</html>