<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27449] trunk/src/wp-includes/js/tinymce/plugins: TinyMCE: add Ctrl+K, the "de-facto standard" shortcut to open wpLink, fixes #27305</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27449">27449</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2014-03-07 03:09:00 +0000 (Fri, 07 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>TinyMCE: add Ctrl+K, the "de-facto standard" shortcut to open wpLink, fixes <a href="http://core.trac.wordpress.org/ticket/27305">#27305</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjstinymcepluginswordpresspluginjs">trunk/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js</a></li>
<li><a href="#trunksrcwpincludesjstinymcepluginswplinkpluginjs">trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjstinymcepluginswordpresspluginjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js (27448 => 27449)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js 2014-03-07 02:45:18 UTC (rev 27448)
+++ trunk/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js 2014-03-07 03:09:00 UTC (rev 27449)
</span><span class="lines">@@ -420,7 +420,6 @@
</span><span class="cx"> editor.addShortcut( modKey + '+u', '', 'InsertUnorderedList' );
</span><span class="cx"> editor.addShortcut( modKey + '+o', '', 'InsertOrderedList' );
</span><span class="cx"> editor.addShortcut( modKey + '+n', '', 'mceSpellCheck' );
</span><del>- editor.addShortcut( modKey + '+a', '', 'WP_Link' );
</del><span class="cx"> editor.addShortcut( modKey + '+s', '', 'unlink' );
</span><span class="cx"> editor.addShortcut( modKey + '+m', '', 'WP_Medialib' );
</span><span class="cx"> editor.addShortcut( modKey + '+z', '', 'WP_Adv' );
</span></span></pre></div>
<a id="trunksrcwpincludesjstinymcepluginswplinkpluginjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js (27448 => 27449)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js 2014-03-07 02:45:18 UTC (rev 27448)
+++ trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js 2014-03-07 03:09:00 UTC (rev 27449)
</span><span class="lines">@@ -1,12 +1,19 @@
</span><span class="cx"> /* global tinymce */
</span><span class="cx"> tinymce.PluginManager.add( 'wplink', function( editor ) {
</span><ins>+ var linkButton;
+
</ins><span class="cx"> // Register a command so that it can be invoked by using tinyMCE.activeEditor.execCommand( 'WP_Link' );
</span><span class="cx"> editor.addCommand( 'WP_Link', function() {
</span><del>- if ( typeof window.wpLink !== 'undefined' ) {
</del><ins>+ if ( ( ! linkButton || ! linkButton.disabled() ) && typeof window.wpLink !== 'undefined' ) {
</ins><span class="cx"> window.wpLink.open( editor.id );
</span><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ // WP default shortcut
+ editor.addShortcut( 'alt+shift+a', '', 'WP_Link' );
+ // The "de-facto standard" shortcut, see #27305
+ editor.addShortcut( 'ctrl+k', '', 'WP_Link' );
+
</ins><span class="cx"> editor.addButton( 'link', {
</span><span class="cx"> icon: 'link',
</span><span class="cx"> tooltip: 'Insert/edit link',
</span><span class="lines">@@ -14,13 +21,13 @@
</span><span class="cx"> cmd: 'WP_Link',
</span><span class="cx">
</span><span class="cx"> onPostRender: function() {
</span><del>- var ctrl = this;
</del><ins>+ linkButton = this;
</ins><span class="cx">
</span><span class="cx"> editor.on( 'nodechange', function( event ) {
</span><span class="cx"> var node = event.element;
</span><span class="cx">
</span><del>- ctrl.disabled( editor.selection.isCollapsed() && node.nodeName !== 'A' );
- ctrl.active( node.nodeName === 'A' && ! node.name );
</del><ins>+ linkButton.disabled( editor.selection.isCollapsed() && node.nodeName !== 'A' );
+ linkButton.active( node.nodeName === 'A' && ! node.name );
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>