<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27057] trunk/src/wp-includes: `get_comment()`, `wp_get_post_revision()`, and `get_term()` all used to return by reference.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27057">27057</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-01-29 06:45:54 +0000 (Wed, 29 Jan 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>`get_comment()`, `wp_get_post_revision()`, and `get_term()` all used to return by reference. Because of this, `$null` was set to `null` so the return value would be a variable where applicable. This has not been necessary since <a href="http://core.trac.wordpress.org/changeset/21792">[21792]</a>, so the `$null`s have been removed.

Props toszcze.
Fixes <a href="http://core.trac.wordpress.org/ticket/24768">#24768</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
<li><a href="#trunksrcwpincludesrevisionphp">trunk/src/wp-includes/revision.php</a></li>
<li><a href="#trunksrcwpincludestaxonomyphp">trunk/src/wp-includes/taxonomy.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/comment.php (27056 => 27057)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/comment.php        2014-01-29 05:27:24 UTC (rev 27056)
+++ trunk/src/wp-includes/comment.php   2014-01-29 06:45:54 UTC (rev 27057)
</span><span class="lines">@@ -135,7 +135,6 @@
</span><span class="cx">  */
</span><span class="cx"> function get_comment(&$comment, $output = OBJECT) {
</span><span class="cx">  global $wpdb;
</span><del>-       $null = null;
</del><span class="cx"> 
</span><span class="cx">  if ( empty($comment) ) {
</span><span class="cx">          if ( isset($GLOBALS['comment']) )
</span><span class="lines">@@ -151,7 +150,7 @@
</span><span class="cx">          } elseif ( ! $_comment = wp_cache_get($comment, 'comment') ) {
</span><span class="cx">                  $_comment = $wpdb->get_row($wpdb->prepare("SELECT * FROM $wpdb->comments WHERE comment_ID = %d LIMIT 1", $comment));
</span><span class="cx">                  if ( ! $_comment )
</span><del>-                               return $null;
</del><ins>+                                return null;
</ins><span class="cx">                   wp_cache_add($_comment->comment_ID, $_comment, 'comment');
</span><span class="cx">          }
</span><span class="cx">  }
</span></span></pre></div>
<a id="trunksrcwpincludesrevisionphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/revision.php (27056 => 27057)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/revision.php       2014-01-29 05:27:24 UTC (rev 27056)
+++ trunk/src/wp-includes/revision.php  2014-01-29 06:45:54 UTC (rev 27057)
</span><span class="lines">@@ -256,11 +256,10 @@
</span><span class="cx">  * @return mixed Null if error or post object if success.
</span><span class="cx">  */
</span><span class="cx"> function wp_get_post_revision(&$post, $output = OBJECT, $filter = 'raw') {
</span><del>-       $null = null;
</del><span class="cx">   if ( !$revision = get_post( $post, OBJECT, $filter ) )
</span><span class="cx">          return $revision;
</span><span class="cx">  if ( 'revision' !== $revision->post_type )
</span><del>-               return $null;
</del><ins>+                return null;
</ins><span class="cx"> 
</span><span class="cx">  if ( $output == OBJECT ) {
</span><span class="cx">          return $revision;
</span></span></pre></div>
<a id="trunksrcwpincludestaxonomyphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/taxonomy.php (27056 => 27057)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/taxonomy.php       2014-01-29 05:27:24 UTC (rev 27056)
+++ trunk/src/wp-includes/taxonomy.php  2014-01-29 06:45:54 UTC (rev 27057)
</span><span class="lines">@@ -935,7 +935,6 @@
</span><span class="cx">  */
</span><span class="cx"> function get_term($term, $taxonomy, $output = OBJECT, $filter = 'raw') {
</span><span class="cx">  global $wpdb;
</span><del>-       $null = null;
</del><span class="cx"> 
</span><span class="cx">  if ( empty($term) ) {
</span><span class="cx">          $error = new WP_Error('invalid_term', __('Empty Term'));
</span><span class="lines">@@ -954,11 +953,11 @@
</span><span class="cx">          if ( is_object($term) )
</span><span class="cx">                  $term = $term->term_id;
</span><span class="cx">          if ( !$term = (int) $term )
</span><del>-                       return $null;
</del><ins>+                        return null;
</ins><span class="cx">           if ( ! $_term = wp_cache_get($term, $taxonomy) ) {
</span><span class="cx">                  $_term = $wpdb->get_row( $wpdb->prepare( "SELECT t.*, tt.* FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON t.term_id = tt.term_id WHERE tt.taxonomy = %s AND t.term_id = %d LIMIT 1", $taxonomy, $term) );
</span><span class="cx">                  if ( ! $_term )
</span><del>-                               return $null;
</del><ins>+                                return null;
</ins><span class="cx">                   wp_cache_add($term, $_term, $taxonomy);
</span><span class="cx">          }
</span><span class="cx">  }
</span></span></pre>
</div>
</div>

</body>
</html>