<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27040] trunk/tests/phpunit/tests/formatting/balanceTags.php: Remove duplicated and superceded balance tags unit tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27040">27040</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2014-01-27 02:57:51 +0000 (Mon, 27 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove duplicated and superceded balance tags unit tests.
props coffee2code.
fixes <a href="http://core.trac.wordpress.org/ticket/26222">#26222</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsformattingbalanceTagsphp">trunk/tests/phpunit/tests/formatting/balanceTags.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsformattingbalanceTagsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/formatting/balanceTags.php (27039 => 27040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/formatting/balanceTags.php 2014-01-27 00:38:19 UTC (rev 27039)
+++ trunk/tests/phpunit/tests/formatting/balanceTags.php 2014-01-27 02:57:51 UTC (rev 27040)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx">
</span><span class="cx"> function nestable_tags() {
</span><span class="cx"> return array(
</span><del>- array( 'blockquote', 'div', 'object', 'q', 'span' )
</del><ins>+ array( 'blockquote' ), array( 'div' ), array( 'object' ), array( 'q' ), array( 'span' ),
</ins><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -20,25 +20,7 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // These are single/self-closing tags that WP has traditionally recognized.
- function basic_single_tags() {
- return array(
- array( 'br' ), array( 'hr' ), array( 'img' ), array( 'input' )
- );
- }
-
</del><span class="cx"> /**
</span><del>- * These are single tags WP has traditionally properly handled
- * This test can be removed if #1597 is fixed and the next test passes, as
- * it supercedes this test.
- *
- * @dataProvider basic_single_tags
- */
- function test_selfcloses_unclosed_basic_known_single_tags( $tag ) {
- $this->assertEquals( "<$tag />", balanceTags( "<$tag>", true ) );
- }
-
- /**
</del><span class="cx"> * If a recognized valid single tag appears unclosed, it should get self-closed
</span><span class="cx"> *
</span><span class="cx"> * @ticket 1597
</span><span class="lines">@@ -49,17 +31,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * These are single tags WP has traditionally properly handled
- * This test can be removed if #1597 is fixed and the next test passes, as
- * it supercedes this test.
- *
- * @dataProvider basic_single_tags
- */
- function test_selfcloses_basic_known_single_tags_having_closing_tag( $tag ) {
- $this->assertEquals( "<$tag />", balanceTags( "<$tag></$tag>", true ) );
- }
-
- /**
</del><span class="cx"> * If a recognized valid single tag is given a closing tag, the closing tag
</span><span class="cx"> * should get removed and tag should be self-closed.
</span><span class="cx"> *
</span><span class="lines">@@ -121,16 +92,19 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function test_balances_nestable_tags() {
</del><ins>+ /**
+ * @dataProvider nestable_tags
+ */
+ function test_balances_nestable_tags( $tag ) {
</ins><span class="cx"> $inputs = array(
</span><del>- '<q>Test<q>Test</q>',
- '<div><div>Test',
- '<div>Test</div></div>',
</del><ins>+ "<$tag>Test<$tag>Test</$tag>",
+ "<$tag><$tag>Test",
+ "<$tag>Test</$tag></$tag>",
</ins><span class="cx"> );
</span><span class="cx"> $expected = array(
</span><del>- '<q>Test<q>Test</q></q>',
- '<div><div>Test</div></div>',
- '<div>Test</div>',
</del><ins>+ "<$tag>Test<$tag>Test</$tag></$tag>",
+ "<$tag><$tag>Test</$tag></$tag>",
+ "<$tag>Test</$tag>",
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> foreach ( $inputs as $key => $input ) {
</span><span class="lines">@@ -156,7 +130,6 @@
</span><span class="cx"> * @ticket 20401
</span><span class="cx"> */
</span><span class="cx"> function test_allows_immediately_nested_object_tags() {
</span><del>-
</del><span class="cx"> $object = '<object id="obj1"><param name="param1"/><object id="obj2"><param name="param2"/></object></object>';
</span><span class="cx"> $this->assertEquals( $object, balanceTags( $object, true ) );
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>