<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[27016] trunk: Let `is_attachment()` accept an $attachment parameter, similar to `is_page()` and `is_single()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/27016">27016</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-01-22 22:30:36 +0000 (Wed, 22 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Let `is_attachment()` accept an $attachment parameter, similar to `is_page()` and `is_single()`. Adds Unit Tests for all 3.
Props alex-ye for the initial patch.
Fixes <a href="http://core.trac.wordpress.org/ticket/24257">#24257</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesqueryphp">trunk/src/wp-includes/query.php</a></li>
<li><a href="#trunktestsphpunittestsqueryconditionalsphp">trunk/tests/phpunit/tests/query/conditionals.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/query.php (27015 => 27016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/query.php 2014-01-22 21:25:05 UTC (rev 27015)
+++ trunk/src/wp-includes/query.php 2014-01-22 22:30:36 UTC (rev 27016)
</span><span class="lines">@@ -175,9 +175,10 @@
</span><span class="cx"> * @since 2.0.0
</span><span class="cx"> * @uses $wp_query
</span><span class="cx"> *
</span><ins>+ * @param mixed $attachment Attachment ID, title, slug, or array of such.
</ins><span class="cx"> * @return bool
</span><span class="cx"> */
</span><del>-function is_attachment() {
</del><ins>+function is_attachment( $attachment = '' ) {
</ins><span class="cx"> global $wp_query;
</span><span class="cx">
</span><span class="cx"> if ( ! isset( $wp_query ) ) {
</span><span class="lines">@@ -185,7 +186,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return $wp_query->is_attachment();
</del><ins>+ return $wp_query->is_attachment( $attachment );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -3387,10 +3388,30 @@
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><span class="cx"> *
</span><ins>+ * @param mixed $attachment Attachment ID, title, slug, or array of such.
</ins><span class="cx"> * @return bool
</span><span class="cx"> */
</span><del>- function is_attachment() {
- return (bool) $this->is_attachment;
</del><ins>+ function is_attachment( $attachment = '' ) {
+ if ( ! $this->is_attachment ) {
+ return false;
+ }
+
+ if ( empty( $attachment ) ) {
+ return true;
+ }
+
+ $attachment = (array) $attachment;
+
+ $post_obj = $this->get_queried_object();
+
+ if ( in_array( $post_obj->ID, $attachment ) ) {
+ return true;
+ } elseif ( in_array( $post_obj->post_title, $attachment ) ) {
+ return true;
+ } elseif ( in_array( $post_obj->post_name, $attachment ) ) {
+ return true;
+ }
+ return false;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestsqueryconditionalsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/query/conditionals.php (27015 => 27016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/query/conditionals.php 2014-01-22 21:25:05 UTC (rev 27015)
+++ trunk/tests/phpunit/tests/query/conditionals.php 2014-01-22 22:30:36 UTC (rev 27016)
</span><span class="lines">@@ -670,4 +670,43 @@
</span><span class="cx"> function pre_get_posts_with_type_array( &$query ) {
</span><span class="cx"> $query->set( 'post_type', array( 'post', 'thearray' ) );
</span><span class="cx"> }
</span><ins>+
+ function test_is_single() {
+ $post_id = $this->factory->post->create();
+ $this->go_to( "/?p=$post_id" );
+
+ $post = get_queried_object();
+
+ $this->assertTrue( is_single() );
+ $this->assertTrue( is_single( $post ) );
+ $this->assertTrue( is_single( $post->ID ) );
+ $this->assertTrue( is_single( $post->post_title ) );
+ $this->assertTrue( is_single( $post->post_name ) );
+ }
+
+ function test_is_page() {
+ $post_id = $this->factory->post->create( array( 'post_type' => 'page' ) );
+ $this->go_to( "/?page_id=$post_id" );
+
+ $post = get_queried_object();
+
+ $this->assertTrue( is_page() );
+ $this->assertTrue( is_page( $post ) );
+ $this->assertTrue( is_page( $post->ID ) );
+ $this->assertTrue( is_page( $post->post_title ) );
+ $this->assertTrue( is_page( $post->post_name ) );
+ }
+
+ function test_is_attachment() {
+ $post_id = $this->factory->post->create( array( 'post_type' => 'attachment' ) );
+ $this->go_to( "/?attachment_id=$post_id" );
+
+ $post = get_queried_object();
+
+ $this->assertTrue( is_attachment() );
+ $this->assertTrue( is_attachment( $post ) );
+ $this->assertTrue( is_attachment( $post->ID ) );
+ $this->assertTrue( is_attachment( $post->post_title ) );
+ $this->assertTrue( is_attachment( $post->post_name ) );
+ }
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>