<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26993] trunk/src: Eliminate the 1px padding adjustment on active buttons because it creates an un-clickable dead zone 1px high and spanning the entire width of the button.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26993">26993</a></dd>
<dt>Author</dt> <dd>iammattthomas</dd>
<dt>Date</dt> <dd>2014-01-21 21:26:31 +0000 (Tue, 21 Jan 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Eliminate the 1px padding adjustment on active buttons because it creates an un-clickable dead zone 1px high and spanning the entire width of the button. Modify the background color of active buttons for better contrast to make the active state more obvious.
See <a href="http://core.trac.wordpress.org/ticket/26700">#26700</a>, props johnbillion.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsscolors_mixinsscss">trunk/src/wp-admin/css/colors/_mixins.scss</a></li>
<li><a href="#trunksrcwpincludescssbuttonscss">trunk/src/wp-includes/css/buttons.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsscolors_mixinsscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors/_mixins.scss (26992 => 26993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors/_mixins.scss 2014-01-21 18:04:16 UTC (rev 26992)
+++ trunk/src/wp-admin/css/colors/_mixins.scss 2014-01-21 21:26:31 UTC (rev 26993)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx">
</span><span class="cx"> &:hover,
</span><span class="cx"> &:focus {
</span><del>- background: darken( $button-color, 8% );
</del><ins>+ background: darken( $button-color, 5% );
</ins><span class="cx"> border-color: darken( $button-color, 15% );
</span><span class="cx"> color: $text-color;
</span><span class="cx"> -webkit-box-shadow: inset 0 1px 0 lighten( $button-color, 10% ), 0 1px 0 rgba(0,0,0,.15);
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> &:active {
</span><del>- background: darken( $button-color, 8% );
</del><ins>+ background: darken( $button-color, 10% );
</ins><span class="cx"> border-color: darken( $button-color, 15% );
</span><span class="cx"> color: $text-color;
</span><span class="cx"> -webkit-box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</span></span></pre></div>
<a id="trunksrcwpincludescssbuttonscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/buttons.css (26992 => 26993)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/buttons.css 2014-01-21 18:04:16 UTC (rev 26992)
+++ trunk/src/wp-includes/css/buttons.css 2014-01-21 21:26:31 UTC (rev 26993)
</span><span class="lines">@@ -163,11 +163,6 @@
</span><span class="cx"> box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
</span><span class="cx"> }
</span><span class="cx">
</span><del>-/* this creates an inset effect on the text */
-.wp-core-ui .button:active {
- padding-top: 1px;
-}
-
</del><span class="cx"> .wp-core-ui .button[disabled],
</span><span class="cx"> .wp-core-ui .button:disabled,
</span><span class="cx"> .wp-core-ui .button-secondary[disabled],
</span><span class="lines">@@ -216,7 +211,7 @@
</span><span class="cx"> .wp-core-ui .button-primary.active:hover,
</span><span class="cx"> .wp-core-ui .button-primary.active:focus,
</span><span class="cx"> .wp-core-ui .button-primary:active {
</span><del>- background: #1e8cbe;
</del><ins>+ background: #1b7aa6;
</ins><span class="cx"> border-color: #005684;
</span><span class="cx"> color: rgba(255,255,255,0.95);
</span><span class="cx"> -webkit-box-shadow: inset 0 1px 0 rgba(0,0,0,0.1);
</span><span class="lines">@@ -224,11 +219,6 @@
</span><span class="cx"> vertical-align: top;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-/* this creates an inset effect on the text */
-.wp-core-ui .button-primary:active {
- padding-top: 1px;
-}
-
</del><span class="cx"> .wp-core-ui .button-primary[disabled],
</span><span class="cx"> .wp-core-ui .button-primary:disabled,
</span><span class="cx"> .wp-core-ui .button-primary-disabled {
</span><span class="lines">@@ -296,17 +286,6 @@
</span><span class="cx"> margin-bottom: 4px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- /* Adjust the padding that makes active button text looks inset to account for larger responsive buttons */
- .wp-core-ui .button:active,
- .wp-core-ui .button-large:active,
- .wp-core-ui .button-small:active,
- input#publish:active,
- input#save-post:active,
- a.preview:active {
- padding-top: 11px;
- padding-bottom: 9px;
- }
-
</del><span class="cx"> #media-upload.wp-core-ui .button {
</span><span class="cx"> padding: 0 10px 1px;
</span><span class="cx"> height: 24px;
</span><span class="lines">@@ -343,7 +322,4 @@
</span><span class="cx"> padding: 0 12px 2px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .interim-login .button.button-large:active {
- padding-top: 1px;
- }
</del><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>