<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26991] trunk/src/wp-includes/js/media-models.js: Make some `@param` types more specific in `media-models.js`.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26991">26991</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2014-01-21 17:36:24 +0000 (Tue, 21 Jan 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Make some `@param` types more specific in `media-models.js`.

See <a href="http://core.trac.wordpress.org/ticket/26870">#26870</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsmediamodelsjs">trunk/src/wp-includes/js/media-models.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsmediamodelsjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/media-models.js (26990 => 26991)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/media-models.js 2014-01-21 16:30:57 UTC (rev 26990)
+++ trunk/src/wp-includes/js/media-models.js    2014-01-21 17:36:24 UTC (rev 26991)
</span><span class="lines">@@ -184,9 +184,12 @@
</span><span class="cx">   */
</span><span class="cx">  Attachment = media.model.Attachment = Backbone.Model.extend({
</span><span class="cx">          /**
</span><ins>+                * Triggered when attachment details change
+                *
</ins><span class="cx">            * @param {string} method
</span><del>-                * @param {Backbone.Model} model
</del><ins>+                 * @param {wp.media.model.Attachment} model
</ins><span class="cx">            * @param {Object} [options={}]
</span><ins>+                *
</ins><span class="cx">            * @returns {Promise}
</span><span class="cx">           */
</span><span class="cx">          sync: function( method, model, options ) {
</span><span class="lines">@@ -266,6 +269,8 @@
</span><span class="cx">                  }
</span><span class="cx">          },
</span><span class="cx">          /**
</span><ins>+                * Convert date strings into Date objects.
+                *
</ins><span class="cx">            * @param {Object} resp
</span><span class="cx">           * @returns {Object}
</span><span class="cx">           */
</span><span class="lines">@@ -274,7 +279,6 @@
</span><span class="cx">                          return resp;
</span><span class="cx">                  }
</span><span class="cx"> 
</span><del>-                       // Convert date strings into Date objects.
</del><span class="cx">                   resp.date = new Date( resp.date );
</span><span class="cx">                  resp.modified = new Date( resp.modified );
</span><span class="cx">                  return resp;
</span><span class="lines">@@ -282,6 +286,9 @@
</span><span class="cx">          /**
</span><span class="cx">           * @param {Object} data
</span><span class="cx">           * @param {Object} options
</span><ins>+                *
+                * @this Backbone.Model
+                *
</ins><span class="cx">            * @returns {Promise}
</span><span class="cx">           */
</span><span class="cx">          saveCompat: function( data, options ) {
</span><span class="lines">@@ -310,7 +317,7 @@
</span><span class="cx">          },
</span><span class="cx">          /**
</span><span class="cx">           * @param {string} id
</span><del>-                * @param {Backbone.Model} attachment
</del><ins>+                 * @param {Backbone.Model|undefined} attachment
</ins><span class="cx">            * @returns {wp.media.model.Attachment}
</span><span class="cx">           */
</span><span class="cx">          get: _.memoize( function( id, attachment ) {
</span><span class="lines">@@ -479,7 +486,7 @@
</span><span class="cx">          },
</span><span class="cx"> 
</span><span class="cx">          /**
</span><del>-                * @param {Backbone.Collection} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @param {object} [options={}]
</span><span class="cx">           * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="lines">@@ -496,7 +503,7 @@
</span><span class="cx">                  return this;
</span><span class="cx">          },
</span><span class="cx">          /**
</span><del>-                * @param {Backbone.Collection} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="cx">          observe: function( attachments ) {
</span><span class="lines">@@ -509,7 +516,7 @@
</span><span class="cx">                  return this;
</span><span class="cx">          },
</span><span class="cx">          /**
</span><del>-                * @param {Backbone.Collection} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="cx">          unobserve: function( attachments ) {
</span><span class="lines">@@ -529,9 +536,10 @@
</span><span class="cx">          /**
</span><span class="cx">           * @access private
</span><span class="cx">           *
</span><del>-                * @param {Backbone.Model} attachment
-                * @param {Backbone.Collction} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachment
+                * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @param {Object} options
</span><ins>+                *
</ins><span class="cx">            * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="cx">          _validateHandler: function( attachment, attachments, options ) {
</span><span class="lines">@@ -546,7 +554,7 @@
</span><span class="cx">          /**
</span><span class="cx">           * @access private
</span><span class="cx">           *
</span><del>-                * @param {Backbone.Collction} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @param {Object} options
</span><span class="cx">           * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="lines">@@ -554,7 +562,7 @@
</span><span class="cx">                  return this.validateAll( attachments, options );
</span><span class="cx">          },
</span><span class="cx">          /**
</span><del>-                * @param {Backbone.Collction} attachments
</del><ins>+                 * @param {wp.media.model.Attachments} attachments
</ins><span class="cx">            * @returns {wp.media.model.Attachments} Returns itself to allow chaining
</span><span class="cx">           */
</span><span class="cx">          mirror: function( attachments ) {
</span><span class="lines">@@ -759,7 +767,7 @@
</span><span class="cx">   * wp.media.query
</span><span class="cx">   *
</span><span class="cx">   * @static
</span><del>-        * @returns {Attachments}
</del><ins>+         * @returns {wp.media.model.Attachments}
</ins><span class="cx">    */
</span><span class="cx">  media.query = function( props ) {
</span><span class="cx">          return new Attachments( null, {
</span><span class="lines">@@ -1054,8 +1062,9 @@
</span><span class="cx">          },
</span><span class="cx"> 
</span><span class="cx">          /**
</span><ins>+                * Triggered when toggling (clicking on) an attachment in the modal
</ins><span class="cx">            *
</span><del>-                * @param {Backbone.Model} model
</del><ins>+                 * @param {undefined|boolean|wp.media.model.Attachment} model
</ins><span class="cx">            *
</span><span class="cx">           * @fires wp.media.model.Selection#selection:single
</span><span class="cx">           * @fires wp.media.model.Selection#selection:unsingle
</span></span></pre>
</div>
</div>

</body>
</html>