<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26788] trunk/src/wp-admin: A small adjustment to the page background color per yesterday's conversation with nacin, from #eee to #f3f3f3.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26788">26788</a></dd>
<dt>Author</dt> <dd>iammattthomas</dd>
<dt>Date</dt> <dd>2013-12-08 04:11:20 +0000 (Sun, 08 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>A small adjustment to the page background color per yesterday's conversation with nacin, from #eee to #f3f3f3. This retains enough contrast with white widget containers while making for a more comfortable reading experiences on pages that heavily use the default background color, like the About page. A few adjustments to go along with it:
- Horizontal rules on the About page are lighter, to match their previous level of contrast with #eee
- Eliminated the .flush-top class on <hr>s on the About page since we want the styles applied to all About page <hr>s.
- Color schemes should match the bottom border of active tabs to the scheme's body-background variable.
- Lighten the comment background color on the Dashboard activity widget to keep adequate contrast with the new lighter body background.
See <a href="http://core.trac.wordpress.org/ticket/25858">#25858</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminaboutphp">trunk/src/wp-admin/about.php</a></li>
<li><a href="#trunksrcwpadmincsscolors_adminscss">trunk/src/wp-admin/css/colors/_admin.scss</a></li>
<li><a href="#trunksrcwpadmincsscolors_variablesscss">trunk/src/wp-admin/css/colors/_variables.scss</a></li>
<li><a href="#trunksrcwpadmincsscolorscss">trunk/src/wp-admin/css/colors.css</a></li>
<li><a href="#trunksrcwpadmincsswpadmincss">trunk/src/wp-admin/css/wp-admin.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminaboutphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/about.php (26787 => 26788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/about.php 2013-12-08 03:23:52 UTC (rev 26787)
+++ trunk/src/wp-admin/about.php 2013-12-08 04:11:20 UTC (rev 26788)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>-<hr class="flush-top">
</del><ins>+<hr>
</ins><span class="cx">
</span><span class="cx"> <div class="changelog">
</span><span class="cx"> <div class="feature-section col two-col">
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>-<hr class="flush-top">
</del><ins>+<hr>
</ins><span class="cx">
</span><span class="cx"> <div class="changelog about-colors">
</span><span class="cx"> <div class="feature-section col one-col">
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>-<hr class="flush-top">
</del><ins>+<hr>
</ins><span class="cx">
</span><span class="cx"> <div class="changelog">
</span><span class="cx"> <div class="feature-section col two-col">
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>-<hr class="flush-top">
</del><ins>+<hr>
</ins><span class="cx">
</span><span class="cx"> <div class="changelog">
</span><span class="cx"> <h2 class="about-headline-callout"><?php echo ( 'Twenty Fourteen, a sleek new magazine theme' ); ?></h2>
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>-<hr class="flush-top">
</del><ins>+<hr>
</ins><span class="cx">
</span><span class="cx"> <div class="return-to-dashboard">
</span><span class="cx"> <?php if ( current_user_can( 'update_core' ) && isset( $_GET['updated'] ) ) : ?>
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_adminscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors/_admin.scss (26787 => 26788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors/_admin.scss 2013-12-08 03:23:52 UTC (rev 26787)
+++ trunk/src/wp-admin/css/colors/_admin.scss 2013-12-08 04:11:20 UTC (rev 26788)
</span><span class="lines">@@ -147,6 +147,15 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><ins>+/* Active tabs use a bottom border color that matches the page background color. */
+
+.about-wrap h2 .nav-tab-active,
+.nav-tab-active,
+.nav-tab-active:hover {
+ border-bottom-color: $body-background;
+}
+
+
</ins><span class="cx"> /* Admin Menu: submenu */
</span><span class="cx">
</span><span class="cx"> #adminmenu .wp-submenu,
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_variablesscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors/_variables.scss (26787 => 26788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors/_variables.scss 2013-12-08 03:23:52 UTC (rev 26787)
+++ trunk/src/wp-admin/css/colors/_variables.scss 2013-12-08 04:11:20 UTC (rev 26788)
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx">
</span><span class="cx"> // global
</span><span class="cx">
</span><del>-$body-background: #eee !default;
</del><ins>+$body-background: #f3f3f3 !default;
</ins><span class="cx">
</span><span class="cx"> $link: #0074a2 !default;
</span><span class="cx"> $link-focus: lighten( $link, 10% ) !default;
</span></span></pre></div>
<a id="trunksrcwpadmincsscolorscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors.css (26787 => 26788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors.css 2013-12-08 03:23:52 UTC (rev 26787)
+++ trunk/src/wp-admin/css/colors.css 2013-12-08 04:11:20 UTC (rev 26788)
</span><span class="lines">@@ -17,7 +17,7 @@
</span><span class="cx"> ------------------------------------------------------------------------------*/
</span><span class="cx">
</span><span class="cx"> html {
</span><del>- background: #eee;
</del><ins>+ background: #f3f3f3;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Checkbooms */
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx">
</span><span class="cx"> ul#adminmenu a.wp-has-current-submenu:after,
</span><span class="cx"> ul#adminmenu > li.current > a.current:after {
</span><del>- border-right-color: #eee;
</del><ins>+ border-right-color: #f3f3f3;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .row-actions {
</span><span class="lines">@@ -1760,7 +1760,7 @@
</span><span class="cx"> color: #000;
</span><span class="cx"> background: none;
</span><span class="cx"> border-color: #ccc;
</span><del>- border-bottom-color: #eee;
</del><ins>+ border-bottom-color: #f3f3f3;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> h2.nav-tab-wrapper, h3.nav-tab-wrapper {
</span><span class="lines">@@ -1789,7 +1789,7 @@
</span><span class="cx">
</span><span class="cx"> .about-wrap h2 .nav-tab-active {
</span><span class="cx"> border-color: #ccc;
</span><del>- border-bottom-color: #eee;
</del><ins>+ border-bottom-color: #f3f3f3;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .about-wrap h2,
</span><span class="lines">@@ -1964,7 +1964,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> body.login {
</span><del>- background: #eee;
</del><ins>+ background: #f3f3f3;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .login #nav a,
</span></span></pre></div>
<a id="trunksrcwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/wp-admin.css (26787 => 26788)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/wp-admin.css 2013-12-08 03:23:52 UTC (rev 26787)
+++ trunk/src/wp-admin/css/wp-admin.css 2013-12-08 04:11:20 UTC (rev 26788)
</span><span class="lines">@@ -3298,7 +3298,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #activity-widget #the-comment-list .comment {
</span><del>- background: #f5f5f5;
</del><ins>+ background: #fafafa;
</ins><span class="cx"> padding: 12px;
</span><span class="cx"> position: relative;
</span><span class="cx"> }
</span><span class="lines">@@ -7845,7 +7845,8 @@
</span><span class="cx"> .about-wrap hr {
</span><span class="cx"> border: 0;
</span><span class="cx"> height: 0;
</span><del>- border-top: 1px solid rgba(0, 0, 0, 0.05);
</del><ins>+ margin: 0;
+ border-top: 1px solid rgba(0, 0, 0, 0.1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .about-wrap img {
</span><span class="lines">@@ -7924,15 +7925,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .about-wrap .about-overview-img {
</span><del>- border-bottom: 1px solid #ccc;
</del><ins>+ border-bottom: 1px solid rgba(0, 0, 0, 0.1);
</ins><span class="cx"> margin: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.about-wrap hr.flush-top {
- margin-top: 0;
- border-top: 1px solid #ccc;
-}
-
</del><span class="cx"> .about-colors-img img,
</span><span class="cx"> .about-themes-img img {
</span><span class="cx"> margin: 0 0;
</span></span></pre>
</div>
</div>
</body>
</html>