<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26702] trunk/src/wp-includes/js/customize-base.js: Customizer: Revert [26548], removing _.isEqual() for proper object comparison.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26702">26702</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-12-05 23:12:59 +0000 (Thu, 05 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Customizer: Revert <a href="http://core.trac.wordpress.org/changeset/26548">[26548]</a>, removing _.isEqual() for proper object comparison.
This broke the customizer in IE 11, with possibly other side effects. Revisit in 3.9.
Also reverts <a href="http://core.trac.wordpress.org/changeset/26632">[26632]</a>.
see <a href="http://core.trac.wordpress.org/ticket/26061">#26061</a> (reopens), fixes <a href="http://core.trac.wordpress.org/ticket/26438">#26438</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjscustomizebasejs">trunk/src/wp-includes/js/customize-base.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjscustomizebasejs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/js/customize-base.js (26701 => 26702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/js/customize-base.js 2013-12-05 23:09:23 UTC (rev 26701)
+++ trunk/src/wp-includes/js/customize-base.js 2013-12-05 23:12:59 UTC (rev 26702)
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx"> to = this.validate( to );
</span><span class="cx">
</span><span class="cx"> // Bail if the sanitized value is null or unchanged.
</span><del>- if ( null === to || this.isEqual( to ) )
</del><ins>+ if ( null === to || this._value === to )
</ins><span class="cx"> return this;
</span><span class="cx">
</span><span class="cx"> this._value = to;
</span><span class="lines">@@ -251,77 +251,6 @@
</span><span class="cx"> this.unlink( that );
</span><span class="cx"> });
</span><span class="cx"> return this;
</span><del>- },
-
- /**
- * Internal recursive comparison function for `isEqual`.
- * Copied from Underscore.js.
- */
- /* jshint ignore:start */
- _eq: function(a, b, aStack, bStack) {
- if (a === b) return a !== 0 || 1 / a == 1 / b;
- if (a == null || b == null) return a === b;
-
- var className = toString.call(a);
- if (className != toString.call(b)) return false;
- switch (className) {
- case '[object String]':
- return a == String(b);
- case '[object Number]':
- return a != +a ? b != +b : (a == 0 ? 1 / a == 1 / b : a == +b);
- case '[object Date]':
- case '[object Boolean]':
- return +a == +b;
- case '[object RegExp]':
- return a.source == b.source &&
- a.global == b.global &&
- a.multiline == b.multiline &&
- a.ignoreCase == b.ignoreCase;
- }
- if (typeof a != 'object' || typeof b != 'object') return false;
- var length = aStack.length;
- while (length--) {
- if (aStack[length] == a) return bStack[length] == b;
- }
- var aCtor = a.constructor, bCtor = b.constructor;
- if (aCtor !== bCtor && !((typeof aCtor === 'function') && (aCtor instanceof aCtor) &&
- (typeof bCtor === 'function') && (bCtor instanceof bCtor))) {
- return false;
- }
- aStack.push(a);
- bStack.push(b);
- var size = 0, result = true;
-
- if (className == '[object Array]') {
- size = a.length;
- result = size == b.length;
- if (result) {
- while (size--) {
- if (!(result = this._eq(a[size], b[size], aStack, bStack))) break;
- }
- }
- } else {
- for (var key in a) {
- if (hasOwnProperty.call(a, key)) {
- size++;
- if (!(result = hasOwnProperty.call(b, key) && this._eq(a[key], b[key], aStack, bStack))) break;
- }
- }
- if (result) {
- for (key in b) {
- if (hasOwnProperty.call(b, key) && !(size--)) break;
- }
- result = !size;
- }
- }
- aStack.pop();
- bStack.pop();
- return result;
- },
- /* jshint ignore:end */
-
- isEqual: function( to ) {
- return this._eq( this._value, to, [], [] );
</del><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>