<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26592] trunk: Ensure that theme customizer buttons don't overlap on small screens; allow small-screen theme popup to use the full height of the viewport since the adminmenu is no longer fixed; ensure that buttons in the theme customizer wrap as efficiently as they can on mobile.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26592">26592</a></dd>
<dt>Author</dt> <dd>iammattthomas</dd>
<dt>Date</dt> <dd>2013-12-03 21:13:14 +0000 (Tue, 03 Dec 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Ensure that theme customizer buttons don't overlap on small screens; allow small-screen theme popup to use the full height of the viewport since the adminmenu is no longer fixed; ensure that buttons in the theme customizer wrap as efficiently as they can on mobile. Fixes <a href="http://core.trac.wordpress.org/ticket/26361">#26361</a>, props mattheu, iammattthomas.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
<li><a href="#trunksrcwpadmincsscolors_adminscss">trunk/src/wp-admin/css/colors/_admin.scss</a></li>
<li><a href="#trunksrcwpadmincsswpadmincss">trunk/src/wp-admin/css/wp-admin.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4>Modified: trunk/Gruntfile.js (26591 => 26592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Gruntfile.js 2013-12-03 21:12:57 UTC (rev 26591)
+++ trunk/Gruntfile.js 2013-12-03 21:13:14 UTC (rev 26592)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> cwd: SOURCE_DIR,
</span><span class="cx"> dest: BUILD_DIR,
</span><span class="cx"> ext: '.css',
</span><del>- src: ['wp-admin/css/color-schemes/*/colors.scss'],
</del><ins>+ src: ['wp-admin/css/colors/*/colors.scss'],
</ins><span class="cx"> options: {
</span><span class="cx"> outputStyle: 'expanded'
</span><span class="cx"> }
</span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx"> dest: BUILD_DIR,
</span><span class="cx"> ext: '.min.css',
</span><span class="cx"> src: [
</span><del>- 'wp-admin/css/color-schemes/**/*.css'
</del><ins>+ 'wp-admin/css/colors/**/*.css'
</ins><span class="cx"> ]
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="lines">@@ -319,7 +319,7 @@
</span><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> colors: {
</span><del>- files: [SOURCE_DIR + 'wp-admin/css/color-schemes/**'],
</del><ins>+ files: [SOURCE_DIR + 'wp-admin/css/colors/**'],
</ins><span class="cx"> tasks: ['sass:colors']
</span><span class="cx"> },
</span><span class="cx"> rtl: {
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_adminscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/colors/_admin.scss (26591 => 26592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/colors/_admin.scss 2013-12-03 21:12:57 UTC (rev 26591)
+++ trunk/src/wp-admin/css/colors/_admin.scss 2013-12-03 21:13:14 UTC (rev 26592)
</span><span class="lines">@@ -410,6 +410,12 @@
</span><span class="cx"> color: $highlight-color;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.theme-overlay .theme-header .close:hover,
+.theme-overlay .theme-header .right:hover,
+.theme-overlay .theme-header .left:hover {
+ background: $highlight-color;
+}
+
</ins><span class="cx"> /* jQuery UI Slider */
</span><span class="cx">
</span><span class="cx"> .wp-slider .ui-slider-handle,
</span></span></pre></div>
<a id="trunksrcwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/wp-admin.css (26591 => 26592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/wp-admin.css 2013-12-03 21:12:57 UTC (rev 26591)
+++ trunk/src/wp-admin/css/wp-admin.css 2013-12-03 21:13:14 UTC (rev 26592)
</span><span class="lines">@@ -6698,7 +6698,7 @@
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="cx"> height: 48px;
</span><del>- border-bottom: 1px solid #eee;
</del><ins>+ border-bottom: 1px solid #ddd;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-header .close {
</span><span class="lines">@@ -6707,20 +6707,16 @@
</span><span class="cx"> width: 50px;
</span><span class="cx"> text-align: center;
</span><span class="cx"> float: right;
</span><del>- border-left: 1px solid #eee;
</del><ins>+ border-left: 1px solid #ddd;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.theme-overlay .theme-header .close:hover {
- background: #333;
-}
-
</del><span class="cx"> .theme-overlay .theme-header .close:hover:before {
</span><span class="cx"> color: #fff;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-header .close:before {
</span><del>- font: normal 30px/48px 'dashicons' !important;
- color: #bbb;
</del><ins>+ font: normal 30px/50px 'dashicons' !important;
+ color: #777;
</ins><span class="cx"> display: inline-block;
</span><span class="cx"> content: '\f335';
</span><span class="cx"> font-weight: 300;
</span><span class="lines">@@ -6730,20 +6726,22 @@
</span><span class="cx"> .theme-overlay .theme-header .right,
</span><span class="cx"> .theme-overlay .theme-header .left {
</span><span class="cx"> cursor: pointer;
</span><ins>+ color: #777;
</ins><span class="cx"> height: 48px;
</span><span class="cx"> width: 54px;
</span><span class="cx"> float: left;
</span><span class="cx"> text-align: center;
</span><del>- border-right: 1px solid #eee;
</del><ins>+ border-right: 1px solid #ddd;
</ins><span class="cx"> -webkit-user-select: none;
</span><span class="cx"> -moz-user-select: none;
</span><span class="cx"> -ms-user-select: none;
</span><span class="cx"> user-select: none;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.theme-overlay .theme-header .close:hover,
</ins><span class="cx"> .theme-overlay .theme-header .right:hover,
</span><span class="cx"> .theme-overlay .theme-header .left:hover {
</span><del>- background: #333;
</del><ins>+ background: #0074a2;
</ins><span class="cx"> color: #fff;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -6758,17 +6756,17 @@
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-header .right:before,
</span><span class="cx"> .theme-overlay .theme-header .left:before {
</span><del>- font: normal 16px/54px 'dashicons' !important;
</del><ins>+ font: normal 20px/50px 'dashicons' !important;
</ins><span class="cx"> display: inline;
</span><span class="cx"> font-weight: 300;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-header .left:before {
</span><del>- content: '\f341';
</del><ins>+ content: '\f340';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-header .right:before {
</span><del>- content: '\f345';
</del><ins>+ content: '\f344';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .rtl .theme-overlay .theme-header .left:before {
</span><span class="lines">@@ -6808,7 +6806,7 @@
</span><span class="cx"> .theme-overlay .theme-about {
</span><span class="cx"> position: absolute;
</span><span class="cx"> top: 49px;
</span><del>- bottom: 69px;
</del><ins>+ bottom: 57px;
</ins><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="cx"> overflow: auto;
</span><span class="lines">@@ -6828,7 +6826,7 @@
</span><span class="cx"> bottom: 0;
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><del>- padding: 20px 25px;
</del><ins>+ padding: 10px 25px 5px;
</ins><span class="cx"> background: #f3f3f3;
</span><span class="cx"> z-index: 30;
</span><span class="cx"> box-sizing: border-box;
</span><span class="lines">@@ -6837,14 +6835,14 @@
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-actions a {
</span><span class="cx"> margin-right: 5px;
</span><del>- margin-bottom: 0;
</del><ins>+ margin-bottom: 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-actions .delete-theme {
</span><span class="cx"> color: #a00;
</span><span class="cx"> position: absolute;
</span><span class="cx"> right: 10px;
</span><del>- bottom: 20px;
</del><ins>+ bottom: 5px;
</ins><span class="cx"> text-decoration: none;
</span><span class="cx"> border-color: transparent;
</span><span class="cx"> box-shadow: none;
</span><span class="lines">@@ -7112,12 +7110,14 @@
</span><span class="cx">
</span><span class="cx"> body.folded .theme-overlay .theme-wrap,
</span><span class="cx"> .theme-overlay .theme-wrap {
</span><del>- top: 45px;
</del><ins>+ top: 0; /* The adminmenu isn't fixed on mobile, so this can use the full viewport height */
</ins><span class="cx"> right: 0;
</span><span class="cx"> bottom: 0;
</span><span class="cx"> left: 0;
</span><span class="cx"> padding: 70px 20px 20px;
</span><span class="cx"> border: none;
</span><ins>+ z-index: 999999999;
+ position: fixed;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .theme-overlay .theme-screenshots {
</span><span class="lines">@@ -7152,6 +7152,16 @@
</span><span class="cx"> margin-top: 6px;
</span><span class="cx"> margin-right: 0;
</span><span class="cx"> }
</span><ins>+
+ .theme-overlay .theme-actions .delete-theme {
+ position: relative;
+ right: auto;
+ bottom: auto;
+ }
+
+ .theme-overlay .theme-actions .inactive-theme {
+ display: inline;
+ }
</ins><span class="cx">
</span><span class="cx"> .theme-overlay .theme-screenshots {
</span><span class="cx"> width: 100%;
</span></span></pre>
</div>
</div>
</body>
</html>