<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26370] trunk/tests/phpunit/tests: When setting `WP_TESTS_FORCE_KNOWN_BUGS` to `true`, it is preferable that some forced tests are still skipped when they call classes or functions that do not exist, producing fatal errors.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26370">26370</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2013-11-25 22:49:51 +0000 (Mon, 25 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>When setting `WP_TESTS_FORCE_KNOWN_BUGS` to `true`, it is preferable that some forced tests are still skipped when they call classes or functions that do not exist, producing fatal errors.
Fixes <a href="http://core.trac.wordpress.org/ticket/26248">#26248</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsdependenciesscriptsphp">trunk/tests/phpunit/tests/dependencies/scripts.php</a></li>
<li><a href="#trunktestsphpunittestsexportclasswpexportqueryphp">trunk/tests/phpunit/tests/export/class-wp-export-query.php</a></li>
<li><a href="#trunktestsphpunittestsexportfunctionsexportphp">trunk/tests/phpunit/tests/export/functions.export.php</a></li>
<li><a href="#trunktestsphpunittestsexportwritersphp">trunk/tests/phpunit/tests/export/writers.php</a></li>
<li><a href="#trunktestsphpunittestsformattingMapDeepphp">trunk/tests/phpunit/tests/formatting/MapDeep.php</a></li>
<li><a href="#trunktestsphpunittestsiteratorsphp">trunk/tests/phpunit/tests/iterators.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsdependenciesscriptsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/dependencies/scripts.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/dependencies/scripts.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/dependencies/scripts.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -97,6 +97,10 @@
</span><span class="cx"> * @ticket 22229
</span><span class="cx"> */
</span><span class="cx"> function test_json_encode_should_not_encode_special_literal_values() {
</span><ins>+ if ( ! class_exists( 'WP_JS_Literal' ) ) {
+ $this->markTestSkipped( "WP_JS_Literal class doesn't exist" );
+ }
+
</ins><span class="cx"> $literal = new WP_JS_Literal( 'baba()' );
</span><span class="cx"> $this->assertEquals( '{"x":baba()}', WP_JS_Literal::json_encode( array( 'x' => $literal ), array( $literal ) ) );
</span><span class="cx"> }
</span><span class="lines">@@ -105,6 +109,10 @@
</span><span class="cx"> * @ticket 22229
</span><span class="cx"> */
</span><span class="cx"> function test_json_encode_should_not_encode_special_literal_values_with_dependencies() {
</span><ins>+ if ( ! class_exists( 'WP_JS_Literal' ) ) {
+ $this->markTestSkipped( "WP_JS_Literal class doesn't exist" );
+ }
+
</ins><span class="cx"> $literal = new WP_JS_Literal( 'baba()', array( 'dep0', 'dep1' ) );
</span><span class="cx"> $this->assertEquals( '{"x":baba()}', WP_JS_Literal::json_encode( array( 'x' => $literal ), array( $literal ) ) );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsexportclasswpexportqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/export/class-wp-export-query.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/export/class-wp-export-query.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/export/class-wp-export-query.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -7,6 +7,14 @@
</span><span class="cx"> * @ticket 22435
</span><span class="cx"> */
</span><span class="cx"> class Test_WP_Export_Query extends WP_UnitTestCase {
</span><ins>+ function setUp() {
+ if ( ! class_exists( 'WP_Export_Query' ) ) {
+ $this->markTestSkipped( "WP_Export_Query class doesn't exist" );
+ }
+
+ parent::setUp();
+ }
+
</ins><span class="cx"> function test_WP_Export_Query_should_be_initialized_with_an_array() {
</span><span class="cx"> $export = new WP_Export_Query( array( 'author' => 'all' ) );
</span><span class="cx"> $this->assertTrue( (bool) $export );
</span></span></pre></div>
<a id="trunktestsphpunittestsexportfunctionsexportphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/export/functions.export.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/export/functions.export.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/export/functions.export.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -7,6 +7,14 @@
</span><span class="cx"> * @ticket 22435
</span><span class="cx"> */
</span><span class="cx"> class Test_WP_Export_Functions extends WP_UnitTestCase {
</span><ins>+ function setUp() {
+ if ( ! function_exists( 'wp_export' ) ) {
+ $this->markTestSkipped( "wp_export function doesn't exist" );
+ }
+
+ parent::setUp();
+ }
+
</ins><span class="cx"> function test_wp_export_returns_wp_error_if_the_writer_throws_Export_exception() {
</span><span class="cx"> $this->assertTrue( is_wp_error( wp_export( array( 'writer' => 'Test_WP_Export_Stub_Writer_Throws_Export_Exception' ) ) ) );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsexportwritersphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/export/writers.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/export/writers.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/export/writers.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -8,6 +8,9 @@
</span><span class="cx"> */
</span><span class="cx"> class Test_WP_Export_Writers extends WP_UnitTestCase {
</span><span class="cx"> function test_export_returner_returns_all_the_return_values() {
</span><ins>+ if ( ! class_exists( 'WP_Export_Returner' ) ) {
+ $this->markTestSkipped( "WP_Export_Returner class doesn't exist" );
+ }
</ins><span class="cx"> $returner = new WP_Export_Returner( $this->get_x_formatter() );
</span><span class="cx"> $this->assertEquals( 'xxx' , $returner->export() );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsformattingMapDeepphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/formatting/MapDeep.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/formatting/MapDeep.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/formatting/MapDeep.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -4,6 +4,14 @@
</span><span class="cx"> * @ticket 22300
</span><span class="cx"> */
</span><span class="cx"> class Tests_Formatting_MapDeep extends WP_UnitTestCase {
</span><ins>+ function setUp() {
+ if ( ! function_exists( 'map_deep' ) ) {
+ $this->markTestSkipped( "map_deep function doesn't exist" );
+ }
+
+ parent::setUp();
+ }
+
</ins><span class="cx"> function test_map_deep_with_any_function_over_empty_array_should_return_empty_array() {
</span><span class="cx"> $this->assertEquals( array(), map_deep( array( $this, 'return_baba' ), array() ) );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsiteratorsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/iterators.php (26369 => 26370)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/iterators.php 2013-11-25 07:03:44 UTC (rev 26369)
+++ trunk/tests/phpunit/tests/iterators.php 2013-11-25 22:49:51 UTC (rev 26370)
</span><span class="lines">@@ -4,6 +4,14 @@
</span><span class="cx"> * @ticket 22435
</span><span class="cx"> */
</span><span class="cx"> class Test_WP_Post_IDs_Iterator extends WP_UnitTestCase {
</span><ins>+ function setUp() {
+ if ( ! class_exists( 'WP_Post_IDs_Iterator' ) ) {
+ $this->markTestSkipped( "WP_Post_IDs_Iterator class doesn't exist" );
+ }
+
+ parent::setUp();
+ }
+
</ins><span class="cx"> function test_create() {
</span><span class="cx"> new WP_Post_IDs_Iterator( array( 1, 2, 3 ) );
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>