<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26287] trunk/src/wp-admin/js/widgets.js: Fix JSHint errors in widgets.js.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26287">26287</a></dd>
<dt>Author</dt> <dd>SergeyBiryukov</dd>
<dt>Date</dt> <dd>2013-11-20 11:11:01 +0000 (Wed, 20 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix JSHint errors in widgets.js.
props jorbin.
fixes <a href="http://core.trac.wordpress.org/ticket/26127">#26127</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjswidgetsjs">trunk/src/wp-admin/js/widgets.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjswidgetsjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/widgets.js (26286 => 26287)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/widgets.js 2013-11-20 05:08:22 UTC (rev 26286)
+++ trunk/src/wp-admin/js/widgets.js 2013-11-20 11:11:01 UTC (rev 26287)
</span><span class="lines">@@ -28,7 +28,9 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> $(document.body).bind('click.widgets-toggle', function(e){
</span><del>- var target = $(e.target), css = { 'z-index': 100 }, widget, inside, w;
</del><ins>+ var target = $(e.target),
+ css = { 'z-index': 100 },
+ widget, inside, targetWidth, widgetWidth, margin;
</ins><span class="cx">
</span><span class="cx"> if ( target.parents('.widget-top').length && ! target.parents('#available-widgets').length ) {
</span><span class="cx"> widget = target.closest('div.widget');
</span><span class="lines">@@ -68,8 +70,9 @@
</span><span class="cx">
</span><span class="cx"> sidebars.children('.widget').each(function() {
</span><span class="cx"> wpWidgets.appendTitle(this);
</span><del>- if ( $('p.widget-error', this).length )
</del><ins>+ if ( $('p.widget-error', this).length ) {
</ins><span class="cx"> $('a.widget-action', this).click();
</span><ins>+ }
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> $('#widget-list').children('.widget').draggable({
</span><span class="lines">@@ -84,8 +87,9 @@
</span><span class="cx"> the_id = this.id;
</span><span class="cx"> },
</span><span class="cx"> stop: function() {
</span><del>- if ( rem )
</del><ins>+ if ( rem ) {
</ins><span class="cx"> $(rem).hide();
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> rem = '';
</span><span class="cx"> }
</span><span class="lines">@@ -102,8 +106,9 @@
</span><span class="cx"> ui.item.children('.widget-inside').hide();
</span><span class="cx"> },
</span><span class="cx"> stop: function(e,ui) {
</span><del>- if ( ui.item.hasClass('ui-draggable') && ui.item.data('draggable') )
</del><ins>+ if ( ui.item.hasClass('ui-draggable') && ui.item.data('draggable') ) {
</ins><span class="cx"> ui.item.draggable('destroy');
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> if ( ui.item.hasClass('deleting') ) {
</span><span class="cx"> wpWidgets.save( ui.item, 1, 0, 1 ); // delete widget
</span><span class="lines">@@ -139,8 +144,9 @@
</span><span class="cx"> receive: function(e, ui) {
</span><span class="cx"> var sender = $(ui.sender);
</span><span class="cx">
</span><del>- if ( !$(this).is(':visible') || this.id.indexOf('orphaned_widgets') > -1 )
</del><ins>+ if ( ! $(this).is(':visible') || this.id.indexOf('orphaned_widgets') > -1 ) {
</ins><span class="cx"> sender.sortable('cancel');
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> if ( sender.attr('id').indexOf('orphaned_widgets') > -1 && !sender.children('.widget').length ) {
</span><span class="cx"> sender.parents('.orphan-sidebar').slideUp(400, function(){ $(this).remove(); });
</span><span class="lines">@@ -161,9 +167,10 @@
</span><span class="cx"> ui.draggable.addClass('deleting');
</span><span class="cx"> $('div.widget-placeholder').hide();
</span><span class="cx">
</span><del>- if ( ui.draggable.hasClass('ui-sortable-helper') )
</del><ins>+ if ( ui.draggable.hasClass('ui-sortable-helper') ) {
</ins><span class="cx"> $('#removing-widget').show().children('span')
</span><span class="cx"> .html( ui.draggable.find('div.widget-title').children('h4').html() );
</span><ins>+ }
</ins><span class="cx"> },
</span><span class="cx"> out: function(e,ui) {
</span><span class="cx"> ui.draggable.removeClass('deleting');
</span><span class="lines">@@ -206,7 +213,7 @@
</span><span class="cx"> selectSidebar.find( 'li' ).on( 'focusin.widgets-chooser', function() {
</span><span class="cx"> selectSidebar.find('.widgets-chooser-selected').removeClass( 'widgets-chooser-selected' );
</span><span class="cx"> $(this).addClass( 'widgets-chooser-selected' );
</span><del>- } )
</del><ins>+ } );
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -236,8 +243,9 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> saveOrder : function(sb) {
</span><del>- if ( sb )
</del><ins>+ if ( sb ) {
</ins><span class="cx"> $('#' + sb).closest('div.widgets-holder-wrap').find('.spinner').css('display', 'inline-block');
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> var a = {
</span><span class="cx"> action: 'widgets-order',
</span><span class="lines">@@ -246,8 +254,9 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> $('div.widgets-sortables').each( function() {
</span><del>- if ( $(this).sortable )
</del><ins>+ if ( $(this).sortable ) {
</ins><span class="cx"> a['sidebars[' + $(this).attr('id') + ']'] = $(this).sortable('toArray').join(',');
</span><ins>+ }
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> $.post( ajaxurl, a, function() {
</span><span class="lines">@@ -266,8 +275,9 @@
</span><span class="cx"> sidebar: sb
</span><span class="cx"> };
</span><span class="cx">
</span><del>- if ( del )
</del><ins>+ if ( del ) {
</ins><span class="cx"> a.delete_widget = 1;
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> data += '&' + $.param(a);
</span><span class="cx">
</span><span class="lines">@@ -275,11 +285,12 @@
</span><span class="cx"> var id;
</span><span class="cx">
</span><span class="cx"> if ( del ) {
</span><del>- if ( !$('input.widget_number', widget).val() ) {
</del><ins>+ if ( ! $('input.widget_number', widget).val() ) {
</ins><span class="cx"> id = $('input.widget-id', widget).val();
</span><span class="cx"> $('#available-widgets').find('input.widget-id').each(function(){
</span><del>- if ( $(this).val() === id )
</del><ins>+ if ( $(this).val() === id ) {
</ins><span class="cx"> $(this).closest('div.widget').show();
</span><ins>+ }
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -299,16 +310,18 @@
</span><span class="cx"> wpWidgets.appendTitle(widget);
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- if ( order )
</del><ins>+ if ( order ) {
</ins><span class="cx"> wpWidgets.saveOrder();
</span><ins>+ }
</ins><span class="cx"> });
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> appendTitle : function(widget) {
</span><span class="cx"> var title = $('input[id*="-title"]', widget).val() || '';
</span><span class="cx">
</span><del>- if ( title )
</del><ins>+ if ( title ) {
</ins><span class="cx"> title = ': ' + title.replace(/<[^<>]+>/g, '').replace(/</g, '<').replace(/>/g, '>');
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> $(widget).children('.widget-top').children('.widget-title').children()
</span><span class="cx"> .children('.in-widget-title').html(title);
</span></span></pre>
</div>
</div>
</body>
</html>