<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26265] trunk/src/wp-admin/js/inline-edit-tax.js: JSHint fixes for inline-edit-tax.js.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26265">26265</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-11-19 04:34:29 +0000 (Tue, 19 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>JSHint fixes for inline-edit-tax.js.
props dougwollison.
fixes <a href="http://core.trac.wordpress.org/ticket/26002">#26002</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjsinlineedittaxjs">trunk/src/wp-admin/js/inline-edit-tax.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjsinlineedittaxjs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/inline-edit-tax.js (26264 => 26265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/inline-edit-tax.js 2013-11-19 04:31:42 UTC (rev 26264)
+++ trunk/src/wp-admin/js/inline-edit-tax.js 2013-11-19 04:34:29 UTC (rev 26265)
</span><span class="lines">@@ -1,4 +1,6 @@
</span><ins>+/* global inlineEditL10n, ajaxurl */
</ins><span class="cx">
</span><ins>+var inlineEditTax;
</ins><span class="cx"> (function($) {
</span><span class="cx"> inlineEditTax = {
</span><span class="cx">
</span><span class="lines">@@ -14,34 +16,49 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // prepare the edit row
</span><del>- row.keyup(function(e) { if(e.which == 27) return inlineEditTax.revert(); });
</del><ins>+ row.keyup( function( e ) {
+ if ( e.which === 27 ) {
+ return inlineEditTax.revert();
+ }
+ });
</ins><span class="cx">
</span><del>- $('a.cancel', row).click(function() { return inlineEditTax.revert(); });
- $('a.save', row).click(function() { return inlineEditTax.save(this); });
- $('input, select', row).keydown(function(e) { if(e.which == 13) return inlineEditTax.save(this); });
</del><ins>+ $( 'a.cancel', row ).click( function() {
+ return inlineEditTax.revert();
+ });
+ $( 'a.save', row ).click( function() {
+ return inlineEditTax.save(this);
+ });
+ $( 'input, select', row ).keydown( function( e ) {
+ if ( e.which === 13 ) {
+ return inlineEditTax.save( this );
+ }
+ });
</ins><span class="cx">
</span><del>- $('#posts-filter input[type="submit"]').mousedown(function(e){
</del><ins>+ $( '#posts-filter input[type="submit"]' ).mousedown( function() {
</ins><span class="cx"> t.revert();
</span><span class="cx"> });
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> toggle : function(el) {
</span><span class="cx"> var t = this;
</span><del>- $(t.what+t.getId(el)).css('display') == 'none' ? t.revert() : t.edit(el);
</del><ins>+ $(t.what+t.getId(el)).css('display') === 'none' ? t.revert() : t.edit(el);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> edit : function(id) {
</span><del>- var t = this, editRow;
</del><ins>+ var editRow, rowData,
+ t = this;
</ins><span class="cx"> t.revert();
</span><span class="cx">
</span><del>- if ( typeof(id) == 'object' )
</del><ins>+ if ( typeof(id) === 'object' ) {
</ins><span class="cx"> id = t.getId(id);
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> editRow = $('#inline-edit').clone(true), rowData = $('#inline_'+id);
</span><span class="cx"> $('td', editRow).attr('colspan', $('.widefat:first thead th:visible').length);
</span><span class="cx">
</span><del>- if ( $(t.what+id).hasClass('alternate') )
</del><ins>+ if ( $( t.what + id ).hasClass( 'alternate' ) ) {
</ins><span class="cx"> $(editRow).addClass('alternate');
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> $(t.what+id).hide().after(editRow);
</span><span class="cx">
</span><span class="lines">@@ -57,8 +74,9 @@
</span><span class="cx"> save : function(id) {
</span><span class="cx"> var params, fields, tax = $('input[name="taxonomy"]').val() || '';
</span><span class="cx">
</span><del>- if( typeof(id) == 'object' )
</del><ins>+ if( typeof(id) === 'object' ) {
</ins><span class="cx"> id = this.getId(id);
</span><ins>+ }
</ins><span class="cx">
</span><span class="cx"> $('table.widefat .spinner').show();
</span><span class="cx">
</span><span class="lines">@@ -79,20 +97,23 @@
</span><span class="cx"> $('table.widefat .spinner').hide();
</span><span class="cx">
</span><span class="cx"> if (r) {
</span><del>- if ( -1 != r.indexOf('<tr') ) {
</del><ins>+ if ( -1 !== r.indexOf( '<tr' ) ) {
</ins><span class="cx"> $(inlineEditTax.what+id).remove();
</span><span class="cx"> new_id = $(r).attr('id');
</span><span class="cx">
</span><span class="cx"> $('#edit-'+id).before(r).remove();
</span><span class="cx"> row = new_id ? $('#'+new_id) : $(inlineEditTax.what+id);
</span><span class="cx"> row.hide().fadeIn();
</span><del>- } else
</del><ins>+ } else {
</ins><span class="cx"> $('#edit-'+id+' .inline-edit-save .error').html(r).show();
</span><del>- } else
</del><ins>+ }
+ } else {
</ins><span class="cx"> $('#edit-'+id+' .inline-edit-save .error').html(inlineEditL10n.error).show();
</span><ins>+ }
</ins><span class="cx">
</span><del>- if ($(row).prev('tr').hasClass('alternate'))
</del><ins>+ if ( $( row ).prev( 'tr' ).hasClass( 'alternate' ) ) {
</ins><span class="cx"> $(row).removeClass('alternate');
</span><ins>+ }
</ins><span class="cx"> }
</span><span class="cx"> );
</span><span class="cx"> return false;
</span><span class="lines">@@ -112,7 +133,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> getId : function(o) {
</span><del>- var id = o.tagName == 'TR' ? o.id : $(o).parents('tr').attr('id'), parts = id.split('-');
</del><ins>+ var id = o.tagName === 'TR' ? o.id : $(o).parents('tr').attr('id'), parts = id.split('-');
</ins><span class="cx"> return parts[parts.length - 1];
</span><span class="cx"> }
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>