<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26219] trunk/src: Improvements to the media uploader at responsive sizes:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26219">26219</a></dd>
<dt>Author</dt> <dd>iammattthomas</dd>
<dt>Date</dt> <dd>2013-11-15 19:53:50 +0000 (Fri, 15 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improvements to the media uploader at responsive sizes:
* Change load order so larger breakpoint loads before smaller breakpoint.
* Use absolute positioning rather than floats, to fix some overflow issues.
* Remove the max-height media query so desktop browsers benefit from the responsive styles.
* Reset text inputs to 16px so iOS doesn't force zoom.
* Adjust the position of the close button so it doesn't overlap the Create Gallery link.
See <a href="http://core.trac.wordpress.org/ticket/25977">#25977</a>. Props joen.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsswpadmincss">trunk/src/wp-admin/css/wp-admin.css</a></li>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/css/wp-admin.css (26218 => 26219)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/css/wp-admin.css 2013-11-15 19:02:09 UTC (rev 26218)
+++ trunk/src/wp-admin/css/wp-admin.css 2013-11-15 19:53:50 UTC (rev 26219)
</span><span class="lines">@@ -11895,21 +11895,11 @@
</span><span class="cx"> line-height: 1.5em;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- #media-items {
- width: 100%;
- }
-
- .media-modal {
- width: auto;
- }
-
- .media-frame {
- overflow: auto;
- }
-
</del><span class="cx"> .media-frame-menu {
</span><del>- position: relative;
</del><span class="cx"> width: auto;
</span><ins>+ bottom: auto;
+ right: 0;
+ height: 60px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-menu {
</span><span class="lines">@@ -11917,51 +11907,60 @@
</span><span class="cx"> position: relative;
</span><span class="cx"> border-bottom: 1px solid #dddddd;
</span><span class="cx"> overflow: hidden;
</span><ins>+ padding: 10px 0 10px 10px;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- .media-menu .separator {
- display: none;
- }
-
</del><span class="cx"> .media-menu a {
</span><span class="cx"> float: left;
</span><ins>+ width: 42%;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ overflow: hidden;
+ }
+
+ /* Shorten right-side links so they don't overlap the close button */
+ .media-menu a:nth-child(2),
+ .media-menu a:last-child {
</ins><span class="cx"> width: 40%;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-router, .media-frame-content, .media-frame-toolbar {
- left: auto;
- right: auto;
- top: auto;
- bottom: auto;
- position: relative;
</del><ins>+ .media-menu .separator {
+ display: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-frame-title {
</span><del>- top: auto;
</del><ins>+ top: 72px;
</ins><span class="cx"> left: auto;
</span><del>- right: 0;
</del><span class="cx"> height: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-frame-router {
- margin-top: 10px;
- }
-
</del><span class="cx"> .media-frame-title h1 {
</span><span class="cx"> line-height: 3;
</span><span class="cx"> font-size: 18px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- .media-router {
- bottom: -2px;
</del><ins>+ .media-frame-router {
+ top: 84px;
+ left: 0;
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> .media-frame-content {
</span><del>- min-height: 300px;
- max-height: 500px;
- overflow: auto;
</del><ins>+ left: 0;
+ top: 118px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ .media-frame .attachments-browser {
+ padding-bottom: 300px;
+ }
+
+ .media-sidebar {
+ border-bottom: 1px solid #dddddd;
+ }
+
+ .media-modal {
+ width: auto;
+ }
+
</ins><span class="cx"> .media-toolbar-primary, .media-toolbar-secondary {
</span><span class="cx"> height: auto;
</span><span class="cx"> }
</span><span class="lines">@@ -12338,95 +12337,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-/* Tiny screens [ = smaller than 400 wide, 600 tall] */
-@media screen and (max-width: 400px), screen and (max-height: 600px) {
- /* Align Add Media + Visual + Text tabs */
- #wp-content-media-buttons a {
- font-size: 14px;
- padding: 0 10px 0 10px;
- }
-
- .media-modal {
- position: fixed;
- top: 0;
- left: 0;
- right: 0;
- bottom: 0;
- }
-
- .media-modal-backdrop {
- position: fixed;
- }
-
- .attachments-browser .attachment,
- .attachments-browser .attachment-preview {
- max-width: 100%;
- }
-
- .attachments-browser .media-toolbar-primary input.search {
- max-width: 150px;
- }
-
- .uploader-inline-content {
- position: relative;
- }
-
- .media-sidebar .setting input[type="checkbox"],
- .media-sidebar .field input[type="checkbox"] {
- width: 25px;
- }
-
- /* Don't bother with title for phone-size */
- .media-frame-title {
- display: none;
- }
-
- .media-frame-toolbar {
- position: absolute;
- bottom: 0px;
- left: 0;
- right: 0;
- background: #FFF;
- border-top: 1px solid #DEDEDE;
- }
-
- .media-toolbar {
- position: relative;
- }
-
- .media-frame {
- overflow: hidden;
- }
-
- .media-frame .attachments-browser {
- padding-bottom: 300px;
- }
-
- .attachments-browser .attachments {
- top: 0;
- }
-
- .attachment-details h3 {
- margin-top: 45px;
- }
-
- /* Image From Link */
- .embed-link-settings,
- .embed-image-settings {
- padding-bottom: 52px;
- }
-
- /* Gallery */
- .media-frame.hide-router .media-frame-content {
- top: 0;
- border-top: none;
- }
-
- .gallery-settings h3 {
- margin-top: 45px;
- }
-}
-
</del><span class="cx"> @media only screen and (max-width: 500px) {
</span><span class="cx"> .about-wrap {
</span><span class="cx"> margin-right: 20px;
</span><span class="lines">@@ -12512,6 +12422,91 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+/* Tiny screens [ = smaller than 500 wide] */
+@media screen and (max-width: 500px) {
+ /* Align Add Media + Visual + Text tabs */
+ #wp-content-media-buttons a {
+ font-size: 14px;
+ padding: 0 10px 0 10px;
+ }
+
+ .media-modal {
+ position: fixed;
+ top: 0;
+ left: 0;
+ right: 0;
+ bottom: 0;
+ }
+
+ .media-modal-backdrop {
+ position: fixed;
+ }
+
+ .attachments-browser .attachment,
+ .attachments-browser .attachment-preview {
+ max-width: 100%;
+ }
+
+ .attachments-browser .media-toolbar-primary input.search {
+ max-width: 150px;
+ }
+
+ .uploader-inline-content {
+ position: relative;
+ }
+
+ .media-sidebar .setting input[type="checkbox"],
+ .media-sidebar .field input[type="checkbox"] {
+ width: 25px;
+ }
+
+ /* Don't bother with title for phone-size */
+ .media-frame-title {
+ display: none;
+ }
+
+ .media-frame-toolbar {
+ position: absolute;
+ bottom: 0px;
+ left: 0;
+ right: 0;
+ background: #FFF;
+ border-top: 1px solid #DEDEDE;
+ }
+
+ .media-toolbar {
+ position: relative;
+ }
+
+ .media-frame {
+ overflow: hidden;
+ }
+
+ .attachments-browser .attachments {
+ top: 42px;
+ }
+
+ .attachment-details h3 {
+ margin-top: 45px;
+ }
+
+ /* Image From Link */
+ .embed-link-settings,
+ .embed-image-settings {
+ padding-bottom: 52px;
+ }
+
+ /* Gallery */
+ .media-frame.hide-router .media-frame-content {
+ top: 73px;
+ border-top: none;
+ }
+
+ .gallery-settings h3 {
+ margin-top: 45px;
+ }
+}
+
</ins><span class="cx"> /* Smartphone */
</span><span class="cx"> @media screen and (max-width: 480px) {
</span><span class="cx"> #moby6-overlay {
</span></span></pre></div>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/css/media-views.css (26218 => 26219)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/css/media-views.css 2013-11-15 19:02:09 UTC (rev 26218)
+++ trunk/src/wp-includes/css/media-views.css 2013-11-15 19:53:50 UTC (rev 26219)
</span><span class="lines">@@ -1534,7 +1534,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-menu > a {
</span><del>- padding: 4px 10px;
</del><ins>+ padding: 4px 5px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-frame-title,
</span><span class="lines">@@ -1609,8 +1609,20 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .media-modal-close {
</span><del>- right: 20px;
</del><ins>+ right: 10px;
</ins><span class="cx"> }
</span><ins>+
+ /* Text inputs need to be 16px, or they force zooming on iOS */
+ .media-frame input[type="text"],
+ .media-frame input[type="password"],
+ .media-frame input[type="number"],
+ .media-frame input[type="search"],
+ .media-frame input[type="email"],
+ .media-frame input[type="url"],
+ .media-frame textarea,
+ .media-frame select {
+ font-size: 16px;
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @media only screen and (max-width: 800px) {
</span></span></pre>
</div>
</div>
</body>
</html>