<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26088] trunk/tests/phpunit/tests/ajax/MediaEdit.php: Avoid `Out of range value for column 'post_parent'` error in `Tests_Ajax_MediaEdit::_make_attachment()` by setting the default parent id to `0` instead of `-1`</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26088">26088</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2013-11-11 17:51:29 +0000 (Mon, 11 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid `Out of range value for column 'post_parent'` error in `Tests_Ajax_MediaEdit::_make_attachment()` by setting the default parent id to `0` instead of `-1`</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsajaxMediaEditphp">trunk/tests/phpunit/tests/ajax/MediaEdit.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsajaxMediaEditphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/ajax/MediaEdit.php (26087 => 26088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/ajax/MediaEdit.php 2013-11-11 17:45:36 UTC (rev 26087)
+++ trunk/tests/phpunit/tests/ajax/MediaEdit.php 2013-11-11 17:51:29 UTC (rev 26088)
</span><span class="lines">@@ -19,7 +19,7 @@
</span><span class="cx"> * @var array
</span><span class="cx"> */
</span><span class="cx"> protected $_ids = array();
</span><del>-
</del><ins>+
</ins><span class="cx"> /**
</span><span class="cx"> * Set up the test fixture.
</span><span class="cx"> */
</span><span class="lines">@@ -39,14 +39,14 @@
</span><span class="cx"> $uploads = wp_upload_dir();
</span><span class="cx"> foreach ( scandir( $uploads['basedir'] ) as $file )
</span><span class="cx"> _rmdir( $uploads['basedir'] . '/' . $file );
</span><del>-
</del><ins>+
</ins><span class="cx"> parent::tearDown();
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> /**
</span><span class="cx"> * Function snagged from ./tests/post/attachments.php
</span><span class="cx"> */
</span><del>- function _make_attachment($upload, $parent_post_id = -1) {
</del><ins>+ function _make_attachment($upload, $parent_post_id = 0) {
</ins><span class="cx"> $type = '';
</span><span class="cx"> if ( !empty($upload['type']) ) {
</span><span class="cx"> $type = $upload['type'];
</span><span class="lines">@@ -82,19 +82,19 @@
</span><span class="cx">
</span><span class="cx"> $upload = wp_upload_bits(basename($filename), null, $contents);
</span><span class="cx"> $id = $this->_make_attachment($upload);
</span><del>-
</del><ins>+
</ins><span class="cx"> $_REQUEST['action'] = 'image-editor';
</span><span class="cx"> $_REQUEST['context'] = 'edit-attachment';
</span><span class="cx"> $_REQUEST['postid'] = $id;
</span><span class="cx"> $_REQUEST['target'] = 'thumbnail';
</span><span class="cx"> $_REQUEST['do'] = 'save';
</span><span class="cx"> $_REQUEST['history'] = '[{"c":{"x":5,"y":8,"w":289,"h":322}}]';
</span><del>-
</del><ins>+
</ins><span class="cx"> $media_meta = wp_get_attachment_metadata($id);
</span><span class="cx"> $this->assertArrayHasKey('sizes', $media_meta, 'attachment should have size data');
</span><span class="cx"> $this->assertArrayHasKey('medium', $media_meta['sizes'], 'attachment should have data for medium size');
</span><span class="cx"> $ret = wp_save_image($id);
</span><del>-
</del><ins>+
</ins><span class="cx"> $media_meta = wp_get_attachment_metadata($id);
</span><span class="cx"> $this->assertArrayHasKey('sizes', $media_meta, 'cropped attachment should have size data');
</span><span class="cx"> $this->assertArrayHasKey('medium', $media_meta['sizes'], 'cropped attachment should have data for medium size');
</span></span></pre>
</div>
</div>
</body>
</html>